[Bug 16448] New: Perlcritic errors introduced by 12478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Bug ID: 16448 Summary: Perlcritic errors introduced by 12478 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/00-testcritic.t t/00-testcritic.t .. 113/728 # Failed test 'Test::Perl::Critic for "catalogue/search.pl"' # at /usr/share/perl5/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "catalogue/search.pl": # "@results" is declared but not used at line 475, column 1. Unused variables clutter code and make it harder to read. (Severity: 3) t/00-testcritic.t .. 262/728 # Failed test 'Test::Perl::Critic for "Koha/Authority.pm"' # at /usr/share/perl5/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "Koha/Authority.pm": # "return" statement with explicit "undef" at line 67, column 9. See page 199 of PBP. (Severity: 5) t/00-testcritic.t .. 723/728 # Looks like you failed 2 tests of 728. t/00-testcritic.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/728 subtests Test Summary Report ------------------- t/00-testcritic.t (Wstat: 512 Tests: 728 Failed: 2) Failed tests: 114, 265 Non-zero exit status: 2 Files=1, Tests=728, 139 wallclock secs ( 0.20 usr 0.01 sys + 127.21 cusr 10.62 csys = 138.04 CPU) Result: FAIL kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com Depends on| |12478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51237&action=edit Bug 16448: Fix perlcritic errors introduced by 12478 Bug 12478 introduced two perlcritic errors. This patch fixes them. To test: - On master, run: $ prove t/t/00-testcritic.t => FAIL: catalogue/search.pl and Koha/Authority.pm fail the critic tests. - Apply the patch - Run: $ prove t/t/00-testcritic.t => SUCCESS: All happy - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51237|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51254&action=edit [SIGNED-OFF]Bug 16448: Fix perlcritic errors introduced by 12478 Bug 12478 introduced two perlcritic errors. This patch fixes them. To test: - On master, run: $ prove t/00-testcritic.t => FAIL: catalogue/search.pl and Koha/Authority.pm fail the critic tests. - Apply the patch - Run: $ prove t/00-testcritic.t => SUCCESS: All happy - Sign off :-D Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test successful. Needs $ export TEST_QA=1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51254|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 51261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51261&action=edit [PASSED QA] Bug 16448: Fix perlcritic errors introduced by 12478 Bug 12478 introduced two perlcritic errors. This patch fixes them. To test: - On master, run: $ prove t/00-testcritic.t => FAIL: catalogue/search.pl and Koha/Authority.pm fail the critic tests. - Apply the patch - Run: $ prove t/00-testcritic.t => SUCCESS: All happy - Sign off :-D Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test successful. Needs $ export TEST_QA=1 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org