[Bug 16447] New: "Borrow Permission" should not be used anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Bug ID: 16447 Summary: "Borrow Permission" should not be used anymore Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 7976 has removed this permission, but other patches re-added it... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7976 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 [Bug 7976] "Borrow Permission" is not used and can be removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Bug 16447 depends on bug 7976, which changed state. Bug 7976 Summary: "Borrow Permission" is not used and can be removed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51231&action=edit Bug 16447: Remove occurrence of the borrow permission which does no longer exist Bug 7976 has removed this permission, but other patches re-added it... Note that the occurrences in sendbasket.pl and opac/svc/login should have been removed by bug 16447. Test plan: git grep 'borrow => 1' should not return any results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #1) (...)
Note that the occurrences in sendbasket.pl and opac/svc/login should have been removed by bug 16447. We are on Bug 16447 - mistake of bug number?
Test plan: git grep 'borrow => 1' should not return any results.
Is OK, but git grep 'borrow ' finds additonally: edithelp.pl: borrow => 1, t/db_dependent/Auth.t: borrow => 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51231|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51246&action=edit Bug 16447: Remove occurrence of the borrow permission which does no longer exist Bug 7976 has removed this permission, but other patches re-added it... Note that the occurrences in sendbasket.pl, edithelp.pl, opac/svc/login should have been removed by bug 7976. Test plan: git grep 'borrow.*=> 1' should not return any results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marc Véron from comment #2)
(In reply to Jonathan Druart from comment #1) (...)
Note that the occurrences in sendbasket.pl and opac/svc/login should have been removed by bug 16447. We are on Bug 16447 - mistake of bug number?
Test plan: git grep 'borrow => 1' should not return any results.
Is OK, but git grep 'borrow ' finds additonally:
edithelp.pl: borrow => 1, t/db_dependent/Auth.t: borrow => 0
Good catches, fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51246|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 51253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51253&action=edit Bug 16447: Remove occurrence of the borrow permission which does no longer exist Bug 7976 has removed this permission, but other patches re-added it... Note that the occurrences in sendbasket.pl, edithelp.pl, opac/svc/login should have been removed by bug 7976. Test plan: git grep 'borrow.*=> 1' should not return any results. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51253|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 51262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51262&action=edit [PASSED QA] Bug 16447: Remove occurrence of the borrow permission which does no longer exist Bug 7976 has removed this permission, but other patches re-added it... Note that the occurrences in sendbasket.pl, edithelp.pl, opac/svc/login should have been removed by bug 7976. Test plan: git grep 'borrow.*=> 1' should not return any results. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org