[Bug 32034] New: Library branch transfers should be in the action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Bug ID: 32034 Summary: Library branch transfers should be in the action logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Having branch transfers in the action logs would help to more fully show the cycle of holds that require transfers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 144543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144543&action=edit Bug 32034: Add item transfers to action logs Having branch transfers in the action logs would help to more fully show the cycle of holds that require transfers. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref LogTransfers 5) Create and finish some transfers, note the new logs in the log viewer! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Michael Adamyk <madamyk@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk@ckls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrewfh@dubcolib.org --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- This works, but there's a typo that causes the module to get written as "TRANFERS" rather than "TRANSFERS" (missing the 1st S). I tried to edit it and sign off on the amended patch, but I did something wrong and git yelled at me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144543|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 144581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144581&action=edit Bug 32034: Add item transfers to action logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #2)
This works, but there's a typo that causes the module to get written as "TRANFERS" rather than "TRANSFERS" (missing the 1st S). I tried to edit it and sign off on the amended patch, but I did something wrong and git yelled at me.
Good catch! Fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 144582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144582&action=edit Bug 32366: (bug 30460 follow-up) Add tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144582|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #6 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I'm not sure what happened when I tried to sign off on this before, but I can confirm this patch doesn't apply. I get this error in the provision logs: TASK [Apply bug 32034 via git-bz in docker container] ************************** fatal: [localhost -> koha-boo]: FAILED! => {"changed": true, "cmd": "cd /kohadevbox/koha && yes | git bz apply 32034", "delta": "0:00:05.882738", "end": "2023-01-09 15:54:40.137836", "msg": "non-zero return code", "rc": 1, "start": "2023-01-09 15:54:34.255098", "stderr": "Traceback (most recent call last):\n File \"/usr/bin/git-bz\", line 2716, in <module>\n applied = do_apply(bug_ref)\n File \"/usr/bin/git-bz\", line 1791, in do_apply\n print \"%d - %s\" % (patch.attach_id, patch.description)\nUnicodeEncodeError: 'ascii' codec can't encode character u'\\xa0' in position 12: ordinal not in range(128)", "stderr_lines": ["Traceback (most recent call last):", " File \"/usr/bin/git-bz\", line 2716, in <module>", " applied = do_apply(bug_ref)", " File \"/usr/bin/git-bz\", line 1791, in do_apply", " print \"%d - %s\" % (patch.attach_id, patch.description)", "UnicodeEncodeError: 'ascii' codec can't encode character u'\\xa0' in position 12: ordinal not in range(128)"], "stdout": "\nBug 32034 - Library branch transfers should be in the action logs", "stdout_lines": ["", "Bug 32034 - Library branch transfers should be in the action logs"]} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #6)
I'm not sure what happened when I tried to sign off on this before, but I can confirm this patch doesn't apply. I get this error in the provision logs:
Ack! The unicode error again! I was able to go into your sandbox and apply the bug using the koha-qa alias. No errors. I suppose that means ansible doesn't like some unicode character in the file or something. In any case, I created a sandbox for you with this patch applied: https://sandbox.bywatersolutions.com/ so you should be good to go! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- * Commit title does not start with 'Bug XXXXX: ' - ce32863a1e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #8)
* Commit title does not start with 'Bug XXXXX: ' - ce32863a1e
Fixed but a strange one.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #9)
(In reply to Marcel de Rooy from comment #8)
* Commit title does not start with 'Bug XXXXX: ' - ce32863a1e
Fixed but a strange one..
[PATCH] =?utf-8?q?Bug=C2=A032034:=20Add=20item=20transfers=20to?= =?utf-8?q?=20action=20logs?= -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Viewing history and commit message, this never got a signoff. Changing status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #12 from hebah@bywatersolutions.com --- Wanted to sign off on this as several partners are very interested in it, but looks like it hit the same encoding error as when Andrew tested: TASK [Apply bug 32034 via git-bz in docker container] ************************** fatal: [localhost -> koha-transferlog]: FAILED! => {"changed": true, "cmd": "koha-shell -c 'cd /kohadevbox/koha && yes | git bz apply 32034' transferlog", "delta": "0:00:03.408310", "end": "2023-03-03 21:17:20.388399", "msg": "non-zero return code", "rc": 1, "start": "2023-03-03 21:17:16.980089", "stderr": "Traceback (most recent call last):\n File \"/usr/bin/git-bz\", line 2716, in <module>\n applied = do_apply(bug_ref)\n File \"/usr/bin/git-bz\", line 1791, in do_apply\n print \"%d - %s\" % (patch.attach_id, patch.description)\nUnicodeEncodeError: 'ascii' codec can't encode character u'\\xa0' in position 12: ordinal not in range(128)", "stderr_lines": ["Traceback (most recent call last):", " File \"/usr/bin/git-bz\", line 2716, in <module>", " applied = do_apply(bug_ref)", " File \"/usr/bin/git-bz\", line 1791, in do_apply", " print \"%d - %s\" % (patch.attach_id, patch.description)", "UnicodeEncodeError: 'ascii' codec can't encode character u'\\xa0' in position 12: ordinal not in range(128)"], "stdout": "\nBug 32034 - Library branch transfers should be in the action logs", "stdout_lines": ["", "Bug 32034 - Library branch transfers should be in the action logs"]} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Christine Lee <chlee@pascolibraries.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chlee@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|kyle@bywatersolutions.com |tomascohen@gmail.com Status|Failed QA |ASSIGNED --- Comment #13 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Taking it from Kyle to help with it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144581|0 |1 is obsolete| | --- Comment #14 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 180991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180991&action=edit Bug 32034: Add new syspref 'TransferLog' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 --- Comment #15 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 180992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180992&action=edit Bug 32034: Add item transfers to action logs Having branch transfers in the action logs would help to more fully show the cycle of holds that require transfers. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref LogTransfers 5) Create and finish some transfers, note the new logs in the log viewer! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 --- Comment #16 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 180993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180993&action=edit Bug 32034: Add more tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 --- Comment #17 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Ok, I redid the changes and attributed them to Kyle. Basically the `viewlog.tt` template had some portions moved to an include so it would never apply. Test counts, the mega-tidy action got in the middle too, etc. I moved the syspref setting to the 'new style' and on its own commit. I kept Kyle's tests on the second commit, but added my own tests on a follow-up. On writing tests I noticed a couple bugs! I fixed them inline on Kyle's patch: * When you create the object and \'NOW()' is passed, it makes the JSON processing explode (and is not useful either!) because it cannot process a scalar reference. So I made it force re-reading from the DB. * The `$active` variable was always 'in_storage' because it was read after calling `$self->SUPER::store()`. I did this instead of failing, with Kyle's permission because he won't be able to come back soon. I tested the feature and it works as described/expected. QA script happy, besides a false negative message about sysprefs.sql. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180991|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181265&action=edit Bug 32034: Add new syspref 'TransferLog' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180992|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181266&action=edit Bug 32034: Add item transfers to action logs Having branch transfers in the action logs would help to more fully show the cycle of holds that require transfers. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref LogTransfers 5) Create and finish some transfers, note the new logs in the log viewer! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180993|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 181267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181267&action=edit Bug 32034: Add more tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Reports |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40724 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40724 [Bug 40724] Record diff in branchtransfer logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1151 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org