https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32034 --- Comment #17 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Ok, I redid the changes and attributed them to Kyle. Basically the `viewlog.tt` template had some portions moved to an include so it would never apply. Test counts, the mega-tidy action got in the middle too, etc. I moved the syspref setting to the 'new style' and on its own commit. I kept Kyle's tests on the second commit, but added my own tests on a follow-up. On writing tests I noticed a couple bugs! I fixed them inline on Kyle's patch: * When you create the object and \'NOW()' is passed, it makes the JSON processing explode (and is not useful either!) because it cannot process a scalar reference. So I made it force re-reading from the DB. * The `$active` variable was always 'in_storage' because it was read after calling `$self->SUPER::store()`. I did this instead of failing, with Kyle's permission because he won't be able to come back soon. I tested the feature and it works as described/expected. QA script happy, besides a false negative message about sysprefs.sql. -- You are receiving this mail because: You are watching all bug changes.