[Bug 37946] New: Double menu when clicking the caret in Z39.50 search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Bug ID: 37946 Summary: Double menu when clicking the caret in Z39.50 search Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When importing a record via Z39.50, you have the possibility of either clicking anywhere to get the Marc/Card/Import menu, or clicking the caret button next the the MARC button. Right now, if you click on the caret, both menus appear. To recreate: 1. Go to Cataloging 2. Click on New from Z39.50/SRU 3. Make a search in the library of congress server for anything (I searched for author: shakespeare) 4. Next to one of the results, click the caret button next to the MARC button --> Two MARC/Card/Import menus appear -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Depends on| |35402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37947 [Bug 37947] Import from Z39.50 doesn't open the record in editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171788&action=edit Bug 37946: Double menu when clicking the caret in Z39.50 search This patch makes some adjustments to the JS for the Z39.50 search results page to correct the behavior of dropdown menus. If the split button's menu trigger is clicked a cloned version of the menu shouldn't appear along with the default one. To test, apply the patch and clear your browser cache if necessary. - Go to Cataloging -> New from Z39.50. - Perform a search which will return multiple results. - Click any table cell in the results except the last one. - You should get a popup menu with "MARC preview," "Card preview," and "Import." - Each menu item should work correctly. - Test the button in the last column to confirm that both the "primary" button works correctly and that the popup menu works correctly. - Test the process of adding a new authority from Z39.50 to confirm that the authority search results table works the same as the bibliographic one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171788|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 171806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171806&action=edit Bug 37946: Double menu when clicking the caret in Z39.50 search This patch makes some adjustments to the JS for the Z39.50 search results page to correct the behavior of dropdown menus. If the split button's menu trigger is clicked a cloned version of the menu shouldn't appear along with the default one. To test, apply the patch and clear your browser cache if necessary. - Go to Cataloging -> New from Z39.50. - Perform a search which will return multiple results. - Click any table cell in the results except the last one. - You should get a popup menu with "MARC preview," "Card preview," and "Import." - Each menu item should work correctly. - Test the button in the last column to confirm that both the "primary" button works correctly and that the popup menu works correctly. - Test the process of adding a new authority from Z39.50 to confirm that the authority search results table works the same as the bibliographic one. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've signed off, but experienced some inconsistency/issues: 1. For authority records, search for 'clark' in the 'Name (any)' field 2. In the search results, click a result (say around the server column) - you get the options showing up (MARC preview, Import) 3. Click the MARC option in actions then close it 4. Try and click the selector for another result - the options don't appear 5. Click in various places for other results, sometimes the select menu options appear, other times they don't. It is a little bit hit-and-miss trying to replicate this 8-). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Failing QA for the 100% reproducible problem that clicking the primary button, then trying to click the caret for the popup never works. Prior to this patch it was already a bit funky, since the first click did nothing and then a second click would produce just one menu, but with the patch, no menu will ever appear for the popup caret on a row once you click the primary button (well, unless you discover how much better the click-anywhere menu is, and forswear ever again clicking the actions menubutton). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171828&action=edit Bug 37946: (follow-up) Update menu style to hide We shouldn't use hide() to hide the Bootstrap menu. The correct move here is to empty the "style" attribute. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171806|0 |1 is obsolete| | --- Comment #6 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 171843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171843&action=edit Bug 37946: Double menu when clicking the caret in Z39.50 search This patch makes some adjustments to the JS for the Z39.50 search results page to correct the behavior of dropdown menus. If the split button's menu trigger is clicked a cloned version of the menu shouldn't appear along with the default one. To test, apply the patch and clear your browser cache if necessary. - Go to Cataloging -> New from Z39.50. - Perform a search which will return multiple results. - Click any table cell in the results except the last one. - You should get a popup menu with "MARC preview," "Card preview," and "Import." - Each menu item should work correctly. - Test the button in the last column to confirm that both the "primary" button works correctly and that the popup menu works correctly. - Test the process of adding a new authority from Z39.50 to confirm that the authority search results table works the same as the bibliographic one. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171828|0 |1 is obsolete| | --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 171844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171844&action=edit Bug 37946: (follow-up) Update menu style to hide We shouldn't use hide() to hide the Bootstrap menu. The correct move here is to empty the "style" attribute. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171843|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174567&action=edit Bug 37946: Double menu when clicking the caret in Z39.50 search This patch makes some adjustments to the JS for the Z39.50 search results page to correct the behavior of dropdown menus. If the split button's menu trigger is clicked a cloned version of the menu shouldn't appear along with the default one. To test, apply the patch and clear your browser cache if necessary. - Go to Cataloging -> New from Z39.50. - Perform a search which will return multiple results. - Click any table cell in the results except the last one. - You should get a popup menu with "MARC preview," "Card preview," and "Import." - Each menu item should work correctly. - Test the button in the last column to confirm that both the "primary" button works correctly and that the popup menu works correctly. - Test the process of adding a new authority from Z39.50 to confirm that the authority search results table works the same as the bibliographic one. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171844|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174568&action=edit Bug 37946: (follow-up) Update menu style to hide We shouldn't use hide() to hide the Bootstrap menu. The correct move here is to empty the "style" attribute. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Bug 37946 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37946 Bug 37946 depends on bug 37947, which changed state. Bug 37947 Summary: Import from Z39.50 doesn't open the record in editor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37947 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org