[Bug 8816] New: add WARNING to debian/control file, to not manually edit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 Priority: P5 - low Change sponsored?: --- Bug ID: 8816 CC: robin@catalyst.net.nz Assignee: koha-bugs@lists.koha-community.org Summary: add WARNING to debian/control file, to not manually edit Severity: normal Classification: Unclassified OS: All Reporter: mtj@kohaaloha.com Hardware: All Status: NEW Version: master Component: Packaging Product: Koha many people manually edit the debian/control file, not realising that it is auto-generated, (and their changes will be lost) a warning message in the file, would stop people making this mistake -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 --- Comment #1 from Aaron Wells <aaronw@catalyst.net.nz> --- Created attachment 16847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16847&action=edit A patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 Aaron Wells <aaronw@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |aaronw@catalyst.net.nz Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- This looks totally safe to me. As it's not really essential, I'll let it go through the normal signoff process unless the RM feels like pushing it through. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 16880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16880&action=edit Bug 8816: Add warning about manual edits to top of debian/control And we need to add it to control.in as well, because control is created from control.in (which is the whole point of the warning ;) Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #2)
This looks totally safe to me. As it's not really essential, I'll let it go through the normal signoff process unless the RM feels like pushing it through.
hmm, #comment lines seem to cause a parsing error, and make Parse::Deb::Control barf "Field names must not begin with the comment character, #." http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-controlsynta... i'll send a patch to fix -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16847|0 |1 is obsolete| | Attachment #16880|0 |1 is obsolete| | --- Comment #5 from Mason James <mtj@kohaaloha.com> --- Created attachment 16901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16901&action=edit Bug 8816: Add warning about manual edits to top of debian/control And we need to add it to control.in as well, because control is created from control.in (which is the whole point of the warning ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #4)
(In reply to comment #2)
This looks totally safe to me. As it's not really essential, I'll let it go through the normal signoff process unless the RM feels like pushing it through.
hmm, #comment lines seem to cause a parsing error
oops, my bad the #comment lines are ok after all, i'll revert my new patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16901|0 |1 is obsolete| | --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Comment on attachment 16901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16901 Bug 8816: Add warning about manual edits to top of debian/control
From 58ee3231373b451f433d61befa41b45f5e4704ac Mon Sep 17 00:00:00 2001 From: Mason James <mtj@kohaaloha.com> Date: Wed, 27 Mar 2013 07:44:55 +1300 Subject: [PATCH] Bug 8816: Add warning about manual edits to top of debian/control Content-Type: text/plain; charset="utf-8"
And we need to add it to control.in as well, because control is created from control.in (which is the whole point of the warning ;) --- debian/control | 17 ++++++++++++----- debian/control.in | 13 ++++++++----- 2 files changed, 20 insertions(+), 10 deletions(-)
diff --git a/debian/control b/debian/control index be19e0c..b8e827c 100644 --- a/debian/control +++ b/debian/control @@ -3,9 +3,16 @@ Maintainer: Robin Sheat <robin@catalyst.net.nz> Section: web Priority: optional Standards-Version: 3.8.4 -# NOTA BENE: Build dependencies end up as runtime dependencies as well. -# See debian/rules, the override_dh_gencontrol rules. -# There are some exceptions. +XBC-Comment: WARNING: The "control" file is manually generated from the "control.in" file. + Do not manually edit "control" or your changes will be clobbered when you + run update-control + NOTA BENE: Build dependencies end up as runtime dependencies as well. + See debian/rules, the override_dh_gencontrol rules. + There are some exceptions. +Build-Depends:__AUTODEPENDS__, + debhelper (>= 7.0.50), gettext, python, python-debian, xsltproc, docbook-xsl, + libxml2-utils + Build-Depends: libalgorithm-checkdigits-perl, libanyevent-http-perl, libanyevent-perl, @@ -111,7 +118,7 @@ Build-Depends: libalgorithm-checkdigits-perl, libyaml-perl, libyaml-syck-perl, perl, - perl-modules, + perl-modules, debhelper (>= 7.0.50), gettext, python, python-debian, xsltproc, docbook-xsl, libxml2-utils
@@ -130,7 +137,7 @@ Depends: ${misc:Depends}, ${koha:Depends}, perl-doc, pwgen, sudo, - tinymce2, + tinymce2, unzip, xmlstarlet, yaz diff --git a/debian/control.in b/debian/control.in index a30aeed..b84c040 100644 --- a/debian/control.in +++ b/debian/control.in @@ -3,10 +3,13 @@ Maintainer: Robin Sheat <robin@catalyst.net.nz> Section: web Priority: optional Standards-Version: 3.8.4 -# NOTA BENE: Build dependencies end up as runtime dependencies as well. -# See debian/rules, the override_dh_gencontrol rules. -# There are some exceptions. -Build-Depends:__AUTODEPENDS__, +XBC-Comment: WARNING: The "control" file is manually generated from the "control.in" file. + Do not manually edit "control" or your changes will be clobbered when you + run update-control + NOTA BENE: Build dependencies end up as runtime dependencies as well. + See debian/rules, the override_dh_gencontrol rules. + There are some exceptions. +Build-Depends:__AUTODEPENDS__, debhelper (>= 7.0.50), gettext, python, python-debian, xsltproc, docbook-xsl, libxml2-utils
@@ -25,7 +28,7 @@ Depends: ${misc:Depends}, ${koha:Depends}, perl-doc, pwgen, sudo, - tinymce2, + tinymce2, unzip, xmlstarlet, yaz -- 1.7.2.5
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16880|1 |0 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16880|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17068&action=edit [PASSED QA] Bug 8816: Add warning about manual edits to top of debian/control And we need to add it to control.in as well, because control is created from control.in (which is the whole point of the warning ;) Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Adds comments with a warning. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. Welcome, Aaron, you're the 207th person to have a patch committed to Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- This was pushed to 3.10.x and released in 3.10.5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org