[Bug 9873] New: Quiet errors in the log from XSLT.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9873 Bug ID: 9873 Summary: Quiet errors in the log from XSLT.pm Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Staff Client Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org CC: gmcharlt@gmail.com If XSLTResultsDisplay is enabled errors can appear in the staff client log complaining "Use of uninitialized value in hash element at C4/XSLT.pm line 282. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9873 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9873 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16535&action=edit Bug 9873 - Quiet errors in the log from XSLT.pm If XSLTResultsDisplay is enabled and items in your search results lack a shelving location or a ccode errors will appear in the log complaining of "uninitialized value in hash element." This patch adds a check on these values to quiet the errors. To test, find or create a record with items which have no shelving location and/or no collection code. Perform a search the results for which will include your record. Check for errors in the log. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9873 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9873 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16535|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17018&action=edit Bug 9873 - Quiet errors in the log from XSLT.pm If XSLTResultsDisplay is enabled and items in your search results lack a shelving location or a ccode errors will appear in the log complaining of "uninitialized value in hash element." This patch adds a check on these values to quiet the errors. To test, find or create a record with items which have no shelving location and/or no collection code. Perform a search the results for which will include your record. Check for errors in the log. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9873 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9873 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17018|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17067&action=edit [PASSED QA] Bug 9873 - Quiet errors in the log from XSLT.pm If XSLTResultsDisplay is enabled and items in your search results lack a shelving location or a ccode errors will appear in the log complaining of "uninitialized value in hash element." This patch adds a check on these values to quiet the errors. To test, find or create a record with items which have no shelving location and/or no collection code. Perform a search the results for which will include your record. Check for errors in the log. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Cleans up logs for result list quite a bit. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9873 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9873 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- This doesn't apply to 3.10.x please send a new patch if you wish it back ported -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org