[Bug 29723] New: Add a "Configure table" button for KohaTable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Bug ID: 29723 Summary: Add a "Configure table" button for KohaTable tables Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org We could have a "Configure table" link/button on the table that are a "KohaTable" table that can be configurable in the administration area. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Depends on| |29648 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128648&action=edit Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Owen, do you think we need this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131874&action=edit Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131874|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- I suspect the "Configure table" button would only appear if one had the correct permissions. I think it's a nice idea since it can be difficult to determine what you need to edit from columns_settings.pl. +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Jonathan, The patch looks nice. The QA tool says you need a filter: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc FAIL filters missing_filter at line 28 (var CAN_user_parameters_manage_column_config = [% CAN_user_parameters_manage_column_config ? 1 : 0 %];) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128648|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133029&action=edit Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Lucas Gass from comment #5)
Jonathan,
The patch looks nice. The QA tool says you need a filter:
FAIL koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc FAIL filters missing_filter at line 28 (var CAN_user_parameters_manage_column_config = [% CAN_user_parameters_manage_column_config ? 1 : 0 %];)
Fixed, thanks Lucas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> ---
Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin?
Is this because those <div>'s have ID's like: "detail#holdings_table" or "member#memberresultst". I suppose this is a valid ID but I think it gets messed up when we try to apply the in page anchor to the URL: "http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl?module=catalogu..." Maybe a separate bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Bug 29723 depends on bug 29648, which changed state. Bug 29648 Summary: Make KohaTable tables 'default length' and 'default sort' configurable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133029|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138951&action=edit Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138952&action=edit Bug 29723: (QA follow-up) Make button text translatable This patch makes the button text translatable. Whilst we're here I also added a wrench icon, set the title attribute and added a class. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thought I'd have a go at rescuing this one.. it needs a bit of adaptation for bug 30494 now we're using bootstrap collapse as opposed to jQuery accordion. I feel like we should update the column settings page to add id's to each of the card expand headings that match the module names instead of using our current index approach.. then we can pass module from here to at least restore opening the right panel.. hopefully we can also come up with a solution to hit the right anchor on the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Indeed, this needs to be rethink. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |oleonard@myacpl.org |com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138951|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138972&action=edit Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138952|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138973&action=edit Bug 29723: (QA follow-up) Make button text translatable This patch makes the button text translatable. Whilst we're here I also added a wrench icon, set the title attribute and added a class. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138974&action=edit Bug 29723: (QA follow-up) Switch to using ID's on column settings This patch updates the column settings page to use ID's instead of Indexes to restor the open accordian card after a setting change. Test plan 1 Go to Administration -> Table settings. 2 All panels should be collapsed. 3 Test expanding and collapsing panels to confirm it's working correctly. 4 Make a change to one of the table configurations. After clicking "Save" the page should reload with the same panel expanded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138975&action=edit Bug 29723: Correct scroll to table This patch enabled scrolling directly to the correct table configuration when clicking the 'Configure this table' button from any KohaTable/kohaTable table in Koha. Test plan 1. Navigate to Administration > Cities 2. Click 'Configure this table' 3. Confirm the result is the table settings page and you are scrolled to the cities table configuration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I'm happy this now works as one would expect.. However, I'd still love to refine it a little further.. I don't like that the query parameters I'm passing stay in the URL.. not sure how to resolve that. My scroll feels a little hacky to, but so far it's the best I could come up with. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It does not work from this table: /cgi-bin/koha/circ/pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch.. anoying that we're not consistent with our panel name/id's vs module names. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138972|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138985&action=edit Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138973|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138986&action=edit Bug 29723: (QA follow-up) Make button text translatable This patch makes the button text translatable. Whilst we're here I also added a wrench icon, set the title attribute and added a class. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138974|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138987&action=edit Bug 29723: (QA follow-up) Switch to using ID's on column settings This patch updates the column settings page to use ID's instead of Indexes to restor the open accordian card after a setting change. Test plan 1 Go to Administration -> Table settings. 2 All panels should be collapsed. 3 Test expanding and collapsing panels to confirm it's working correctly. 4 Make a change to one of the table configurations. After clicking "Save" the page should reload with the same panel expanded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138988&action=edit Bug 29723: (QA follow-up) Correct scroll to table This patch enabled scrolling directly to the correct table configuration when clicking the 'Configure this table' button from any KohaTable/kohaTable table in Koha. Test plan 1. Navigate to Administration > Cities 2. Click 'Configure this table' 3. Confirm the result is the table settings page and you are scrolled to the cities table configuration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138989&action=edit Bug 29723: (QA follow-up) Ensure ID's match Module names There was a disparity between module codes and how it was used to construct ID's for various elements.. this patch updates ID's to match codes for circulation and illrequests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #25 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- *** Bug 26863 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138985|0 |1 is obsolete| | --- Comment #26 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 138992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138992&action=edit Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Andrew <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138986|0 |1 is obsolete| | --- Comment #27 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 138993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138993&action=edit Bug 29723: (QA follow-up) Make button text translatable This patch makes the button text translatable. Whilst we're here I also added a wrench icon, set the title attribute and added a class. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Andrew <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138987|0 |1 is obsolete| | --- Comment #28 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 138994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138994&action=edit Bug 29723: (QA follow-up) Switch to using ID's on column settings This patch updates the column settings page to use ID's instead of Indexes to restor the open accordian card after a setting change. Test plan 1 Go to Administration -> Table settings. 2 All panels should be collapsed. 3 Test expanding and collapsing panels to confirm it's working correctly. 4 Make a change to one of the table configurations. After clicking "Save" the page should reload with the same panel expanded. Signed-off-by: Andrew <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138988|0 |1 is obsolete| | --- Comment #29 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 138995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138995&action=edit Bug 29723: (QA follow-up) Correct scroll to table This patch enabled scrolling directly to the correct table configuration when clicking the 'Configure this table' button from any KohaTable/kohaTable table in Koha. Test plan 1. Navigate to Administration > Cities 2. Click 'Configure this table' 3. Confirm the result is the table settings page and you are scrolled to the cities table configuration Signed-off-by: Andrew <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138989|0 |1 is obsolete| | --- Comment #30 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 138996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138996&action=edit Bug 29723: (QA follow-up) Ensure ID's match Module names There was a disparity between module codes and how it was used to construct ID's for various elements.. this patch updates ID's to match codes for circulation and illrequests. Signed-off-by: Andrew <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138993|0 |1 is obsolete| | Attachment #138994|0 |1 is obsolete| | Attachment #138995|0 |1 is obsolete| | Attachment #138996|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138997&action=edit Bug 29723: (QA follow-up) Make button text translatable This patch makes the button text translatable. Whilst we're here I also added a wrench icon, set the title attribute and added a class. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138998&action=edit Bug 29723: (QA follow-up) Switch to using ID's on column settings This patch updates the column settings page to use ID's instead of Indexes to restor the open accordian card after a setting change. Test plan 1 Go to Administration -> Table settings. 2 All panels should be collapsed. 3 Test expanding and collapsing panels to confirm it's working correctly. 4 Make a change to one of the table configurations. After clicking "Save" the page should reload with the same panel expanded. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138999&action=edit Bug 29723: (QA follow-up) Correct scroll to table This patch enabled scrolling directly to the correct table configuration when clicking the 'Configure this table' button from any KohaTable/kohaTable table in Koha. Test plan 1. Navigate to Administration > Cities 2. Click 'Configure this table' 3. Confirm the result is the table settings page and you are scrolled to the cities table configuration Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 139000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139000&action=edit Bug 29723: (QA follow-up) Ensure ID's match Module names There was a disparity between module codes and how it was used to construct ID's for various elements.. this patch updates ID's to match codes for circulation and illrequests. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Thanks, Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138992|0 |1 is obsolete| | Attachment #138997|0 |1 is obsolete| | Attachment #138998|0 |1 is obsolete| | Attachment #138999|0 |1 is obsolete| | Attachment #139000|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 139002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139002&action=edit Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Andrew <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 139003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139003&action=edit Bug 29723: (QA follow-up) Make button text translatable This patch makes the button text translatable. Whilst we're here I also added a wrench icon, set the title attribute and added a class. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Andrew <andrewfh@dubcolib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 139004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139004&action=edit Bug 29723: (QA follow-up) Switch to using ID's on column settings This patch updates the column settings page to use ID's instead of Indexes to restor the open accordian card after a setting change. Test plan 1 Go to Administration -> Table settings. 2 All panels should be collapsed. 3 Test expanding and collapsing panels to confirm it's working correctly. 4 Make a change to one of the table configurations. After clicking "Save" the page should reload with the same panel expanded. Signed-off-by: Andrew <andrewfh@dubcolib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 139005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139005&action=edit Bug 29723: (QA follow-up) Correct scroll to table This patch enabled scrolling directly to the correct table configuration when clicking the 'Configure this table' button from any KohaTable/kohaTable table in Koha. Test plan 1. Navigate to Administration > Cities 2. Click 'Configure this table' 3. Confirm the result is the table settings page and you are scrolled to the cities table configuration Signed-off-by: Andrew <andrewfh@dubcolib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 139006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139006&action=edit Bug 29723: (QA follow-up) Ensure ID's match Module names There was a disparity between module codes and how it was used to construct ID's for various elements.. this patch updates ID's to match codes for circulation and illrequests. Signed-off-by: Andrew <andrewfh@dubcolib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I hadn't noticed we overlapped, Andrew. I've reattached the patches with your stamp! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #42 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Jonathan Druart from comment #41)
I hadn't noticed we overlapped, Andrew. I've reattached the patches with your stamp!
No worries! The status was still Signed Off, so I wasn't sure if it needed another or not, but I was excited to see it in action :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks everyone, great to see this over the line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #44 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 139194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139194&action=edit Bug 29723: (QA follow-up) _ vs __ Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #45 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 [Bug 31428] Shorten new button text "Configure this table" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 [Bug 31435] "Configure this table" appears for non-configurable tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #46 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 [Bug 33705] Quote of the day: table has configure button even if it's not configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de Documentation| |Philip Orr contact| | --- Comment #47 from Philip Orr <philip.orr@lmscloud.de> --- Documenting this now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org