https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |ASSIGNED Depends on| |27015 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27015 [Bug 27015] Add filtering options to the pickup_locations routes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113738&action=edit Bug 27016: Make the pickup locations dropdowns use Select2 On the shoulders of bug 27015, this patch makes the pickup locations dropdowns use Select2 to handle both fetching the pickup location on-deman through the API, and also searching for them. This provides a better user experience for really big lists. To test: 1. Have some holds on a biblio => SUCCESS: Bug 26988 works, made it load the data when you click on the dropdowns. 2. Apply this patch 3. Reload the page => SUCCESS: Similar-ish behaviour => SUCCESS: Notice you can search for branch names and make the list shrink 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113738|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113740&action=edit Bug 27016: Make the pickup locations dropdowns use Select2 On the shoulders of bug 27015, this patch makes the pickup locations dropdowns use Select2 to handle both fetching the pickup location on-deman through the API, and also searching for them. This provides a better user experience for really big lists. To test: 1. Have some holds on a biblio => SUCCESS: Bug 26988 works, made it load the data when you click on the dropdowns. 2. Apply this patch 3. Reload the page => SUCCESS: Similar-ish behaviour => SUCCESS: Notice you can search for branch names and make the list shrink 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113740|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 113760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113760&action=edit Bug 27016: Make the pickup locations dropdowns use Select2 On the shoulders of bug 27015, this patch makes the pickup locations dropdowns use Select2 to handle both fetching the pickup location on-deman through the API, and also searching for them. This provides a better user experience for really big lists. To test: 1. Have some holds on a biblio => SUCCESS: Bug 26988 works, made it load the data when you click on the dropdowns. 2. Apply this patch 3. Reload the page => SUCCESS: Similar-ish behaviour => SUCCESS: Notice you can search for branch names and make the list shrink 4. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Nind from comment #4)

The only thing I noticed when testing is that for library names with spaces in the name wrap (such as Institut Protestant de Théologie), rather than being on the same 'line'.

I'm assuming this is the default behaviour for Select2.

Good point. We could fix that. I felt like the experience was better with no geometry changes when the API call gets the results. So I'm open to discuss this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Nind from comment #6)

I think it is a great improvement.

Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113760|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113791&action=edit Bug 27016: Make the pickup locations dropdowns use Select2 On the shoulders of bug 27015, this patch makes the pickup locations dropdowns use Select2 to handle both fetching the pickup location on-deman through the API, and also searching for them. This provides a better user experience for really big lists. To test: 1. Have some holds on a biblio => SUCCESS: Bug 26988 works, made it load the data when you click on the dropdowns. 2. Apply this patch 3. Reload the page => SUCCESS: Similar-ish behaviour => SUCCESS: Notice you can search for branch names and make the list shrink 4. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 Bug 27016 depends on bug 26988, which changed state. Bug 26988 Summary: Defer loading the hold pickup locations until the dropdown is selected https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114807&action=edit Bug 27016: Use $.fn.select2.defaults.set to set select2's width See commit ff7318c62ec7097c5b88f7278b71d0cc7feb1f39 Bug 27124: JS error "select2Width is not defined" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement improves release notes| |the display of the pickup | |library dropdown list in | |the holds section for a | |record, particularly for | |long lists. Enhancements | |include being able to start | |typing the name of the | |library and search for the | |library. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27732 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27732 [Bug 27732] JavaScript error on place hold page in the staff interface -- You are receiving this mail because: You are watching all bug changes.