[Bug 27886] New: Authority linking broken in advanced editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27886 Bug ID: 27886 Summary: Authority linking broken in advanced editor Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Manual Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: abl@biblos.pk.edu.pl, aleisha@catalyst.net.nz, alexis.ripetti@inLibro.com, andrew@bywatersolutions.com, black23@gmail.com, caroline.cyr-la-rose@inlibro.com, dcook@prosentient.com.au, eric.begin@inLibro.com, fcapovilla@live.ca, fpichenot@ville-roubaix.fr, frank.hansen@ub.lu.se, fridolin.somers@biblibre.com, jonathan.druart@bugs.koha-community.org, joonas.kylmala@helsinki.fi, josef.moravec@gmail.com, katrin.fischer@bsz-bw.de, m.de.rooy@rijksmuseum.nl, marjorie.barry-vila@collecto.ca, martin.renvoize@ptfs-europe.com, mtompset@hotmail.com, niamh.walker-headon@it-tallaght.ie, nick@bywatersolutions.com, nicolas.bravais@gmail.com, patrick.robitaille@collecto.ca, phil@chetcolibrary.org, philippe.blouin@inlibro.com, r.delahunty@arts.ac.uk, testopia@bugs.koha-community.org, vanoudt@gmail.com, verolencinas@yahoo.com.ar Depends on: 11299 In the advanced MARC editor, the keyboard shortcut Ctrl-Shift-L triggers a popup where you can search for an authority record. Select a result from that window doesn't work to populate the field in the editor. The pop-up window which uses blinddetail-biblio-search.tt triggers a JavaScript error and never closes. git bisect blames Bug 11299 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27886 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can confirm the broken behaviour. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27886 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27886 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 117886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117886&action=edit Bug 27886: Move non-rancor code into correct section The template was including code that was not compatible with Rancor, moving the end of the conditional seems to fix the error To test: 1 - Open a record in the advanced catalog editor 2 - Create or edit a 100 field with some content, I used 'bruce' 3 - Press Ctrl+shift+l to launch authority search 4 - Perform a search and select an authority 5 - Note the field copies but the pop-ups don't close 6 - Apply patch 7 - Reload the page 8 - Repeat 1-4 9 - The field copies and the windows close -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27886 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27886 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27886 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117886|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 117887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117887&action=edit Bug 27886: Move non-rancor code into correct section The template was including code that was not compatible with Rancor, moving the end of the conditional seems to fix the error To test: 1 - Open a record in the advanced catalog editor 2 - Create or edit a 100 field with some content, I used 'bruce' 3 - Press Ctrl+shift+l to launch authority search 4 - Perform a search and select an authority 5 - Note the field copies but the pop-ups don't close 6 - Apply patch 7 - Reload the page 8 - Repeat 1-4 9 - The field copies and the windows close Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27886 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117887|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117889&action=edit Bug 27886: Move non-rancor code into correct section The template was including code that was not compatible with Rancor, moving the end of the conditional seems to fix the error To test: 1 - Open a record in the advanced catalog editor 2 - Create or edit a 100 field with some content, I used 'bruce' 3 - Press Ctrl+shift+l to launch authority search 4 - Perform a search and select an authority 5 - Note the field copies but the pop-ups don't close 6 - Apply patch 7 - Reload the page 8 - Repeat 1-4 9 - The field copies and the windows close Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27886 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27886 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27886 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 11299 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org