[Bug 26182] New: Clearly pair UpdateItemWhenLostFromHoldList and CanMarkHoldsToPullAsLost system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 Bug ID: 26182 Summary: Clearly pair UpdateItemWhenLostFromHoldList and CanMarkHoldsToPullAsLost system preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If you have CanMarkHoldsToPullAsLost turned on but don't have a value in UpdateItemWhenLostFromHoldList, the Holds to Pull list will give you a "Mark item as Lost" button, but the item will not be marked as lost. We should either pair these so that they always appear together in the same box or add a note to either syspref's description indicating that it requires the other to be set in order to function. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #1 from Donna <bwsdonna@gmail.com> --- I would suggest adding a note to the sys pref description. That seems to be the standard now, and I am always for more info in the descriptions! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Fuerste-Henry from comment #0)
If you have CanMarkHoldsToPullAsLost turned on but don't have a value in UpdateItemWhenLostFromHoldList, the Holds to Pull list will give you a "Mark item as Lost" button, but the item will not be marked as lost.
Reading the code I don't think it's what happens. If CanMarkHoldsToPullAsLost is on, the item will be mark as lost, however if you have something in UpdateItemWhenLostFromHoldList but CanMarkHoldsToPullAsLost is off, then UpdateItemWhenLostFromHoldList will not be applied. Can you confirm? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Here's what I see from playing with combinations of these two sysprefs on master: CanMarkHoldsToPullAsLost controls whether or not the "Mark item as lost" button shows on the Holds to Pull page. UpdateItemWhenLostFromHoldList controls what the button does. If CanMarkHoldsToPullAsLost is set to "Allow to mark items as lost" and UpdateItemWhenLostFromHoldList is empty, we get a "Mark item as lost" button, but clicking it just cancels the hold without making the item lost. If CanMarkHoldsToPullAsLost is set to "Do not allow to mark items as lost" and UpdateItemWhenLostFromHoldList has "itemlost: 1," we do not get a "Mark item as lost" button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 108179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108179&action=edit Bug 26182: Clarify wording on CanMarkHoldsToPullAsLost and UpdateItemWhenLostFromHoldList To test: - apply patch, restart - search sysprefs for CanMarkHoldsToPullAsLost - confirm both sysprefs come up in search and syspref descriptions refer to each other -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108179|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 108192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108192&action=edit Bug 26182: Clarify wording on CanMarkHoldsToPullAsLost and UpdateItemWhenLostFromHoldList To test: - apply patch, restart - search sysprefs for CanMarkHoldsToPullAsLost - confirm both sysprefs come up in search and syspref descriptions refer to each other Signed-off-by: Holly Cooper <holly.teresa.cooper@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 Holly <hc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hc@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108192|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108315&action=edit Bug 26182: Clarify wording on CanMarkHoldsToPullAsLost and UpdateItemWhenLostFromHoldList To test: - apply patch, restart - search sysprefs for CanMarkHoldsToPullAsLost - confirm both sysprefs come up in search and syspref descriptions refer to each other Signed-off-by: Holly Cooper <holly.teresa.cooper@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Who signed the| |This patch clarifies the patch off| |need to use the | |CanMarkHoldsToPullAsLost | |system preference when | |using the | |UpdateItemWhenLostFromHoldL | |ist system versa (and vis | |versa) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26182 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org