[Bug 26265] New: Makefile.PL is missing pos directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Bug ID: 26265 Summary: Makefile.PL is missing pos directory Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org I was trying to figure out why the POS functionality is giving us a 'not found' in our 20.05.00 installation. I noticed the directory is not listed in Makefile.PL, but I believe it needs to be. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- My coworker confirmed directory and .pl files are missing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108781&action=edit Bug 26265: Add pos directory to the Makefile This patch adds the /pos directory to the Makefile so that pos gets properly mapped at make and install time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108781|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108783&action=edit Bug 26265: Add pos directory to the Makefile This patch adds the /pos directory to the Makefile so that pos gets properly mapped at make and install time. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, I can't test the packaging step for this patch. We have a history of this problem with other newly added modules: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=e57b3a6c4d9bb631... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=99f3121ff874fdc3... (rotating collections) There Tomas noted that the patch should fix packages too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=07ba06a5af4ec9bf... (plugins) Also mentions it as a fix for packages. Wow, we were really bad at this ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sounds like one we should perhaps have a QA script test for... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- https://gitlab.com/koha-community/qa-test-tools/-/issues/36 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Or remove Makefile.PL ? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #9)
Or remove Makefile.PL ? :)
And do what instead? It appears to be used by any installation type we currently have. Can you please PQA? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108815&action=edit Bug 26265: Add test for missing directory in Makefile.PL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108816&action=edit Bug 26265: Add missing xt dir -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #7)
Sounds like one we should perhaps have a QA script test for...
No, it should be a Koha test IMO. I had a try but it does not pass, no idea why. The code is trivial! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We should exclude .git and docs as well. But why xt and patroncards are listed? They are present in the Makefile. I am missing something obvious (getting hit by Friday afternoon) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108816|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108819&action=edit Bug 26265: Add missing xt dir -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- grr.. I have no idea why the regex match fails for some of those cases.. it's really odd. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we have the simple patch pushed and fix the tests later? I believe the stables are pending release any moment now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Having a look -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #14)
We should exclude .git and docs as well. But why xt and patroncards are listed? They are present in the Makefile. I am missing something obvious (getting hit by Friday afternoon)
I was distracted by the slash in the directory path, but the real problem seems to be the g option of the regex which makes it match multiple times in iteration. Remove it and it works.. We should also add the bin directory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 108967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108967&action=edit Bug 26265: Remove g option from regex, add few dirs Adding .git, bin and docs Test plan: Run the test again Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- No, I realize that bin is something peculiar to my container setup.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108783|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 108968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108968&action=edit Bug 26265: Add pos directory to the Makefile This patch adds the /pos directory to the Makefile so that pos gets properly mapped at make and install time. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108815|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 108969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108969&action=edit Bug 26265: Add test for missing directory in Makefile.PL Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108819|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 108970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108970&action=edit Bug 26265: Add missing xt dir Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 108971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108971&action=edit Bug 26265: (QA follow-up) Remove g option from regex, add few dirs Adding .git. Using a regex. If we make it a bit smarter, we do not need most dirs listed. Test plan: Run the test again Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108967|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109071&action=edit Bug 26265: add a plan for tests Tests were run but no plan was declared and done_testing() was not seen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch pushed to master for 20.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #29 from Lucas Gass <lucas@bywatersolutions.com> --- The entire patchset has been backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26265 --- Comment #30 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org