[Bug 21082] New: OverDrive authentication method no longer supported
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Bug ID: 21082 Summary: OverDrive authentication method no longer supported Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When OverDrive circulation/integration was introduced it used the 'Granted authentication' API This API is no longer supported on OverDrive's new library sites, we need to switch to the 'Patron authentication' API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77053&action=edit Bug 21082: Database updates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77054&action=edit Bug 21082: Add new admin page for overdrive The 'authname' field required for OverDrive can differ per branch. This patch adds Koha Objects for dealing with OD info and submitting authnames per branch. The description is left open so future branch info can be added. To test: 1 - prove -v t/db_dependent/Koha/Library/OverDriveInfos.t 2 - visit cgi-bin/koha/admin/overdrive.pl 3 - Add some authnames for various branches 4 - Verify data saves correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77055&action=edit Bug 21082: DO NOT PUSH - Schema changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77056&action=edit Bug 21082: Update OverDrive authentication method Testing will require an OverDrive account, you should be able to obtain a developer account here: https://developer.overdrive.com/ You will need to register a SIP connection for patron authentication To test authentication: 1 - Set authname default in OD prefs 2 - Sign in as a patron whose branch matches authname 3 - Verify the patron can sign into OverDrive 4 - Set the patrons branch authname to be incorrect 5 - Verify branch specific authname is used and patron cannot sign in 6 - Set the default authname to be incorrect and patron's branch authname to be correct 7 - Verofy patron can sign in To test circulation: 1 - Fill out all OD prefs and enable circulation 2 - Sign in to opac 3 - Verify you have an OverDrive tab 4 - Click 'Login to Overdrive' 5 - If password required you shoudl be prompted, otherwise you should be signed in and see account info 6 - Test logging out and in 7 - Log-in, perform a search on the opac - you should see hold/checkout buttons 8 - Test the buttons 9 - After holding/checking out items, check your account page 10 - Verify info is correct 11 - Log out of overdrive 12 - Search catalog click overdrive results 13 - Test "Login to Overdrive" link on OD results 14 - Verify page is reloaded, buttons show and work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 77053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77053 Bug 21082: Database updates Review of attachment 77053: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21082&attachment=77053) ----------------------------------------------------------------- ::: installer/data/mysql/sysprefs.sql @@ +415,4 @@
('OverDriveClientKey','','Client key for OverDrive integration','30','Free'), ('OverDriveClientSecret','','Client key for OverDrive integration','30','YesNo'), ('OverDriveLibraryID','','Library ID for OverDrive integration','','Integer'), +('OverDrivePasswordRequired','',NULL,'Does the library require passwords for OverDrive SIP authentication','Free'),
Shouldn't 'Free' be 'YesNo'? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 77056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77056 Bug 21082: Update OverDrive authentication method Review of attachment 77056: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21082&attachment=77056) ----------------------------------------------------------------- ::: opac/svc/overdrive @@ +45,4 @@
eval { { $action eq 'login' && do { + my $password = $cgi->param("password") // "" ;
Not a real issue, but q{} is perlcritic friendlier. Even '' would be better than "". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nate@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77053|0 |1 is obsolete| | Attachment #77054|0 |1 is obsolete| | Attachment #77055|0 |1 is obsolete| | Attachment #77056|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79792&action=edit Bug 21082: Database updates https://bugs.koha-community.org/show_bug.cgi?id=2108 Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79793&action=edit Bug 21082: Add new admin page for overdrive The 'authname' field required for OverDrive can differ per branch. This patch adds Koha Objects for dealing with OD info and submitting authnames per branch. The description is left open so future branch info can be added. To test: 1 - prove -v t/db_dependent/Koha/Library/OverDriveInfos.t 2 - visit cgi-bin/koha/admin/overdrive.pl 3 - Add some authnames for various branches 4 - Verify data saves correctly https://bugs.koha-community.org/show_bug.cgi?id=2108 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79794&action=edit Bug 21082: Update OverDrive authentication method Testing will require an OverDrive account, you should be able to obtain a developer account here: https://developer.overdrive.com/ You will need to register a SIP connection for patron authentication To test authentication: 1 - Set authname default in OD prefs 2 - Sign in as a patron whose branch matches authname 3 - Verify the patron can sign into OverDrive 4 - Set the patrons branch authname to be incorrect 5 - Verify branch specific authname is used and patron cannot sign in 6 - Set the default authname to be incorrect and patron's branch authname to be correct 7 - Verofy patron can sign in To test circulation: 1 - Fill out all OD prefs and enable circulation 2 - Sign in to opac 3 - Verify you have an OverDrive tab 4 - Click 'Login to Overdrive' 5 - If password required you shoudl be prompted, otherwise you should be signed in and see account info 6 - Test logging out and in 7 - Log-in, perform a search on the opac - you should see hold/checkout buttons 8 - Test the buttons 9 - After holding/checking out items, check your account page 10 - Verify info is correct 11 - Log out of overdrive 12 - Search catalog click overdrive results 13 - Test "Login to Overdrive" link on OD results 14 - Verify page is reloaded, buttons show and work https://bugs.koha-community.org/show_bug.cgi?id=2108 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79795&action=edit Bug 21082: DO NOT PUSH - Schema updates https://bugs.koha-community.org/show_bug.cgi?id=2108 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79795|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79894&action=edit Bug 21082: DO NOT PUSH - Schema updates https://bugs.koha-community.org/show_bug.cgi?id=2108 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79792|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 79954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79954&action=edit Bug 21082: Database updates https://bugs.koha-community.org/show_bug.cgi?id=2108 Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79793|0 |1 is obsolete| | --- Comment #13 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 79955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79955&action=edit Bug 21082: Add new admin page for overdrive The 'authname' field required for OverDrive can differ per branch. This patch adds Koha Objects for dealing with OD info and submitting authnames per branch. The description is left open so future branch info can be added. To test: 1 - prove -v t/db_dependent/Koha/Library/OverDriveInfos.t 2 - visit cgi-bin/koha/admin/overdrive.pl 3 - Add some authnames for various branches 4 - Verify data saves correctly https://bugs.koha-community.org/show_bug.cgi?id=2108 Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79794|0 |1 is obsolete| | --- Comment #14 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 79956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79956&action=edit Bug 21082: Update OverDrive authentication method Testing will require an OverDrive account, you should be able to obtain a developer account here: https://developer.overdrive.com/ You will need to register a SIP connection for patron authentication To test authentication: 1 - Set authname default in OD prefs 2 - Sign in as a patron whose branch matches authname 3 - Verify the patron can sign into OverDrive 4 - Set the patrons branch authname to be incorrect 5 - Verify branch specific authname is used and patron cannot sign in 6 - Set the default authname to be incorrect and patron's branch authname to be correct 7 - Verofy patron can sign in To test circulation: 1 - Fill out all OD prefs and enable circulation 2 - Sign in to opac 3 - Verify you have an OverDrive tab 4 - Click 'Login to Overdrive' 5 - If password required you shoudl be prompted, otherwise you should be signed in and see account info 6 - Test logging out and in 7 - Log-in, perform a search on the opac - you should see hold/checkout buttons 8 - Test the buttons 9 - After holding/checking out items, check your account page 10 - Verify info is correct 11 - Log out of overdrive 12 - Search catalog click overdrive results 13 - Test "Login to Overdrive" link on OD results 14 - Verify page is reloaded, buttons show and work https://bugs.koha-community.org/show_bug.cgi?id=2108 Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79894|0 |1 is obsolete| | --- Comment #15 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 79957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79957&action=edit Bug 21082: DO NOT PUSH - Schema updates https://bugs.koha-community.org/show_bug.cgi?id=2108 Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79954|0 |1 is obsolete| | --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 79985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79985&action=edit Bug 21082: Database updates Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79955|0 |1 is obsolete| | --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 79986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79986&action=edit Bug 21082: Add new admin page for overdrive The 'authname' field required for OverDrive can differ per branch. This patch adds Koha Objects for dealing with OD info and submitting authnames per branch. The description is left open so future branch info can be added. To test: 1 - prove -v t/db_dependent/Koha/Library/OverDriveInfos.t 2 - visit cgi-bin/koha/admin/overdrive.pl 3 - Add some authnames for various branches 4 - Verify data saves correctly Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79956|0 |1 is obsolete| | --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 79987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79987&action=edit Bug 21082: Update OverDrive authentication method Testing will require an OverDrive account, you should be able to obtain a developer account here: https://developer.overdrive.com/ You will need to register a SIP connection for patron authentication To test authentication: 1 - Set authname default in OD prefs 2 - Sign in as a patron whose branch matches authname 3 - Verify the patron can sign into OverDrive 4 - Set the patrons branch authname to be incorrect 5 - Verify branch specific authname is used and patron cannot sign in 6 - Set the default authname to be incorrect and patron's branch authname to be correct 7 - Verofy patron can sign in To test circulation: 1 - Fill out all OD prefs and enable circulation 2 - Sign in to opac 3 - Verify you have an OverDrive tab 4 - Click 'Login to Overdrive' 5 - If password required you shoudl be prompted, otherwise you should be signed in and see account info 6 - Test logging out and in 7 - Log-in, perform a search on the opac - you should see hold/checkout buttons 8 - Test the buttons 9 - After holding/checking out items, check your account page 10 - Verify info is correct 11 - Log out of overdrive 12 - Search catalog click overdrive results 13 - Test "Login to Overdrive" link on OD results 14 - Verify page is reloaded, buttons show and work Signed-off-by: Sandy Allgood <sandy.allgood@citruslibraries.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21542 [Bug 21542] OverDrive password submission should use a password field to mask input -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #21 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I pass for 17.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22030 [Bug 22030] OverDrive requires 'username' to be cardnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21082 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34979 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org