[Bug 23916] New: Issuer should be recorded and visible in patron circulation history

bugzilla-daemon＠bugs.koha-community.org

29 Oct 2019 29 Oct '19

11:49 a.m.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Bug ID: 23916 Summary: Issuer should be recorded and visible in patron circulation history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Currently, when an item is issued, the issuer (member of staff, or self check or whatever) is not recorded directly with the issue. If the syspref is turned on then it is recorded in the associated action log. The issuer should be directly recorded with the issue (in a new "issues.issuer" column) and then displayed in the patron's circulation history. As part of the DB upgrade, an attempt should also be made to retrospectively populate issuers using any available action logs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

Show replies by date

bugzilla-daemon＠bugs.koha-community.org

29 Oct 29 Oct

11:49 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

bugzilla-daemon＠bugs.koha-community.org

9:25 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

bugzilla-daemon＠bugs.koha-community.org

30 Oct 30 Oct

10:50 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Katrin To me it seems that the correct place to record this is with the issue, storing an issue ID in the action logs feels a bit like a hack. We have been known to purge action_logs at a customer's request during an upgrade. This would mean that relationship between the issue and they issuer would then be lost. Storing the issuer with the issue will be forever! :) I'm not sure it raises any data privacy issues that do not equally apply to storing the borrower with the issue, which we already do, as well as in the action_logs. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:53 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Development note: The data being stored here (issuer) should also be made visible in a biblio's "Checkout history" page -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:39 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For the borrower-issue information we have a means of anonymizing via the GUI - so libraries can clean the data and it's not stored forever. The action_logs can also be cleaned by cronjob if the library chooses to. Cleaning/anonymizing statistics has been discussed in the GDPR meetings (https://wiki.koha-community.org/wiki/Gdpr) I think we should make it a general habit not to add more person related information, without thinking about how to limit/anonymize/remove it if required, keeping the principle of data minimization in mind. (GDPR etc.) Libraries here are rather critical about reading histories and the like already, so that's why I was asking for optional. :) I'd be really interested what the use case is. - Always good to learn about others needs/requirements. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:43 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- NZ is just going through privacy legislation rule, and will bring us much closer to the GDPR too, so I agree this should be optional (The library will need to assume responsibility for a data breach, and report it and be liable for damages etc, so it's a choice they should conciously make) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

31 Oct 31 Oct

9:24 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #6 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi both Thanks for the input. I can put it behind a syspref. I can also ensure that Koha::Patrons::anonymise_issue_history anonymises the 'issuer' column, in addition to 'borrowernumber'. Would this address the concerns? As far as a use case is concern, it's displaying the issuer, so staff can see an issue's issuer -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:39 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

...

As far as a use case is concern, it's displaying the issuer, so staff can see an issue's issuer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #13 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Test plan: --------- 1. Ensure the new "RecordIssuer" is turned off (the default) setting. 2. Issue an item to a patron 3. Check the patron's circulation history 4. TEST => Observe that the table does not contain a "Checked out by" column 5. Check the item's checkout history 6. TEST => Observe that the table does not contain a "Checked out by" column 7. Turn the "RecordIssuer" syspref on 8. Issue another item to the patron 9. Check the patron's circulation history 10. TEST => Observe that the table now contains an "Checked out by" column 11. TEST => Observe that the column contains the details of the issuing user with a link to their patron record ONLY for the issue for which the syspref was turned on 11. Check the item's checkout history 12. TEST => Observe that the table now contains an "Checked out by" column 13. TEST => Observe that the column contains the details of the issuing user with a link to their patron record ONLY for the issue for which the syspref was turned on -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 Nov 18 Nov

12:33 p.m.

22 Jan 22 Jan

1:25 p.m.

bugzilla-daemon＠bugs.koha-community.org

7 Feb 7 Feb

8 Feb 8 Feb

12:16 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Bug 23916 depends on bug 24321, which changed state. Bug 24321 Summary: Make objects.search use mappings from Koha::Object(s) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 Mar 2 Mar

6 Aug 6 Aug

2:27 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #41 from Nick Clemens <nick@bywatersolutions.com> --- Tests need rebase, I got some fails If this relies on a syspref then the update should not attempt to convert action_logs to the issuer column - please make this a script that libraries can optionally run, or leave it out. When anonymising checkouts that have no issuer we convert NULL to the anonymous borrowernumber - I believe we should exclude these and preserve the NULL -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

19 Aug 19 Aug

10:03 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

24 Sep 24 Sep

1:52 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #42 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Nick Clemens from comment #41) Hi Nick

...

Tests need rebase, I got some fails

I can't replicate this: kohadev-koha@kohadevbox:/kohadevbox/koha$ ../qa-test-tools/koha-qa.pl -c 6 testing 6 commit(s) (applied to 3d06cbb '5a Bug 19889: (follow-up) update DB a') Processing files before patches |========================>| 11 / 11 (100.00%) Processing files after patches |========================>| 11 / 11 (100.00%) OK C4/Circulation.pm OK C4/Members.pm OK Koha/Checkout.pm OK Koha/Patrons.pm OK installer/data/mysql/kohastructure.sql OK installer/data/mysql/sysprefs.sql OK koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt OK t/db_dependent/Circulation.t OK t/db_dependent/Koha/Checkouts.t OK t/db_dependent/Koha/Patrons.t Processing additional checks OK!

...

If this relies on a syspref then the update should not attempt to convert action_logs to the issuer column - please make this a script that libraries can optionally run, or leave it out.

Good point. The retrospective migration of old issues into action_logs wasn't ideal as there are definitely cases where it could give erroneous results. I'm going to drop it.

...

When anonymising checkouts that have no issuer we convert NULL to the anonymous borrowernumber - I believe we should exclude these and preserve the NULL

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

bugzilla-daemon＠bugs.koha-community.org

2:11 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #49 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 110655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110655&action=edit Bug 23916: (follow-up) Implement feedback This commit implements the two suggestions made by Nick in comment #41: - Removes the attempted retrospective addition of issuers to old issues. It was not particularly reliable, it also is not appropriate if the user does not wish to make use of this functionality - Removes the conversion of a NULL issuer to the anonymous borrowernumber when anonymising checkouts -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:11 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

bugzilla-daemon＠bugs.koha-community.org

11 Oct 11 Oct

12:55 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Trying to give this one a go. 1) Terminology issue is not supposed to be used according to our terminology list. We prefer checkout. But... I am not sure what the better term for the person doing the checkout would be here. In some other cases we have used "manager" (accountlines). But if we wanted to record the person doing the checkin at some point, this won't work. For the pref... RecordStaffUserOnCheckout or similar could work. Overall not an easy one. I'll only be asking for changes in the GUI. + - "When issuing an item, " + - pref: RecordIssuer + choices: + yes: "record" + no: "don't record" + - "the user who issued the item." Please change to "staff user" and "issu*" to "check* out". Everywhere else looks good. 2) Database update and installer don't match up for old_issues.issuer we have default null in kohastructure.sql, but not in the database update. Maybe this has been discussed, but why not default null on issues.issuer? On first glance it would make sense for me as we will also use NULL on all the old entries. 3) Name display + <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% checkout.issuer | uri %]"> + [% checkout.issued_by.firstname | html %] [% checkout.issued_by.surname | html %] I think we should use patron-title.inc here if possible. 4) Tests fail :( I've run the database update and dbic manually, but the tests are failing: Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 65280 Tests: 51 Failed: 1) Failed test: 51 Non-zero exit status: 255 t/db_dependent/Koha/Checkouts.t (Wstat: 65280 Tests: 7 Failed: 1) Failed test: 7 Non-zero exit status: 255 Parse errors: Bad plan. You planned 8 tests but ran 7. t/db_dependent/Koha/Patrons.t (Wstat: 512 Tests: 28 Failed: 1) Failed test: 28 Non-zero exit status: 2 Parse errors: Bad plan. You planned 41 tests but ran 28. # Subtest: issuer 1..3 ok 1 - Koha::Checkout->issued_by should return a Koha::Patron ok 2 - Koha::Checkout->issued_by should return the correct patron # Looks like you planned 3 tests but ran 2. not ok 7 - issuer

...

From the verbose output:

# Failed test 'issuer' # at t/db_dependent/Koha/Checkouts.t line 152. Can't call method "issuer" on an undefined value at t/db_dependent/Koha/Checkouts.t line 148. # Looks like your test exited with 255 just after 7. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/8 subtests item-level_itypes set but no itemtype set for item (1508) at /home/vagrant/kohaclone/Koha/Schema/Result/Item.pm line 789. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`items`, CONSTRAINT `items_ibfk_3` FOREIGN KEY (`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) [for Statement "UPDATE `items` SET `datelastborrowed` = ?, `holdingbranch` = ?, `issues` = ?, `onloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0='2020-10-02', 1="Branch4T", 2=1, 3='2020-10-01', 4=1508] at /home/vagrant/kohaclone/Koha/Object.pm line 166 # No tests run! not ok 28 - No tests run for subtest "get_overdues" # Failed test 'No tests run for subtest "get_overdues"' # at t/db_dependent/Koha/Patrons.t line 1454. Broken FK constraint# Looks like your test exited with 2 just after 28. Dubious, test returned 2 (wstat 512, 0x200) Failed 14/41 subtests I hope I didn't mess up the rebase, so not attaching my patches here (had fixed a conflict in one of the test files). -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12 Oct 12 Oct

bugzilla-daemon＠bugs.koha-community.org

10:40 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

...

1) Terminology

issue is not supposed to be used according to our terminology list. We prefer checkout. But... I am not sure what the better term for the person doing the checkout would be here. In some other cases we have used "manager" (accountlines). But if we wanted to record the person doing the checkin at some point, this won't work. For the pref... RecordStaffUserOnCheckout or similar could work. Overall not an easy one.

I'll only be asking for changes in the GUI.

+ - "When issuing an item, " + - pref: RecordIssuer + choices: + yes: "record" + no: "don't record" + - "the user who issued the item."

Please change to "staff user" and "issu*" to "check* out".

Everywhere else looks good.

Fixed, I've changed the syspref name as you suggested, I've also changed "issuer" to "staff who checked out the item" and "issue" to "check out"

...

2) Database update and installer don't match up

for old_issues.issuer we have default null in kohastructure.sql, but not in the database update.

Maybe this has been discussed, but why not default null on issues.issuer? On first glance it would make sense for me as we will also use NULL on all the old entries.

Fixed, it is now DEFAULT NULL for both kohastructure.sql and the update, for both issues and old_issues

...

3) Name display

+ <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% checkout.issuer | uri %]"> + [% checkout.issued_by.firstname | html %] [% checkout.issued_by.surname | html %]

I think we should use patron-title.inc here if possible.

Fixed

...

4) Tests fail :(

I've run the database update and dbic manually, but the tests are failing:

I can't replicate this (see below)

...

I hope I didn't mess up the rebase, so not attaching my patches here (had fixed a conflict in one of the test files).

You shouldn't need to rebase, the patches apply cleanly on top of master for me. Maybe try again? kohadev-koha@kohadevbox:/kohadevbox/koha$ ../qa-test-tools/koha-qa.pl -c 8 -v 2 testing 8 commit(s) (applied to 20022fa '21 Bug 22417: Add exec flag on .t fil') Processing files before patches |========================>| 11 / 11 (100.00%) Processing files after patches |========================>| 11 / 11 (100.00%) OK C4/Circulation.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid OK C4/Members.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid OK Koha/Checkout.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid OK Koha/Patrons.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid OK installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation OK tinyint_has_boolean_flag OK installer/data/mysql/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order OK koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template OK t/db_dependent/Circulation.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid OK t/db_dependent/Koha/Checkouts.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid OK t/db_dependent/Koha/Patrons.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:44 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, I will have another look as soon as I can, but to avoid misunderstandings, I didn't mean the QA tests, but the unit tests. And I did have a conflict on master, but other things pushed meanwhile might have changed things again :) Do the unit tests all pass for you? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:57 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #61 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #60)

...

Do the unit tests all pass for you? Yes:

kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t [...] All tests successful. Files=91, Tests=4075, 2515 wallclock secs ( 1.47 usr 0.33 sys + 2415.95 cusr 41.02 csys = 2458.77 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Oct 16 Oct

11:33 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a conflict in the unit test file I am not sure about - probably not too bad, but more than fixing the number of tests, so I'd like not to mess with it: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23916: Add issues.issuer column and FK Applying: Bug 23916: Add "RecordIssuer" syspref Using index info to reconstruct a base tree... A installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql Applying: Bug 23916: Record and display item issuer Applying: Bug 23916: Anonymise 'issuer' when required Applying: Bug 23916: Add unit tests Using index info to reconstruct a base tree... M t/db_dependent/Circulation.t M t/db_dependent/Koha/Patrons.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Patrons.t Auto-merging t/db_dependent/Circulation.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t error: Failed to merge in the changes. Patch failed at 0001 Bug 23916: Add unit tests The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23916-Add-unit-tests-yabswJ.patch -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

19 Oct 19 Oct

1:41 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #71 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111974&action=edit Bug 23916: (follow-up) Respond to feedback This commit is a response to Katrin's comments in comment #62: - Fixed merge conflict It also fixes a test which now fails due to an upstream change in C4::Circulation -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:43 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #72 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Katrin - thanks for that. I've fixed that, I also fixed a test that was now failing due to a change in C4::Circulation Revised test plan: ----------------- 1. Ensure the new "RecordStaffUserOnCheckout" is turned off (the default) setting. 2. Issue an item to a patron 3. Check the patron's circulation history 4. TEST => Observe that the table does not contain a "Checked out by" column 5. Check the item's checkout history 6. TEST => Observe that the table does not contain a "Checked out by" column 7. Turn the "RecordIssuer" syspref on 8. Issue another item to the patron 9. Check the patron's circulation history 10. TEST => Observe that the table now contains an "Checked out by" column 11. TEST => Observe that the column contains the details of the issuing user with a link to their patron record ONLY for the issue for which the syspref was turned on 11. Check the item's checkout history 12. TEST => Observe that the table now contains an "Checked out by" column 13. TEST => Observe that the column contains the details of the issuing user with a link to their patron record ONLY for the issue for which the syspref was turned on -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Oct 23 Oct

1:20 a.m.

12:23 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

bugzilla-daemon＠bugs.koha-community.org

24 Oct 24 Oct

5 Nov 5 Nov

bugzilla-daemon＠bugs.koha-community.org

9:06 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

bugzilla-daemon＠bugs.koha-community.org

9:06 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

bugzilla-daemon＠bugs.koha-community.org

9 Nov 9 Nov

3:21 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

bugzilla-daemon＠bugs.koha-community.org

3:32 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

bugzilla-daemon＠bugs.koha-community.org

3:35 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #123 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113327&action=edit Bug 23916: (follow-up) Add unit tests Fix perlcritic error Subroutine "new" called using indirect syntax at line 128, column 14. See page 349 of PBP. (Severity: 4) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:38 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #124 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #122)

...

We need to adapt the REST API routes to deal with this new value.

Yeah, can we also rename the column? issuer_id? I can provide the follow-up if it helps. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:25 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #125 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also the method Koha::Patron->issued_by, should be ->issuer I think -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:26 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #126 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also the method is Koha::Checkout->issued_by, should be ->issuer I think -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:26 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #127 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #126)

...

Also the method is Koha::Checkout->issued_by, should be ->issuer I think

I'll take care -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

1:25 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #145 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tomas, About: + $issue->discard_changes; Did you encounter a specific problem? This change may be moved on a separate bug report to make it backportable (or just create a separate one for stables). Can you confirm? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:46 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #146 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113396&action=edit Bug 23916: (follow-up) Adapt all the things to the new column and accessor names -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

bugzilla-daemon＠bugs.koha-community.org

2 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #147 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12 Nov 12 Nov

4:03 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

bugzilla-daemon＠bugs.koha-community.org

4:11 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

bugzilla-daemon＠bugs.koha-community.org

16 Nov 16 Nov

10:30 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #148 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

22 Nov 22 Nov

12:36 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

bugzilla-daemon＠bugs.koha-community.org

13 Aug 13 Aug

11:30 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27279 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:21 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28858 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:31 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28859 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Aug 16 Aug

11:48 a.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28859 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28859 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 [Bug 28859] Table Settings should control Checked out by field in Checkout history -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Aug 23 Aug

2:27 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28891 [Bug 28891] RecordStaffUserOnCheckout display a new column but default sort column isn't changed. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

28 Aug 28 Aug

2:34 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28916 [Bug 28916] RecordStaffUserOnCheckout breaks table configuration of last column in checkout histories -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Sep 16 Sep

6:14 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27279 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 [Bug 27279] "Checked out by" not populated on issuehistory.pl -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4 Oct 4 Oct

2:27 p.m.

New subject: [Bug 23916] Issuer should be recorded and visible in patron circulation history

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34979 -- You are receiving this mail because: You are watching all bug changes.

1015

Age (days ago)

2451

Last active (days ago)

List overview

Download

182 comments

1 participants

participants (1)

bugzilla-daemon＠bugs.koha-community.org