[Bug 28956] New: Acquisitions: select correct default tax rate when receiving orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 Bug ID: 28956 Summary: Acquisitions: select correct default tax rate when receiving orders Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: wainuiwitikapark@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org When there is more than one tax rate defined in system preferences, and a vendor has a tax rate that is not 0%, then when you are receiving an order in a basket for that vendor, the default tax rate should be the correct non 0 rate. This should be seen in acqui/orderreceive. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |wainuiwitikapark@catalyst.n |ity.org |et.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 --- Comment #1 from wainuiwitikapark@catalyst.net.nz --- Created attachment 124567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124567&action=edit Bug 28956: correct default tax rate on orderreceive When there is more than one tax rate defined in system preferences, and a vendor has a tax rate that is not 0%, then when you are receiving an order in a basket for that vendor, the default tax rate should be the correct non 0 rate. This should be seen in acqui/orderreceive. To test: 1) Go to staff client 2) Go to Koha administration 3) Search for "tax rate" in system preferences 4) Add 0|0.15 into the preference 5) Create a vendor 6) Set vendor tax rate to 15% 7) Add a new basket to vendor 8) Add to basket 9) Add any sample order to basket - add actual cost 10) Close basket 11) Receive shipment 12) Make invoice 13) Click on Receive in the table 14) Should be on orderreceive.pl page 15) Observe tax rate default is 0% 16) Apply patch 17) Refresh page 18) Observe tax rate default is 15% Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 Julien Sicot (Univ. Rennes 2) <julien.sicot@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julien.sicot@univ-rennes2.f | |r --- Comment #2 from Julien Sicot (Univ. Rennes 2) <julien.sicot@univ-rennes2.fr> --- Hello, Thank you for this patch, I tested it (master and 20.11.x) and it applies well and fixes the issue. Many thanks :) Julien Sicot Systems Librarian Université Rennes 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 --- Comment #3 from wainuiwitikapark@catalyst.net.nz --- Hi Julien, Thank you very much, that's great to hear! Thanks, Wainui -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124567|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126017&action=edit Bug 28956: correct default tax rate on orderreceive When there is more than one tax rate defined in system preferences, and a vendor has a tax rate that is not 0%, then when you are receiving an order in a basket for that vendor, the default tax rate should be the correct non 0 rate. This should be seen in acqui/orderreceive. To test: 1) Go to staff client 2) Go to Koha administration 3) Search for "tax rate" in system preferences 4) Add 0|0.15 into the preference 5) Create a vendor 6) Set vendor tax rate to 15% 7) Add a new basket to vendor 8) Add to basket 9) Add any sample order to basket - add actual cost 10) Close basket 11) Receive shipment 12) Make invoice 13) Click on Receive in the table 14) Should be on orderreceive.pl page 15) Observe tax rate default is 0% 16) Apply patch 17) Refresh page 18) Observe tax rate default is 15% Sponsored-by: Catalyst IT Signed-off-by: Julien Sicot <julien.sicot@univ-rennes2.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Julien, I hope it's ok, I added your sign-off line as: Signed-off-by: Julien Sicot <julien.sicot@univ-rennes2.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28956 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org