[Bug 24698] New: UNIMARC authorities leader plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Bug ID: 24698 Summary: UNIMARC authorities leader plugin Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: vitorfernandes87@gmail.com QA Contact: testopia@bugs.koha-community.org The leader for authority record is different than for bibliographic record. We need a plugin for UNIMARC Authorities leader. Page 27 - https://www.ifla.org/files/assets/uca/unimarc-authorities-format.pdf -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |gveranis@dataly.gr |ity.org | Status|NEW |ASSIGNED CC| |gveranis@dataly.gr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #1 from George Veranis <gveranis@dataly.gr> --- Created attachment 118186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118186&action=edit Bug 24698: Add plugin and template files for unimarc authority leader In Unimarc installations when adding/editing an authority record there is no Tag Editor for the leader field ( 000 ). This patch fixes that. Test plan: 1) Try to catalogue a new authoritry and check if on field 000 you can find the Tag Editor. 2) Apply the patch. 3) In the authorities framework view the subfields of field 000 and select for plugin option the value unimarc_leader_authorities.pl. 4) Restart memcached / plack if needed. 5) Repeat step 1 and notice if the Tag Editor is visible and click it to open new window in order to manage the field contents and press OK. 6) Check the value of the generated leader. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118186|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 124437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124437&action=edit Bug 24698: Add plugin and template files for unimarc authority leader In Unimarc installations when adding/editing an authority record there is no Tag Editor for the leader field ( 000 ). This patch fixes that. Test plan: 1) Try to catalogue a new authoritry and check if on field 000 you can find the Tag Editor. 2) Apply the patch. 3) In the authorities framework view the subfields of field 000 and select for plugin option the value unimarc_leader_authorities.pl. 4) Restart memcached / plack if needed. 5) Repeat step 1 and notice if the Tag Editor is visible and click it to open new window in order to manage the field contents and press OK. 6) Check the value of the generated leader. Signed-off-by: Esther <estherm@sodapsringsid.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Esther Melander <estherm@sodaspringsid.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |estherm@sodaspringsid.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124437|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125669&action=edit Bug 24698: Add plugin and template files for unimarc authority leader In Unimarc installations when adding/editing an authority record there is no Tag Editor for the leader field ( 000 ). This patch fixes that. Test plan: 1) Try to catalogue a new authoritry and check if on field 000 you can find the Tag Editor. 2) Apply the patch. 3) In the authorities framework view the subfields of field 000 and select for plugin option the value unimarc_leader_authorities.pl. 4) Restart memcached / plack if needed. 5) Repeat step 1 and notice if the Tag Editor is visible and click it to open new window in order to manage the field contents and press OK. 6) Check the value of the generated leader. Signed-off-by: Esther <estherm@sodapsringsid.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #4 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125670&action=edit Bug 24698: (QA follow-up) Fix errors caused by more strict exports being introduced The original patch "Bug 24698: Add plugin and template files for unimarc authority leader" doesn't work without explictly importing the methods from C4::Auth and C4::Output due to the default exports being changed in those modules after the patch was made. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #5 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125671&action=edit Bug 24698: (QA follow-up) Remove debug info being outputted to the template This is only needed during development. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #6 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125672&action=edit Bug 24698: (QA follow-up) Align variables with whitespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #7 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125673&action=edit Bug 24698: (QA follow-up) Remove dead code These were left off from the copy&paste taken from unimarc_field_100_authorities.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #8 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125674&action=edit Bug 24698: (QA follow-up) Fix formatting and typos -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #9 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125675&action=edit Bug 24698: (QA follow-up) Remove passing of authnotrequired parameter It should only be used when we want to override the default of auth being required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #10 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125676&action=edit Bug 24698: (QA follow-up) Make plugin script executable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #11 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125677&action=edit Bug 24698: (QA follow-up) Use spaces instead of tabs This makes the QA script happy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #12 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125678&action=edit Bug 24698: (QA follow-up) Filter untrusted input to prevent XSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #13 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125679&action=edit Bug 24698: (QA follow-up) Don't specify select element's size if it is 1 This is to make the QA script happy, in order to not to break Bootstrap CSS rules, see Bug 28066 for more info -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #14 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125680&action=edit Bug 24698: (QA follow-up) Don't specify script type explictly It's makes the QA script complain because the option doesn't have any effect nowadays: https://www.w3.org/TR/2017/REC-html52-20171214/obsolete.html#warnings-for-ob... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | CC| |joonas.kylmala@iki.fi --- Comment #15 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Don't mind the follow-ups ;D I'm willing to Pass QA after checking one thing that is unclear to me: The spec from that ifla.org website only defines as possible values for "9 Type of entity" the letters a-l but here this adds the option for "Series" with an blank value (space). Is this supposed to be allowed? Where is it mentioned as being a possible value? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #16 from George Veranis <gveranis@dataly.gr> --- No it is not allowed base ifla instructions you are right. I forgot to delete it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to George Veranis from comment #16)
No it is not allowed base ifla instructions you are right. I forgot to delete it.
Could you please send a follow-up for that and sign-off the ones I did? (even though they are pretty trivial – but many in count). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125670|0 |1 is obsolete| | --- Comment #18 from George Veranis <gveranis@dataly.gr> --- Created attachment 125929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125929&action=edit Bug 24698: (QA follow-up) Fix errors caused by more strict exports being introduced The original patch "Bug 24698: Add plugin and template files for unimarc authority leader" doesn't work without explictly importing the methods from C4::Auth and C4::Output due to the default exports being changed in those modules after the patch was made. Signed-off-by: George Veranis <gveranis@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125671|0 |1 is obsolete| | --- Comment #19 from George Veranis <gveranis@dataly.gr> --- Created attachment 125930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125930&action=edit Bug 24698: (QA follow-up) Remove debug info being outputted to the template This is only needed during development. Signed-off-by: George Veranis <gveranis@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125672|0 |1 is obsolete| | --- Comment #20 from George Veranis <gveranis@dataly.gr> --- Created attachment 125931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125931&action=edit Bug 24698: (QA follow-up) Align variables with whitespace Signed-off-by: George Veranis <gveranis@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125673|0 |1 is obsolete| | --- Comment #21 from George Veranis <gveranis@dataly.gr> --- Created attachment 125932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125932&action=edit Bug 24698: (QA follow-up) Remove dead code These were left off from the copy&paste taken from unimarc_field_100_authorities.pl Signed-off-by: George Veranis <gveranis@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125674|0 |1 is obsolete| | --- Comment #22 from George Veranis <gveranis@dataly.gr> --- Created attachment 125933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125933&action=edit Bug 24698: (QA follow-up) Fix formatting and typos Signed-off-by: George Veranis <gveranis@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125675|0 |1 is obsolete| | --- Comment #23 from George Veranis <gveranis@dataly.gr> --- Created attachment 125934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125934&action=edit Bug 24698: (QA follow-up) Remove passing of authnotrequired parameter It should only be used when we want to override the default of auth being required. Signed-off-by: George Veranis <gveranis@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125676|0 |1 is obsolete| | --- Comment #24 from George Veranis <gveranis@dataly.gr> --- Created attachment 125935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125935&action=edit Bug 24698: (QA follow-up) Make plugin script executable Signed-off-by: George Veranis <gveranis@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125677|0 |1 is obsolete| | --- Comment #25 from George Veranis <gveranis@dataly.gr> --- Created attachment 125936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125936&action=edit Bug 24698: (QA follow-up) Use spaces instead of tabs This makes the QA script happy. Signed-off-by: George Veranis <gveranis@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125678|0 |1 is obsolete| | --- Comment #26 from George Veranis <gveranis@dataly.gr> --- Created attachment 125937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125937&action=edit Bug 24698: (QA follow-up) Filter untrusted input to prevent XSS Signed-off-by: George Veranis <gveranis@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125679|0 |1 is obsolete| | --- Comment #27 from George Veranis <gveranis@dataly.gr> --- Created attachment 125938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125938&action=edit Bug 24698: (QA follow-up) Don't specify select element's size if it is 1 This is to make the QA script happy, in order to not to break Bootstrap CSS rules, see Bug 28066 for more info Signed-off-by: George Veranis <gveranis@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125680|0 |1 is obsolete| | --- Comment #28 from George Veranis <gveranis@dataly.gr> --- Created attachment 125939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125939&action=edit Bug 24698: (QA follow-up) Don't specify script type explictly It's makes the QA script complain because the option doesn't have any effect nowadays: https://www.w3.org/TR/2017/REC-html52-20171214/obsolete.html#warnings-for-ob... Signed-off-by: George Veranis <gveranis@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #29 from George Veranis <gveranis@dataly.gr> --- Created attachment 125940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125940&action=edit Bug 24698: (follow-up) remove HTML select option for Series The IFLA authorities format specification defines only the letters a-l as possible values for authority leader 000 character position 9 ("Type of entity"). Therefore, the first option from the HTML select dropdown menu (" - Series") must be removed. Mentored-by: Andreas Roussos <a.roussos@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #30 from George Veranis <gveranis@dataly.gr> --- (In reply to Joonas Kylmälä from comment #17)
(In reply to George Veranis from comment #16)
No it is not allowed base ifla instructions you are right. I forgot to delete it.
Could you please send a follow-up for that and sign-off the ones I did? (even though they are pretty trivial – but many in count).
Hi Joonas, I did what you asked for , please check-it and tell me if you need something more . Thanks for your QA ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125669|0 |1 is obsolete| | Attachment #125929|0 |1 is obsolete| | Attachment #125930|0 |1 is obsolete| | Attachment #125931|0 |1 is obsolete| | Attachment #125932|0 |1 is obsolete| | Attachment #125933|0 |1 is obsolete| | Attachment #125934|0 |1 is obsolete| | Attachment #125935|0 |1 is obsolete| | Attachment #125936|0 |1 is obsolete| | Attachment #125937|0 |1 is obsolete| | Attachment #125938|0 |1 is obsolete| | Attachment #125939|0 |1 is obsolete| | Attachment #125940|0 |1 is obsolete| | --- Comment #31 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125998&action=edit Bug 24698: Add plugin and template files for unimarc authority leader In Unimarc installations when adding/editing an authority record there is no Tag Editor for the leader field ( 000 ). This patch fixes that. Test plan: 1) Try to catalogue a new authoritry and check if on field 000 you can find the Tag Editor. 2) Apply the patch. 3) In the authorities framework view the subfields of field 000 and select for plugin option the value unimarc_leader_authorities.pl. 4) Restart memcached / plack if needed. 5) Repeat step 1 and notice if the Tag Editor is visible and click it to open new window in order to manage the field contents and press OK. 6) Check the value of the generated leader. Signed-off-by: Esther <estherm@sodapsringsid.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #32 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125999&action=edit Bug 24698: (QA follow-up) Fix errors caused by more strict exports being introduced The original patch "Bug 24698: Add plugin and template files for unimarc authority leader" doesn't work without explictly importing the methods from C4::Auth and C4::Output due to the default exports being changed in those modules after the patch was made. Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #33 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 126000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126000&action=edit Bug 24698: (QA follow-up) Remove debug info being outputted to the template This is only needed during development. Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #34 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 126001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126001&action=edit Bug 24698: (QA follow-up) Align variables with whitespace Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #35 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 126002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126002&action=edit Bug 24698: (QA follow-up) Remove dead code These were left off from the copy&paste taken from unimarc_field_100_authorities.pl Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #36 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 126003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126003&action=edit Bug 24698: (QA follow-up) Fix formatting and typos Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #37 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 126004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126004&action=edit Bug 24698: (QA follow-up) Remove passing of authnotrequired parameter It should only be used when we want to override the default of auth being required. Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #38 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 126005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126005&action=edit Bug 24698: (QA follow-up) Make plugin script executable Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #39 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 126006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126006&action=edit Bug 24698: (QA follow-up) Use spaces instead of tabs This makes the QA script happy. Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #40 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 126007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126007&action=edit Bug 24698: (QA follow-up) Filter untrusted input to prevent XSS Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #41 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 126008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126008&action=edit Bug 24698: (QA follow-up) Don't specify select element's size if it is 1 This is to make the QA script happy, in order to not to break Bootstrap CSS rules, see Bug 28066 for more info Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #42 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 126009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126009&action=edit Bug 24698: (QA follow-up) Don't specify script type explictly It's makes the QA script complain because the option doesn't have any effect nowadays: https://www.w3.org/TR/2017/REC-html52-20171214/obsolete.html#warnings-for-ob... Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #43 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 126010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126010&action=edit Bug 24698: (follow-up) remove HTML select option for Series The IFLA authorities format specification defines only the letters a-l as possible values for authority leader 000 character position 9 ("Type of entity"). Therefore, the first option from the HTML select dropdown menu (" - Series") must be removed. Mentored-by: Andreas Roussos <a.roussos@dataly.gr> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #44 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to George Veranis from comment #30)
Hi Joonas, I did what you asked for , please check-it and tell me if you need something more . Thanks for your QA !
Looks good now. Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Follow-up patches will be squashed when pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #48 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #49 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org