[Bug 9905] New: Use DataTables on calendar page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9905 Bug ID: 9905 Summary: Use DataTables on calendar page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/holidays.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The calendar tool uses the old tablesorter plugin to sort tables of existing calendar entries. It should use DataTables instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9905 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9887 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9905 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9905 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16817&action=edit Bug 9905 - Use DataTables on calendar page The calendar management page uses the old tablesorter plugin. This patch replaces tablesorter code with DataTables. In order to easily sort date columns under various dateformat system preference settings, date columns now sort based on an unformatted date in a <span>'s title attribute (requiring the patch for Bug 9887). To test, view the calendar page--preferably with plenty of existing holiday data to populate the holiday summary tables. Confirm that sorting works correctly on all sorted tables with the dateformat preference set in all settings. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9905 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9905 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16817|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17224&action=edit Bug 9905 - Use DataTables on calendar page The calendar management page uses the old tablesorter plugin. This patch replaces tablesorter code with DataTables. In order to easily sort date columns under various dateformat system preference settings, date columns now sort based on an unformatted date in a <span>'s title attribute (requiring the patch for Bug 9887). To test, view the calendar page--preferably with plenty of existing holiday data to populate the holiday summary tables. Confirm that sorting works correctly on all sorted tables with the dateformat preference set in all settings. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9905 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17268&action=edit screenshot showing missing calendar and holidays I found 2 problems with this patch: 1) The calendar for my logged in library does not appar, but when I switch to another library the display is ok. 2) The Day/Month column in the 'Yearly - Repeatable Holidays' doesn't sort, but gives a JavaScript error. Owen, could you check what's going wrong there? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9905 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9905 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Returning to "signed off" for more testing. Be sure to have 9887 applied first. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9905 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17320&action=edit [PASSED QA] Bug 9905 - Use DataTables on calendar page The calendar management page uses the old tablesorter plugin. This patch replaces tablesorter code with DataTables. In order to easily sort date columns under various dateformat system preference settings, date columns now sort based on an unformatted date in a <span>'s title attribute (requiring the patch for Bug 9887). To test, view the calendar page--preferably with plenty of existing holiday data to populate the holiday summary tables. Confirm that sorting works correctly on all sorted tables with the dateformat preference set in all settings. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Note: This has to be tested together with the patch for bug 9887. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9905 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9905 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17224|0 |1 is obsolete| | Attachment #17320|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17321&action=edit [PASSED QA] Bug 9905 - Use DataTables on calendar page The calendar management page uses the old tablesorter plugin. This patch replaces tablesorter code with DataTables. In order to easily sort date columns under various dateformat system preference settings, date columns now sort based on an unformatted date in a <span>'s title attribute (requiring the patch for Bug 9887). To test, view the calendar page--preferably with plenty of existing holiday data to populate the holiday summary tables. Confirm that sorting works correctly on all sorted tables with the dateformat preference set in all settings. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Note: This has to be tested together with the patch for bug 9887. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9905 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org