[Bug 9463] New: Use DataTables on patron sent notices page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Bug ID: 9463 Summary: Use DataTables on patron sent notices page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/notices.pl?borrowernumber=X OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The patron sent notices page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14796&action=edit Bug 9463 - Use DataTables on patron sent notices page Replace the tablesorter plugin with the DataTables plugin on the patron sent notices page. This patch adds default sorting by time (descending). To test, open the sent notices page for a patron who has multiple sent notices. Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14796|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14810&action=edit Bug 9463 - Use DataTables on patron sent notices page Replace the tablesorter plugin with the DataTables plugin on the patron sent notices page. This patch adds default sorting by time (descending). To test, open the sent notices page for a patron who has multiple sent notices. Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- I found an issue (not introduced with your patch) : the time column is not displayed in the syspref format. I opened a new bug 9479 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14810|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14886&action=edit Bug 9463 - Use DataTables on patron sent notices page Replace the tablesorter plugin with the DataTables plugin on the patron sent notices page. This patch adds default sorting by time (descending). To test, open the sent notices page for a patron who has multiple sent notices. Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de Patch complexity|--- |Small patch --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch no longer applies - please rebase and switch back to signed off if the conflict is easy to resolve. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14886|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15686&action=edit Bug 9463 - Use DataTables on patron sent notices page Replace the tablesorter plugin with the DataTables plugin on the patron sent notices page. This patch adds default sorting by time (descending). To test, open the sent notices page for a patron who has multiple sent notices. Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17081&action=edit screenshot Hi Owen, a recent patch fixed date sorting on this page and I think this patch breaks it again (see screenshot). Sorting on master is correct, sorting with patch is not. Can you take a look please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9887 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15686|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17100&action=edit Bug 9463 [Revised] Use DataTables on patron sent notices page Replace the tablesorter plugin with the DataTables plugin on the patron sent notices page. This patch adds default sorting by time (descending). This patch depends on the one for Bug 9887, which introduces a new DataTables plugin to allow sorting on data embedded in a <span>'s "title" attribute. This allows sorting to be done on an unformatted datetime. To test, open the sent notices page for a patron who has multiple sent notices. Confirm that table sorting works correctly with various date format settings. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17111&action=edit Bug 9463: FIX DT sort by date for the last column -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Owen, I got a js error with your patch: TypeError: y[(("string" + "-") + m[Q][1])] is not a function I fix it with 3 simple changes, I use uk_date for the Time column and it seems to be well sorted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Jonathan did you apply the patch for Bug 9887 first? I don't mind solving this sort with the uk_date routine, but I've found the title attribute sort to be really easy to implement, especially on pages where a lot of logic is going into displaying columns or not. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #11)
Jonathan did you apply the patch for Bug 9887 first? I don't mind solving this sort with the uk_date routine, but I've found the title attribute sort to be really easy to implement, especially on pages where a lot of logic is going into displaying columns or not.
No, I forgot to apply the patch for bug 9887! And now it works. This means all dates in DT tables should be replaced using this method? We should standardized the way to sort dates and your patch add a new one. The goal is to delete the uk_date js functions and add a span around td values? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Would like to sign off, but its currently blocked by bug 9887 which is in failed qa -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17100|0 |1 is obsolete| | --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17226&action=edit Bug 9463 [Revised] Use DataTables on patron sent notices page Replace the tablesorter plugin with the DataTables plugin on the patron sent notices page. This patch adds default sorting by time (descending). This patch depends on the one for Bug 9887, which introduces a new DataTables plugin to allow sorting on data embedded in a <span>'s "title" attribute. This allows sorting to be done on an unformatted datetime. To test, open the sent notices page for a patron who has multiple sent notices. Confirm that table sorting works correctly with various date format settings. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17111|0 |1 is obsolete| | --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17227&action=edit Bug 9463: FIX DT sort by date for the last column Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- On a patron with an empty notices table an alert pops up: DataTables warning (table id = 'noticestable'): Requested unknown parameter '1' from the data source for row 0 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17226|0 |1 is obsolete| | Attachment #17227|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17287&action=edit Bug 9463 [Revised] Use DataTables on patron sent notices page Replace the tablesorter plugin with the DataTables plugin on the patron sent notices page. This patch adds default sorting by time (descending). This patch depends on the one for Bug 9887, which introduces a new DataTables plugin to allow sorting on data embedded in a <span>'s "title" attribute. This allows sorting to be done on an unformatted datetime. To test, open the sent notices page for a patron who has multiple sent notices. Confirm that table sorting works correctly with various date format settings. Revision corrects an error which occurs when there are no notices: Instead of displaying an empty table with a message the table is not displayed and a standard dialog message is displayed. In order to prevent page-specific CSS and JS from conflicting with the standard "message" class the page-specific classes have been changed from "message*" to "notice*" Test this change by viewing a page with existing notices and clicking the titles to show/hide the notice contents. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17287|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17397&action=edit Bug 9463 [Revised] Use DataTables on patron sent notices page Replace the tablesorter plugin with the DataTables plugin on the patron sent notices page. This patch adds default sorting by time (descending). This patch depends on the one for Bug 9887, which introduces a new DataTables plugin to allow sorting on data embedded in a <span>'s "title" attribute. This allows sorting to be done on an unformatted datetime. To test, open the sent notices page for a patron who has multiple sent notices. Confirm that table sorting works correctly with various date format settings. Revision corrects an error which occurs when there are no notices: Instead of displaying an empty table with a message the table is not displayed and a standard dialog message is displayed. In order to prevent page-specific CSS and JS from conflicting with the standard "message" class the page-specific classes have been changed from "message*" to "notice*" Test this change by viewing a page with existing notices and clicking the titles to show/hide the notice contents. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: This patch replaces tablesorter with DataTables on the patron sent notices page. All works great. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17397|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17440&action=edit Bug 9463 [Revised] Use DataTables on patron sent notices page Replace the tablesorter plugin with the DataTables plugin on the patron sent notices page. This patch adds default sorting by time (descending). This patch depends on the one for Bug 9887, which introduces a new DataTables plugin to allow sorting on data embedded in a <span>'s "title" attribute. This allows sorting to be done on an unformatted datetime. To test, open the sent notices page for a patron who has multiple sent notices. Confirm that table sorting works correctly with various date format settings. Revision corrects an error which occurs when there are no notices: Instead of displaying an empty table with a message the table is not displayed and a standard dialog message is displayed. In order to prevent page-specific CSS and JS from conflicting with the standard "message" class the page-specific classes have been changed from "message*" to "notice*" Test this change by viewing a page with existing notices and clicking the titles to show/hide the notice contents. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org