[Bug 21148] New: Dropdowns styled by the Select2 plugin do not highlight missing required fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21148 Bug ID: 21148 Summary: Dropdowns styled by the Select2 plugin do not highlight missing required fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 13501 If you have a field marked as mandatory in your item framework and that field is styled by the Select2 plugin, it is not highlighted in the same way other fields are when you try to submit an empty mandatory value. Other fields get a yellow background. There is custom CSS for the Select2plugin which is supposed to do this job, but it doesn't appear to get getting applied. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 [Bug 13501] Allow autocompletion on drop-down lists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21148 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 [Bug 14662] Add empty entry to pull downs in item form when subfield is mandatory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21148 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21148 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77442&action=edit Bug 21148: Dropdowns styled by the Select2 plugin do not highlight missing required fields This patch adds some CSS to target mandatory fields on the add item screen which are styled by the Select2 plugin. To test you must have at least one item field marked mandatory and linked to an authorized value. Open the add item form for an existing record. Try to submit the form without making a selection in the mandatory dropdown. You should get an alert warning you that you have empty mandatory fields, and the field should be highlighted in yellow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77442|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77446&action=edit Bug 21148: Dropdowns styled by the Select2 plugin do not highlight missing required fields This patch adds some CSS to target mandatory fields on the add item screen which are styled by the Select2 plugin. To test you must have at least one item field marked mandatory and linked to an authorized value. Open the add item form for an existing record. Try to submit the form without making a selection in the mandatory dropdown. You should get an alert warning you that you have empty mandatory fields, and the field should be highlighted in yellow. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21148 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21148 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77446|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77494&action=edit Bug 21148: Dropdowns styled by the Select2 plugin do not highlight missing required fields This patch adds some CSS to target mandatory fields on the add item screen which are styled by the Select2 plugin. To test you must have at least one item field marked mandatory and linked to an authorized value. Open the add item form for an existing record. Try to submit the form without making a selection in the mandatory dropdown. You should get an alert warning you that you have empty mandatory fields, and the field should be highlighted in yellow. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21148 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21148 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21148 Bug 21148 depends on bug 14662, which changed state. Bug 14662 Summary: Allow blank values in pull downs in cataloguing forms when subfield is mandatory https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21148 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org