[Bug 21145] New: The "Column visibility" button should not be displayed at the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Bug ID: 21145 Summary: The "Column visibility" button should not be displayed at the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org See Bug 7547 Comment 17 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 [Bug 7547] Printing a sorted cart -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 77422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77422&action=edit Bug 21145: Do not show buttons for datatables on opac detail page Test plan: 0) Do not apply the patch 1) Go to opac detail page 2) There are up to three datatables - items - items from other branches (only if there are any and the OpacSeparateHoldings preference is set) - subscriptions 3) try to find record with all three tables and confirm, there is button "Columns visibility" above the table 4) Apply the patch 5) Repeat 1-3 and confirm the button is no more here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Josef, this 'B' has not been added by 7547, did you understand why it comes from it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Bug 16759 - Make OPAC holdings table configurable It would be nice if we could make it so that if all columns were marked "Cannot be toggled" in Administration->Columns configuration, the column visibility button wouldn't appear. I'd say this bug should either be repurposed for that goal or marked invalid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is an ergonomic issue: https://screenshots.firefox.com/Boc5Au4AfMnN9O1F/catalogue.kohadev.org It is fixed by this patch and restore the behavior pre-bug 7547. IMO we should have it as it and then see if it needs to be improved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #3)
Bug 16759 - Make OPAC holdings table configurable
Sorry, I misunderstood the root of the problem. Bug 16759 didn't seek to add the columns configuration button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77422|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77456&action=edit Bug 21145: Do not show buttons for datatables on opac detail page Test plan: 0) Do not apply the patch 1) Go to opac detail page 2) There are up to three datatables - items - items from other branches (only if there are any and the OpacSeparateHoldings preference is set) - subscriptions 3) try to find record with all three tables and confirm, there is button "Columns visibility" above the table 4) Apply the patch 5) Repeat 1-3 and confirm the button is no more here Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Bug 16759 added the "B" dom configuration, but didn't add the corresponding button plugin. When Bug 7547 updated DataTables to include the button plugin the button appeared. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77456|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77458&action=edit Bug 21145: Do not show buttons for datatables on opac detail page Test plan: 0) Do not apply the patch 1) Go to opac detail page 2) There are up to three datatables - items - items from other branches (only if there are any and the OpacSeparateHoldings preference is set) - subscriptions 3) try to find record with all three tables and confirm, there is button "Columns visibility" above the table 4) Apply the patch 5) Repeat 1-3 and confirm the button is no more here Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Thank you both for so quick testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21145 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 7547 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org