[Bug 8150] New: Patron circulation history has a fossil navagation bar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8150 Priority: P5 - low Change sponsored?: --- Bug ID: 8150 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: Patron circulation history has a fossil navagation bar Severity: minor Classification: Unclassified OS: All Reporter: colin.campbell@ptfs-europe.com Hardware: All Status: NEW Version: master Component: Patrons Product: Koha The patron circulation history has new table navigation using datatables but the old navigation is still included in the template so that it appears with two navigation bars one that works and one that doesnt remove the duff one -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8150 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|kyle.m.hall@gmail.com |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 9764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9764&action=edit Proposed Patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8150 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9764|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 9770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9770&action=edit Bug 8150 [SIGNED-OFF] Remove obsoleted navigation bar in circ history The navigation bar is now supplied by the datatables plugin however we are still calling the old navigation include resulting in a second navigation bar which does nor work Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised, without introducing any bad side effects that I can see. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8150 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |magnus@enger.priv.no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8150 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: removal of code only, always ++ ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8150 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Yikes: for an unknown reason, your patch had 2 UTF-8 headers: 6 Content-Type: text/plain; charset=UTF-8 7 Content-Transfer-Encoding: 8bit 8 Content-Type: text/plain; charset="utf-8" Removing the one from line 8 make the patch working. Magnus, if you can explain why... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8150 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Bug fix, pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8150 --- Comment #6 from Magnus Enger <magnus@enger.priv.no> --- (In reply to comment #4)
Yikes: for an unknown reason, your patch had 2 UTF-8 headers: 6 Content-Type: text/plain; charset=UTF-8 7 Content-Transfer-Encoding: 8bit 8 Content-Type: text/plain; charset="utf-8"
Removing the one from line 8 make the patch working. Magnus, if you can explain why...
I have no idea why that happens, but I have seen it happen for others too... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8150 --- Comment #7 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Could be that one is being added due to something in .gitconfig or in a git hook but that the mailer is setting it too.... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org