[Bug 6430] New: DB changes needed for Hourly Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6430 Bug #: 6430 Summary: DB changes needed for Hourly Circulation Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Blocks: 5549 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6430 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-05-31 01:37:58 UTC --- Created attachment 4311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4311 Bug 6430 - DB changes needed to support hourly circ Changing columns to datetime instead of date Squashed commit of the following: commit ccf37880eaf660685d439b000298dcc025e78b6e Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Thu May 26 12:06:24 2011 +1200 Bug 5549 backing out of decision to change the name of the colums commit 2e326fdec7d768fe93d41e93abf3ca665a363791 Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Tue May 24 14:31:26 2011 +1200 Bug 5549 : Starting work on hourly loans, changing issues table -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6430 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6431 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6430 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jcamins@cpbibliography.com Resolution| |WONTFIX --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-12 23:05:32 UTC --- Per conversation with rangi, this patch has already been applied to the branch for bug 5579. Marking this bug RESOLVED-WONTFIX. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m, | |paul.poulain@biblibre.com --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hummm. I don't understand how this patch have been pushed into master: commit e56c4b249d9ac66e05054f916560a0f7bea9a194 Author: Chris Cormack <chrisc@catalyst.net.nz> AuthorDate: Tue May 31 13:35:14 2011 +1200 Commit: Chris Cormack <chrisc@catalyst.net.nz> CommitDate: Tue Mar 20 13:28:52 2012 +1300 Bug 6430 - DB changes needed to support hourly circ So, it is in master since Mar 20 2012. It breaks my patch Bug 6751: I compare the issue.returndate and C4::Dates->new(); Before this patch, it was consistent, comparing date and date. But now, issue.returndate is never equal to C4::Dates->new(); (compare datetime and date). I think my patch is not the only one encountering this problem. With a quick search, I think at least these lines are impacted: C4/Members.pm: if ($it->{'issuedate'} eq $today) { circ/circulation.pl: if ( $todaysdate eq $it->{'issuedate'} or $todaysdate eq $it->{'lastreneweddate'} ) { Did I misunderstand something (and then I need my week-end break now!) or does this patch introduce side effects ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8154 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6430 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Im sure it does introduce side effects, but it was not pushed as a standalone patch but as part of bug 5549, with a ton of other patches fixing things. And yes hourly loans is in 3.8.0. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6430 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8129 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org