[Bug 43336] New: Remove support for LibrisSpellcheck
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 Bug ID: 43336 Summary: Remove support for LibrisSpellcheck Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org Target Milestone: --- The Swedish National Library has discontinued the "bibspell" API that used to live at http://api.libris.kb.se/bibspell/ on which the LibrisSpellcheck feature was built, so we need to remove this feature from Koha. This should include at least: - The code - The sysprefs LibrisKey and LibrisURL - Settings for LibrisSpellcheck in the syspref OPACdidyoumean MariaDB [koha_kohadev]> select * from systempreferences where variable = 'opacdidyoumean'\G *************************** 1. row *************************** variable: OPACdidyoumean value: [{ "name": "AuthorityFile"}, { "name": "ExplodedTerms"}, { "name": "LibrisSpellcheck"}] options: NULL explanation: Did you mean? configuration for the OPAC. Do not change, as this is controlled by /cgi-bin/koha/admin/didyoumean.pl. type: Free $ grep -rn LibrisSpell * Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm:1:package Koha::SuggestionEngine::Plugin::LibrisSpellcheck; Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm:27: return 'LibrisSpellcheck'; Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm:68:Koha::SuggestionEngine::Plugin::LibrisSpellcheck koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt:24: [% CASE 'LibrisSpellcheck' %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans.palsson@hkr.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |System Administration Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |magnus@libriotech.no |ity.org | Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 205177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205177&action=edit Bug 43336: Remove support for LibrisSpellcheck The API that this feature was based on was removed by the Swedish National Library, so we can remove the code and sysprefs from Koha. Before testing: - Run this SQL in the database and verify the syspref is empty: SELECT value FROM systempreferences WHERE variable = 'OPACdidyoumean'; - Go to Administration > Did you mean? and verify there is a box for LibrisSpellcheck - Move the boxes around and click on "Save configuration" - Run the SQL again and verify the contents of the syspref are now something like this: [{ "name": "AuthorityFile"}, { "name": "LibrisSpellcheck"}, { "name": "ExplodedTerms"}] - Go to Administration > System preferences and search for "libris" - Verify the two sysprefs LibrisKey and LibrisURL show up To test: - Apply this patch and make sure the DB update is run. In KTD you can do: $ sudo koha-upgrade-schema kohadev The output from this should be like this: Removed system preference 'LibrisKey' Removed system preference 'LibrisURL' 'LibrisSpellcheck' was removed from the OPACdidyoumean syspref - Run koha-upgrade-schema again. The output should be: 'LibrisKey' syspref already removed 'LibrisURL' syspref already removed 'OPACdidyoumean' syspref does not contain a setting for 'LibrisSpellcheck' - Run the same SQL as before and verify that LibrisSpellcheck is now gone: [{"name":"AuthorityFile"},{"name":"ExplodedTerms"}] - Go to Administration > Did you mean? and verify there is no box for LibrisSpellcheck - Move the boxes around and click on "Save configuration" - Run the SQL again and verify that there is still no mention of LibrisSpellcheck - Go to Administration > System preferences and search for "libris" - Verify the two sysprefs LibrisKey and LibrisURL do NOT show up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205177|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 205255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205255&action=edit Bug 43336: Remove support for LibrisSpellcheck The API that this feature was based on was removed by the Swedish National Library, so we can remove the code and sysprefs from Koha. Before testing: - Run this SQL in the database and verify the syspref is empty: SELECT value FROM systempreferences WHERE variable = 'OPACdidyoumean'; - Go to Administration > Did you mean? and verify there is a box for LibrisSpellcheck - Move the boxes around and click on "Save configuration" - Run the SQL again and verify the contents of the syspref are now something like this: [{ "name": "AuthorityFile"}, { "name": "LibrisSpellcheck"}, { "name": "ExplodedTerms"}] - Go to Administration > System preferences and search for "libris" - Verify the two sysprefs LibrisKey and LibrisURL show up To test: - Apply this patch and make sure the DB update is run. In KTD you can do: $ sudo koha-upgrade-schema kohadev The output from this should be like this: Removed system preference 'LibrisKey' Removed system preference 'LibrisURL' 'LibrisSpellcheck' was removed from the OPACdidyoumean syspref - Run koha-upgrade-schema again. The output should be: 'LibrisKey' syspref already removed 'LibrisURL' syspref already removed 'OPACdidyoumean' syspref does not contain a setting for 'LibrisSpellcheck' - Run the same SQL as before and verify that LibrisSpellcheck is now gone: [{"name":"AuthorityFile"},{"name":"ExplodedTerms"}] - Go to Administration > Did you mean? and verify there is no box for LibrisSpellcheck - Move the boxes around and click on "Save configuration" - Run the SQL again and verify that there is still no mention of LibrisSpellcheck - Go to Administration > System preferences and search for "libris" - Verify the two sysprefs LibrisKey and LibrisURL do NOT show up Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes support for release notes| |LibrisSpellcheck, as the | |API that this feature was | |based on was removed by the | |Swedish National Library. | | | |It removes two system | |preferences: LibrisKey and | |LibrisURL. It also removes | |the LibrisSpellcheck option | |from "Did you mean?" | |(Administration > | |Additional parameters > Did | |you mean?). CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Sorry, there is a problem with the database update when OPACdidyoumean is empty. Will do a new version of the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205255|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- Created attachment 205406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205406&action=edit Bug 43336: Remove support for LibrisSpellcheck The API that this feature was based on was removed by the Swedish National Library, so we can remove the code and sysprefs from Koha. Before testing: - Run this SQL in the database and verify the syspref is empty: SELECT value FROM systempreferences WHERE variable = 'OPACdidyoumean'; - Go to Administration > Did you mean? and verify there is a box for LibrisSpellcheck - Move the boxes around and click on "Save configuration" - Run the SQL again and verify the contents of the syspref are now something like this: [{ "name": "AuthorityFile"}, { "name": "LibrisSpellcheck"}, { "name": "ExplodedTerms"}] - Go to Administration > System preferences and search for "libris" - Verify the two sysprefs LibrisKey and LibrisURL show up To test: - Apply this patch and make sure the DB update is run. In KTD you can do: $ sudo koha-upgrade-schema kohadev The output from this should be like this: Removed system preference 'LibrisKey' Removed system preference 'LibrisURL' 'LibrisSpellcheck' was removed from the OPACdidyoumean syspref - Run koha-upgrade-schema again. The output should be: 'LibrisKey' syspref already removed 'LibrisURL' syspref already removed 'OPACdidyoumean' syspref does not contain a setting for 'LibrisSpellcheck' - Run the same SQL as before and verify that LibrisSpellcheck is now gone: [{"name":"AuthorityFile"},{"name":"ExplodedTerms"}] - Go to Administration > Did you mean? and verify there is no box for LibrisSpellcheck - Move the boxes around and click on "Save configuration" - Run the SQL again and verify that there is still no mention of LibrisSpellcheck - Go to Administration > System preferences and search for "libris" - Verify the two sysprefs LibrisKey and LibrisURL do NOT show up - Empty the OPACdidyoumean syspref by running this SQL: UPDATE systempreferences SET value = '' WHERE variable = 'OPACdidyoumean'; - Run koha-upgrade-schema again. The output should be: 'LibrisKey' syspref already removed 'LibrisURL' syspref already removed 'OPACdidyoumean' is not set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- There was a problem with running the database update when OPACdidyoumean was not set. The new version of the patch should fix this. I added these steps to the end of the test plan, to verify: - Empty the OPACdidyoumean syspref by running this SQL: UPDATE systempreferences SET value = '' WHERE variable = 'OPACdidyoumean'; - Run koha-upgrade-schema again. The output should be: 'LibrisKey' syspref already removed 'LibrisURL' syspref already removed 'OPACdidyoumean' is not set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205406|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 205427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205427&action=edit Bug 43336: Remove support for LibrisSpellcheck The API that this feature was based on was removed by the Swedish National Library, so we can remove the code and sysprefs from Koha. Before testing: - Run this SQL in the database and verify the syspref is empty: SELECT value FROM systempreferences WHERE variable = 'OPACdidyoumean'; - Go to Administration > Did you mean? and verify there is a box for LibrisSpellcheck - Move the boxes around and click on "Save configuration" - Run the SQL again and verify the contents of the syspref are now something like this: [{ "name": "AuthorityFile"}, { "name": "LibrisSpellcheck"}, { "name": "ExplodedTerms"}] - Go to Administration > System preferences and search for "libris" - Verify the two sysprefs LibrisKey and LibrisURL show up To test: - Apply this patch and make sure the DB update is run. In KTD you can do: $ sudo koha-upgrade-schema kohadev The output from this should be like this: Removed system preference 'LibrisKey' Removed system preference 'LibrisURL' 'LibrisSpellcheck' was removed from the OPACdidyoumean syspref - Run koha-upgrade-schema again. The output should be: 'LibrisKey' syspref already removed 'LibrisURL' syspref already removed 'OPACdidyoumean' syspref does not contain a setting for 'LibrisSpellcheck' - Run the same SQL as before and verify that LibrisSpellcheck is now gone: [{"name":"AuthorityFile"},{"name":"ExplodedTerms"}] - Go to Administration > Did you mean? and verify there is no box for LibrisSpellcheck - Move the boxes around and click on "Save configuration" - Run the SQL again and verify that there is still no mention of LibrisSpellcheck - Go to Administration > System preferences and search for "libris" - Verify the two sysprefs LibrisKey and LibrisURL do NOT show up - Empty the OPACdidyoumean syspref by running this SQL: UPDATE systempreferences SET value = '' WHERE variable = 'OPACdidyoumean'; - Run koha-upgrade-schema again. The output should be: 'LibrisKey' syspref already removed 'LibrisURL' syspref already removed 'OPACdidyoumean' is not set Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I added the exec flag to the atomicupdate. Everything else looks good! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205427|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206152&action=edit Bug 43336: Remove support for LibrisSpellcheck The API that this feature was based on was removed by the Swedish National Library, so we can remove the code and sysprefs from Koha. Before testing: - Run this SQL in the database and verify the syspref is empty: SELECT value FROM systempreferences WHERE variable = 'OPACdidyoumean'; - Go to Administration > Did you mean? and verify there is a box for LibrisSpellcheck - Move the boxes around and click on "Save configuration" - Run the SQL again and verify the contents of the syspref are now something like this: [{ "name": "AuthorityFile"}, { "name": "LibrisSpellcheck"}, { "name": "ExplodedTerms"}] - Go to Administration > System preferences and search for "libris" - Verify the two sysprefs LibrisKey and LibrisURL show up To test: - Apply this patch and make sure the DB update is run. In KTD you can do: $ sudo koha-upgrade-schema kohadev The output from this should be like this: Removed system preference 'LibrisKey' Removed system preference 'LibrisURL' 'LibrisSpellcheck' was removed from the OPACdidyoumean syspref - Run koha-upgrade-schema again. The output should be: 'LibrisKey' syspref already removed 'LibrisURL' syspref already removed 'OPACdidyoumean' syspref does not contain a setting for 'LibrisSpellcheck' - Run the same SQL as before and verify that LibrisSpellcheck is now gone: [{"name":"AuthorityFile"},{"name":"ExplodedTerms"}] - Go to Administration > Did you mean? and verify there is no box for LibrisSpellcheck - Move the boxes around and click on "Save configuration" - Run the SQL again and verify that there is still no mention of LibrisSpellcheck - Go to Administration > System preferences and search for "libris" - Verify the two sysprefs LibrisKey and LibrisURL do NOT show up - Empty the OPACdidyoumean syspref by running this SQL: UPDATE systempreferences SET value = '' WHERE variable = 'OPACdidyoumean'; - Run koha-upgrade-schema again. The output should be: 'LibrisKey' syspref already removed 'LibrisURL' syspref already removed 'OPACdidyoumean' is not set Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 --- Comment #9 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=43668 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=43667 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43336 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43668 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org