[Bug 43671] New: Holds impair SCO module load time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43671 Bug ID: 43671 Summary: Holds impair SCO module load time Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: emily.lamancusa@montgomerycountymd.gov Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org Target Milestone: --- In a large system, holds can have a significant impact on the amount of time it takes for the main page to load in the SCO module. In our system during busy times, patrons with many holds see load times of 20 seconds or more after logging into the SCO Module and after each checkout. We can already avoid the impact of existing checkouts on SCO Module load times, because the system preference SCOLoadCheckoutsByDefault allows the patron's existing checkouts to be loaded on-demand. We should have the option to delay the loading of holds as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43671 --- Comment #1 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 207003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207003&action=edit Bug 43671: Add SCOLoadHoldsByDefault Add the option to prevent loading a patron's holds right away in the SCO Module. To test: 1. Apply patch, updatedatabase, and restart services 2. Place at least one hold for a patron 3. Browse to the SCO module in a private window: /cgi-bin/koha/sco/sco-main.pl 4. Log into the SCO as the patron from step 2 5. Click the "Holds" tab --> Confirm you see the patron's hold(s) 6. Click "Finish" 7. Disable the system preference SCOLoadHoldsByDefault 8. Log into the SCO as that same patron 9. Clock the "Holds" tab --> Confirm the holds do not load and you see a "Load your holds" button 10. Click the button --> Confirm the hold(s) load -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43671 --- Comment #2 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 207004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207004&action=edit Bug 43671: Search for waiting holds instead of looping manually sco-main.pl had a while loop for the sole purpose of looping through all the patron's holds just to count how many were waiting. We should use the ->search function to identify waiting holds instead and let the DBI optimize the search. To test: 1. Apply patch and restart services 2. Have a patron with at least one pending hold, and no holds waiting 3. Open the SCO module in a private window: /cgi/bin/sco/sco-main.pl 4. Log into the SCO module as the patron from step 2 -->Confirm the holds tab shows the total number of the patron's holds and no additional icons 6. Click "Finish" 7. In the staff interface, check in an item at the pickup branch to set one of the patron's holds to Waiting 8. Log back into the SCO module as that patron --> Confirm the holds tab now has an (!) icon to indicate the patron has at least one waiting hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43671 --- Comment #3 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 207005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207005&action=edit Bug 43671: (follow-up) UI fixes Select the holds tab by default when the page reloads after clicking the "Show My Holds" button Make sure "load checkouts" button and "load holds" button pass through each other's values, so that clicking one button doesn't unintentionally change the status of the other -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43671 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43671 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43671 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43671 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43671 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207003|0 |1 is obsolete| | Attachment #207004|0 |1 is obsolete| | Attachment #207005|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43671 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 207062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207062&action=edit Bug 43671: Add SCOLoadHoldsByDefault Add the option to prevent loading a patron's holds right away in the SCO Module. To test: 1. Apply patch, updatedatabase, and restart services 2. Place at least one hold for a patron 3. Browse to the SCO module in a private window: /cgi-bin/koha/sco/sco-main.pl 4. Log into the SCO as the patron from step 2 5. Click the "Holds" tab --> Confirm you see the patron's hold(s) 6. Click "Finish" 7. Disable the system preference SCOLoadHoldsByDefault 8. Log into the SCO as that same patron 9. Clock the "Holds" tab --> Confirm the holds do not load and you see a "Load your holds" button 10. Click the button --> Confirm the hold(s) load Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43671 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 207063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207063&action=edit Bug 43671: Search for waiting holds instead of looping manually sco-main.pl had a while loop for the sole purpose of looping through all the patron's holds just to count how many were waiting. We should use the ->search function to identify waiting holds instead and let the DBI optimize the search. To test: 1. Apply patch and restart services 2. Have a patron with at least one pending hold, and no holds waiting 3. Open the SCO module in a private window: /cgi/bin/sco/sco-main.pl 4. Log into the SCO module as the patron from step 2 -->Confirm the holds tab shows the total number of the patron's holds and no additional icons 6. Click "Finish" 7. In the staff interface, check in an item at the pickup branch to set one of the patron's holds to Waiting 8. Log back into the SCO module as that patron --> Confirm the holds tab now has an (!) icon to indicate the patron has at least one waiting hold Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43671 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 207064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207064&action=edit Bug 43671: (follow-up) UI fixes Select the holds tab by default when the page reloads after clicking the "Show My Holds" button Make sure "load checkouts" button and "load holds" button pass through each other's values, so that clicking one button doesn't unintentionally change the status of the other Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43671 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the release notes| |self-checkout module to | |improve the loading time | |for the holds tab, | |particularly where there | |are a large number of | |holds. | | | |It adds a new system | |preference, | |SCOLoadHoldsByDefault | |(enabled by default). If | |not enabled, there is a | |button "Load your holds" | |when you click the "Holds" | |tab. | | | |It also adds an exclamation | |mark (!) to the SCO holds | |tab header if there are | |holds waiting for pickup. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org