[Bug 35329] New: Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Bug ID: 35329 Summary: Move patron searches to a modal Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The patron searches are made in a popup window, we should move it to a modal: 1. More friendly for end users 2. Will be able to test correctly from cypress 3. Easier to maintain (code will be less ugly). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org, | |tomascohen@gmail.com Status|ASSIGNED |In Discussion --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There are 2 remotes branches on my gitlab repo: * move_to_modal * move_to_modal-simple See message from last commit of move_to_modal to know the known problems. Then try the other branch. There are some downside as well but might be considered good enough? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35742 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35742 [Bug 35742] Cannot remove new user added to fund -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35743 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35743 [Bug 35743] The "category" filter is not selected in the column filter dropdown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35744 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 [Bug 35744] Implement +strings for GET /patrons/:patron_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35745 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35745 [Bug 35745] Setting suggester on the suggestion edit form does not show library and category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35701 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 [Bug 35701] Cannot use i18n.inc from MACRO block? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|35744 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35744 [Bug 35744] Implement +strings for GET /patrons/:patron_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160698&action=edit Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160699&action=edit Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160700&action=edit Bug 35329: Move patron search to modal - basket Add user to an acquisition basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160701&action=edit Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160702&action=edit Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160703&action=edit Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160704&action=edit Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160705&action=edit Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160706&action=edit Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #2)
Created attachment 160698 [details] [review] Bug 35329: move patron search to modal - Add guarantor
This patch is co-authored-by: Owen, thanks! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Here's what I've found so far: - The search from neworderempty.pl doesn't work at all. The form shows up but doesn't work to return results. - On some pages there is feedback when you click an "Add" button from the search results. If you select a patron who has a space in borrowers.firstname, e.g. "John Quincy" the message looks like this: "Patron 'John%20Quincy Adams' added." - Intermittently I get this error: Uncaught TypeError: can't access property "description", categories_map[data.toLowerCase()] is undefined ...but I haven't been able to pin down how to reproduce it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160728&action=edit Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #12)
Here's what I've found so far:
- The search from neworderempty.pl doesn't work at all. The form shows up but doesn't work to return results.
Should be fixed on "Bug 35329: Fix neworderempty"
- On some pages there is feedback when you click an "Add" button from the search results. If you select a patron who has a space in borrowers.firstname, e.g. "John Quincy" the message looks like this:
"Patron 'John%20Quincy Adams' added."
Reported on a separate bug (it affects master): bug 35756
- Intermittently I get this error:
Uncaught TypeError: can't access property "description", categories_map[data.toLowerCase()] is undefined
...but I haven't been able to pin down how to reproduce it.
This can happen if one of patron's category is not defined in the patron categories admin area (not possible, we have a FK, but maybe it's NULL?). Or if you have created a patron category in a separate window and run the search from the modal without having refreshed it. Just guesses here... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160729&action=edit Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Remaining work: 1. Add/fix some styling 2. Fix Select2 styling (width is too short) 3. Add E2E tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160698|0 |1 is obsolete| | Attachment #160699|0 |1 is obsolete| | Attachment #160700|0 |1 is obsolete| | Attachment #160701|0 |1 is obsolete| | Attachment #160702|0 |1 is obsolete| | Attachment #160703|0 |1 is obsolete| | Attachment #160704|0 |1 is obsolete| | Attachment #160705|0 |1 is obsolete| | Attachment #160706|0 |1 is obsolete| | Attachment #160728|0 |1 is obsolete| | Attachment #160729|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160733&action=edit Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160734&action=edit Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160735&action=edit Bug 35329: Move patron search to modal - basket Add user to an acquisition basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160736&action=edit Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160737&action=edit Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160738&action=edit Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160739&action=edit Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160740&action=edit Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160741&action=edit Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160742&action=edit Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160743&action=edit Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35756 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35756 [Bug 35756] Wrong use of encodeURIComponent in patron-search.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160759&action=edit Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160760&action=edit Bug 35329: Prevent XSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160760|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160761&action=edit Bug 35329: Prevent XSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160762&action=edit Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that <label>s wrap the <input> fields, allowing the label to be clickable without having to associate it with a unique id. CSS has been modified to accommodate this change. The patch also adds missing Bootstrap classes to the "Clear" button, and swaps out the "hint" class for the "note" class on the permissions information ("Only staff with superlibrarian or acquisitions permissions..."). After this patch, form field labels in the patron search modal should be clickable to give focus to the field (except for Sort 1 and Sort 2 -- label don't work that way with Select2). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160763&action=edit Bug 35329: Add selenium tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160759|0 |1 is obsolete| | Attachment #160761|0 |1 is obsolete| | Attachment #160762|0 |1 is obsolete| | Attachment #160763|0 |1 is obsolete| | --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160768&action=edit Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160769&action=edit Bug 35329: Prevent XSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #35 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160770&action=edit Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that <label>s wrap the <input> fields, allowing the label to be clickable without having to associate it with a unique id. CSS has been modified to accommodate this change. The patch also adds missing Bootstrap classes to the "Clear" button, and swaps out the "hint" class for the "note" class on the permissions information ("Only staff with superlibrarian or acquisitions permissions..."). After this patch, form field labels in the patron search modal should be clickable to give focus to the field (except for Sort 1 and Sort 2 -- label don't work that way with Select2). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160771&action=edit Bug 35329: Add selenium tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160771|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160773&action=edit Bug 35329: Add selenium tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160774&action=edit Bug 35329: Add cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160940&action=edit Bug 35329: Add POD + tidy Selenium.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160940|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160941&action=edit Bug 35329: Add POD + tidy Selenium.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160733|0 |1 is obsolete| | Attachment #160734|0 |1 is obsolete| | Attachment #160735|0 |1 is obsolete| | Attachment #160736|0 |1 is obsolete| | Attachment #160737|0 |1 is obsolete| | Attachment #160738|0 |1 is obsolete| | Attachment #160739|0 |1 is obsolete| | Attachment #160740|0 |1 is obsolete| | Attachment #160741|0 |1 is obsolete| | Attachment #160742|0 |1 is obsolete| | Attachment #160743|0 |1 is obsolete| | Attachment #160768|0 |1 is obsolete| | Attachment #160769|0 |1 is obsolete| | Attachment #160770|0 |1 is obsolete| | Attachment #160773|0 |1 is obsolete| | Attachment #160774|0 |1 is obsolete| | Attachment #160941|0 |1 is obsolete| | --- Comment #41 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160943&action=edit Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #42 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160944&action=edit Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #43 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160945&action=edit Bug 35329: Move patron search to modal - basket Add user to an acquisition basket Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #44 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160946&action=edit Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160947&action=edit Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #46 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160948&action=edit Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #47 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160949&action=edit Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #48 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160950&action=edit Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #49 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160951&action=edit Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #50 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160952&action=edit Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #51 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160953&action=edit Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #52 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160954&action=edit Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #53 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160955&action=edit Bug 35329: Prevent XSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #54 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160956&action=edit Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that <label>s wrap the <input> fields, allowing the label to be clickable without having to associate it with a unique id. CSS has been modified to accommodate this change. The patch also adds missing Bootstrap classes to the "Clear" button, and swaps out the "hint" class for the "note" class on the permissions information ("Only staff with superlibrarian or acquisitions permissions..."). After this patch, form field labels in the patron search modal should be clickable to give focus to the field (except for Sort 1 and Sort 2 -- label don't work that way with Select2). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #55 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160957&action=edit Bug 35329: Add selenium tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #56 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160958&action=edit Bug 35329: Add cypress tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #57 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160959&action=edit Bug 35329: Add POD + tidy Selenium.pm Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Minor comment, I think the result of an action could be made more apparent.. it's rather hidden away.. also, if re-opening the modal, the result of the last operation is still visible. I tested with New Order Empty to deduct the above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Next comment.. could we perhaps put the results next to rather than under the filters form in the modal? It feels odd to have so much whitespace in the modal and have the actual useful content almost hidden off screen.. widescreen aspect ratios are pretty common these days? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161165&action=edit Widescreen display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161166&action=edit Almost invisible feedback -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So.. those two could be new bug follow-ups as they're enhancements on top of this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We should have a message similar to that on the funds ownership search in the basket manager search.. we limit that search to users with particular permissions too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- For consistency, I feel like whenever a search can be used to add to a list of patrons, we should expose the select boxes and add selected functionlity. I don't think this should be specifically limited to patron card creator batches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160943|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161183&action=edit Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160944|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161184&action=edit Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160945|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161185&action=edit Bug 35329: Move patron search to modal - basket Add user to an acquisition basket Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160946|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161186&action=edit Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160947|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161187&action=edit Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160948|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161188&action=edit Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160949|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161189&action=edit Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160950|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161190&action=edit Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160951|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161191&action=edit Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160952|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161192&action=edit Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160953|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161193&action=edit Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160954|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161194&action=edit Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160955|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161195&action=edit Bug 35329: Prevent XSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160956|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161196&action=edit Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that <label>s wrap the <input> fields, allowing the label to be clickable without having to associate it with a unique id. CSS has been modified to accommodate this change. The patch also adds missing Bootstrap classes to the "Clear" button, and swaps out the "hint" class for the "note" class on the permissions information ("Only staff with superlibrarian or acquisitions permissions..."). After this patch, form field labels in the patron search modal should be clickable to give focus to the field (except for Sort 1 and Sort 2 -- label don't work that way with Select2). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160957|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161197&action=edit Bug 35329: Add selenium tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160958|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161198&action=edit Bug 35329: Add cypress tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160959|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161199&action=edit Bug 35329: Add POD + tidy Selenium.pm Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Right.. I've decided this has enough work on it already.. the functionality all works well for me and I'm unable to break anything. The consistency improvements are just that, improvements/enhancements on top of this so I'm going to report them as new bugs depending on this one and let this one pass as is. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Martin Renvoize from comment #63)
We should have a message similar to that on the funds ownership search in the basket manager search.. we limit that search to users with particular permissions too.
OK, I changed my mind on the PQA.. as far as I can tell this is actually a regression. We're calling patron_search_js as apposed to patron_search_table as our include in this case and thus the 'note' divs that display information about the search limits do not appear in this case.. it appears like they should be. There's also a mismatch in the filter names.. 'baskets_managers' vs 'orders_managers'.. I think this does need fixing before we go PQA... I had a quick look and couldn't work out the logic flow here I'm afraid :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35845 [Bug 35845] Add a 'note' or 'success'/'failure' wrapper around action feedback in patron search modals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35846 [Bug 35846] On wide screens, we should display the patron search results next to the filters rather than beneath -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35847 [Bug 35847] We should consistently display the select options when appropriate in the patron search modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35861 [Bug 35861] Allow to add several patron at once when selecting patrons (from modals) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35862 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 [Bug 35862] Display patron search result on the right of the form (modal) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35864 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35864 [Bug 35864] Should we clear patron search result when the modal is reopened? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #84 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161259&action=edit Bug 35329: Fix filter vars scope -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #85 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161260&action=edit Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #86 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #58)
Minor comment, I think the result of an action could be made more apparent.. it's rather hidden away..
Added some styling on "Add styling to info and error", but could still be improved I think.
also, if re-opening the modal, the result of the last operation is still visible.
Yes, I didn't know if it would be considered a bug or not, and it was not trivial to implement. Opened bug 35864 for discussion. (In reply to Martin Renvoize from comment #59)
Next comment.. could we perhaps put the results next to rather than under the filters form in the modal?
It feels odd to have so much whitespace in the modal and have the actual useful content almost hidden off screen.. widescreen aspect ratios are pretty common these days?
Good idea, but definitely for a separate bug. Opened bug 35862. (In reply to Martin Renvoize from comment #63)
We should have a message similar to that on the funds ownership search in the basket manager search.. we limit that search to users with particular permissions too.
Yes, this is a bug, fixed in "Fix filter vars scope". (In reply to Martin Renvoize from comment #64)
For consistency, I feel like whenever a search can be used to add to a list of patrons, we should expose the select boxes and add selected functionlity. I don't think this should be specifically limited to patron card creator batches.
No behavior changes here, but yes that could be nice. Opened bug 35861. (In reply to Martin Renvoize from comment #83)
There's also a mismatch in the filter names.. 'baskets_managers' vs 'orders_managers'.. I think this does need fixing before we go PQA... I had a quick look and couldn't work out the logic flow here I'm afraid :(
I don't think so. However orders_managers is never used (neither on master) and we should investigate that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #87 from Jonathan Druart <jonathan.druart+koha@gmail.com> ---
(In reply to Martin Renvoize from comment #83)
There's also a mismatch in the filter names.. 'baskets_managers' vs 'orders_managers'.. I think this does need fixing before we go PQA... I had a quick look and couldn't work out the logic flow here I'm afraid :(
I don't think so. However orders_managers is never used (neither on master) and we should investigate that.
Ok, opened bug 35865. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #88 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Oops, just noticed you have opened bugs already! Marked bug 35846 and bug 35861 as duplicate! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161259|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161274&action=edit Bug 35329: Fix filter vars scope Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161260|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161275&action=edit Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. with the follow-ups we've resolved all my concerns.. anything else falls into the enhancement on top category and there are bugs opened and linked for that. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35865 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35865 [Bug 35865] Missing hint about permissions when adding managers to a basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161183|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161276&action=edit Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161184|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161277&action=edit Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161185|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161278&action=edit Bug 35329: Move patron search to modal - basket Add user to an acquisition basket Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161186|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161279&action=edit Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161187|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161280&action=edit Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161188|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161281&action=edit Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161189|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161282&action=edit Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161190|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161283&action=edit Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161191|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161284&action=edit Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161192|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161285&action=edit Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161193|0 |1 is obsolete| | --- Comment #102 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161286&action=edit Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161194|0 |1 is obsolete| | --- Comment #103 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161287&action=edit Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161195|0 |1 is obsolete| | --- Comment #104 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161288&action=edit Bug 35329: Prevent XSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161196|0 |1 is obsolete| | --- Comment #105 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161289&action=edit Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that <label>s wrap the <input> fields, allowing the label to be clickable without having to associate it with a unique id. CSS has been modified to accommodate this change. The patch also adds missing Bootstrap classes to the "Clear" button, and swaps out the "hint" class for the "note" class on the permissions information ("Only staff with superlibrarian or acquisitions permissions..."). After this patch, form field labels in the patron search modal should be clickable to give focus to the field (except for Sort 1 and Sort 2 -- label don't work that way with Select2). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161197|0 |1 is obsolete| | --- Comment #106 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161290&action=edit Bug 35329: Add selenium tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161198|0 |1 is obsolete| | --- Comment #107 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161291&action=edit Bug 35329: Add cypress tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161199|0 |1 is obsolete| | --- Comment #108 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161292&action=edit Bug 35329: Add POD + tidy Selenium.pm Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161274|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161293&action=edit Bug 35329: Fix filter vars scope Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161275|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161294&action=edit Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #111 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161295&action=edit Bug 35329: (QA follow-up) Fix for bug 35865 This restores the missing hint that's restored by bug 35865 ahead of this patchset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #112 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Small rebase so I could move bug 35865 (a bugfix) above this in the dependencies and then make sure we don't lose the fix from there when applying this one to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33457 [Bug 33457] Improve display of fund users when the patron has no firstname -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161276|0 |1 is obsolete| | --- Comment #113 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161398&action=edit Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161277|0 |1 is obsolete| | --- Comment #114 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161399&action=edit Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161278|0 |1 is obsolete| | --- Comment #115 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161400&action=edit Bug 35329: Move patron search to modal - basket Add user to an acquisition basket Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161279|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161401&action=edit Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161280|0 |1 is obsolete| | --- Comment #117 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161402&action=edit Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161281|0 |1 is obsolete| | --- Comment #118 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161403&action=edit Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161282|0 |1 is obsolete| | --- Comment #119 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161404&action=edit Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161283|0 |1 is obsolete| | --- Comment #120 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161405&action=edit Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161284|0 |1 is obsolete| | --- Comment #121 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161406&action=edit Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161285|0 |1 is obsolete| | --- Comment #122 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161407&action=edit Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161286|0 |1 is obsolete| | --- Comment #123 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161408&action=edit Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161287|0 |1 is obsolete| | --- Comment #124 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161409&action=edit Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161288|0 |1 is obsolete| | --- Comment #125 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161410&action=edit Bug 35329: Prevent XSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161289|0 |1 is obsolete| | --- Comment #126 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161411&action=edit Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that <label>s wrap the <input> fields, allowing the label to be clickable without having to associate it with a unique id. CSS has been modified to accommodate this change. The patch also adds missing Bootstrap classes to the "Clear" button, and swaps out the "hint" class for the "note" class on the permissions information ("Only staff with superlibrarian or acquisitions permissions..."). After this patch, form field labels in the patron search modal should be clickable to give focus to the field (except for Sort 1 and Sort 2 -- label don't work that way with Select2). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161290|0 |1 is obsolete| | --- Comment #127 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161412&action=edit Bug 35329: Add selenium tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161291|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161413&action=edit Bug 35329: Add cypress tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161292|0 |1 is obsolete| | --- Comment #129 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161414&action=edit Bug 35329: Add POD + tidy Selenium.pm Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161293|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161415&action=edit Bug 35329: Fix filter vars scope Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161294|0 |1 is obsolete| | --- Comment #131 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161416&action=edit Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161295|0 |1 is obsolete| | --- Comment #132 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161417&action=edit Bug 35329: (QA follow-up) Fix for bug 35865 This restores the missing hint that's restored by bug 35865 ahead of this patchset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #133 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Minor rebase on top of bug 33457 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161398|0 |1 is obsolete| | Attachment #161399|0 |1 is obsolete| | Attachment #161400|0 |1 is obsolete| | Attachment #161401|0 |1 is obsolete| | Attachment #161402|0 |1 is obsolete| | Attachment #161403|0 |1 is obsolete| | Attachment #161404|0 |1 is obsolete| | Attachment #161405|0 |1 is obsolete| | Attachment #161406|0 |1 is obsolete| | Attachment #161407|0 |1 is obsolete| | Attachment #161408|0 |1 is obsolete| | Attachment #161409|0 |1 is obsolete| | Attachment #161410|0 |1 is obsolete| | Attachment #161411|0 |1 is obsolete| | Attachment #161412|0 |1 is obsolete| | Attachment #161413|0 |1 is obsolete| | Attachment #161414|0 |1 is obsolete| | Attachment #161415|0 |1 is obsolete| | Attachment #161416|0 |1 is obsolete| | Attachment #161417|0 |1 is obsolete| | --- Comment #134 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162436&action=edit Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #135 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162437&action=edit Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #136 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162438&action=edit Bug 35329: Move patron search to modal - basket Add user to an acquisition basket Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #137 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162439&action=edit Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #138 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162440&action=edit Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #139 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162441&action=edit Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #140 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162442&action=edit Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #141 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162443&action=edit Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #142 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162444&action=edit Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #143 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162445&action=edit Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #144 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162446&action=edit Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #145 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162447&action=edit Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #146 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162448&action=edit Bug 35329: Prevent XSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #147 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162449&action=edit Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that <label>s wrap the <input> fields, allowing the label to be clickable without having to associate it with a unique id. CSS has been modified to accommodate this change. The patch also adds missing Bootstrap classes to the "Clear" button, and swaps out the "hint" class for the "note" class on the permissions information ("Only staff with superlibrarian or acquisitions permissions..."). After this patch, form field labels in the patron search modal should be clickable to give focus to the field (except for Sort 1 and Sort 2 -- label don't work that way with Select2). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #148 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162450&action=edit Bug 35329: Add selenium tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #149 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162451&action=edit Bug 35329: Add cypress tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #150 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162452&action=edit Bug 35329: Add POD + tidy Selenium.pm Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #151 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162453&action=edit Bug 35329: Fix filter vars scope Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #152 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162454&action=edit Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #153 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162455&action=edit Bug 35329: (QA follow-up) Fix for bug 35865 This restores the missing hint that's restored by bug 35865 ahead of this patchset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #154 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162456&action=edit Bug 35329: Adjustment for 34478 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #155 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162457&action=edit Bug 35329: Handle duplicate without 500 This is not perfect but way better than before! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #156 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patches rebased and adjusted on top of bug 34478 (and friends). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34608 [Bug 34608] Add sort1 and sort2 to patron search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | --- Comment #157 from Jonathan Druart <jonathan.druart@gmail.com> --- Pushed to master for 24.05.00. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #158 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 162670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162670&action=edit Bug 35329: (follow-up) Add styling to info and error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #159 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 162671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162671&action=edit Bug 35329: Fix conflict with 33457 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #160 from Jonathan Druart <jonathan.druart@gmail.com> --- Last 2 patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #161 from Jonathan Druart <jonathan.druart@gmail.com> --- Same tests are still failing with those 2 patches, rescheduling another run to see if it's a random failure (I don't recreate locally). Also noted the following JS error in the log, which is not expected at all being superlibrarian: selenium_1 | JavaScript error: http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha//members/members-home.p..., line 2756: TypeError: libraries_map[data] is undefined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #162 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 162713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162713&action=edit Bug 35329: Fix autocomplete when placing a hold There was a JS error Uncaught TypeError: node.autocomplete(...).data(...) is undefined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 --- Comment #163 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 162714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162714&action=edit Bug 35329: Fix selenium tests if no fund exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #164 from Jonathan Druart <jonathan.druart@gmail.com> --- Last 2 patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36251 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36251 [Bug 36251] Patron search by letter broken in holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #165 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36706 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36706 [Bug 36706] 'Add guarantor' - Patron preview 'close window' does not work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The patron searches that release notes| |formerly used a pop-up | |windows have been moved | |into a modal. Examples: | |patron search for routing | |lists, manager search for | |suggestions, guarantor | |search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38112 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38112 [Bug 38112] Description of patrons search no longer displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38127 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 [Bug 38127] Missing column headings in 'Add user' pop-up modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38128 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38128 [Bug 38128] Agreement/License user selection not limited to users with erm permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38129 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38129 [Bug 38129] Add note regarding permissions in suggestion manager search pop-up modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/979 Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38183 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38183 [Bug 38183] Cant set suggestion manager when there are multiple tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Bug 35329 depends on bug 35745, which changed state. Bug 35745 Summary: Setting suggester on the suggestion edit form does not show library and category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35745 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Bug 35329 depends on bug 35743, which changed state. Bug 35743 Summary: The "category" filter is not selected in the column filter dropdown https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35743 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Bug 35329 depends on bug 35742, which changed state. Bug 35742 Summary: Cannot remove new user added to fund https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35742 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Bug 35329 depends on bug 33457, which changed state. Bug 33457 Summary: Improve display of fund users when the patron has no firstname https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33457 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Bug 35329 depends on bug 35701, which changed state. Bug 35701 Summary: Cannot use i18n.inc from memberentrygen https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35701 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Bug 35329 depends on bug 35865, which changed state. Bug 35865 Summary: Missing hint about permissions when adding managers to a basket https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35865 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org