https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #86 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #58)
Minor comment, I think the result of an action could be made more apparent.. it's rather hidden away..
Added some styling on "Add styling to info and error", but could still be improved I think.
also, if re-opening the modal, the result of the last operation is still visible.
Yes, I didn't know if it would be considered a bug or not, and it was not trivial to implement. Opened bug 35864 for discussion. (In reply to Martin Renvoize from comment #59)
Next comment.. could we perhaps put the results next to rather than under the filters form in the modal?
It feels odd to have so much whitespace in the modal and have the actual useful content almost hidden off screen.. widescreen aspect ratios are pretty common these days?
Good idea, but definitely for a separate bug. Opened bug 35862. (In reply to Martin Renvoize from comment #63)
We should have a message similar to that on the funds ownership search in the basket manager search.. we limit that search to users with particular permissions too.
Yes, this is a bug, fixed in "Fix filter vars scope". (In reply to Martin Renvoize from comment #64)
For consistency, I feel like whenever a search can be used to add to a list of patrons, we should expose the select boxes and add selected functionlity. I don't think this should be specifically limited to patron card creator batches.
No behavior changes here, but yes that could be nice. Opened bug 35861. (In reply to Martin Renvoize from comment #83)
There's also a mismatch in the filter names.. 'baskets_managers' vs 'orders_managers'.. I think this does need fixing before we go PQA... I had a quick look and couldn't work out the logic flow here I'm afraid :(
I don't think so. However orders_managers is never used (neither on master) and we should investigate that. -- You are receiving this mail because: You are watching all bug changes.