[Bug 38325] New: Cannot delete invoice while viewing it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 Bug ID: 38325 Summary: Cannot delete invoice while viewing it Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org Blocks: 36192 In the list of invoices in invoices.pl, an invoice that can be deleted (because nothing has ever been received into it) has a Delete action that uses submit-form-link and works with CSRF protection. In invoice.pl where you are viewing an individual invoice, the Delete link still thinks that invoice.pl?op=delete will work, which it won't. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 173877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173877&action=edit Bug 38325: Cannot delete invoice while viewing it The link to delete while viewing an individual invoice needs to be updated to use submit-form-link so it can POST with op='cud-delete'. Test plan: 1. Home - Acquisitions, click Search with an empty Vendor: input 2. Click Receive shipments, enter a number in the Vendor invoice input, click Next 3. In the left sidebar, click Invoices, click Search without any parameters 4. In the row for your invoice, click the invoice number link 5. Next to the Save button, click the Delete link, click OK in the confirmation alert 6. You'll see the page reload, and the URL change to include ?op=delete, but your invoice remains undeleted. 7. Apply patch, reload the page 8. Click Delete, click OK in the confirmation alert 9. Click Search with no parameters, just to make sure the message about "Sorry, but there are no results for your search" really truly means that your invoice was deleted and now you don't have any invoices Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173877|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 173886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173886&action=edit Bug 38325: Cannot delete invoice while viewing it The link to delete while viewing an individual invoice needs to be updated to use submit-form-link so it can POST with op='cud-delete'. Test plan: 1. Home - Acquisitions, click Search with an empty Vendor: input 2. Click Receive shipments, enter a number in the Vendor invoice input, click Next 3. In the left sidebar, click Invoices, click Search without any parameters 4. In the row for your invoice, click the invoice number link 5. Next to the Save button, click the Delete link, click OK in the confirmation alert 6. You'll see the page reload, and the URL change to include ?op=delete, but your invoice remains undeleted. 7. Apply patch, reload the page 8. Click Delete, click OK in the confirmation alert 9. Click Search with no parameters, just to make sure the message about "Sorry, but there are no results for your search" really truly means that your invoice was deleted and now you don't have any invoices Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173886|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174045&action=edit Bug 38325: Cannot delete invoice while viewing it The link to delete while viewing an individual invoice needs to be updated to use submit-form-link so it can POST with op='cud-delete'. Test plan: 1. Home - Acquisitions, click Search with an empty Vendor: input 2. Click Receive shipments, enter a number in the Vendor invoice input, click Next 3. In the left sidebar, click Invoices, click Search without any parameters 4. In the row for your invoice, click the invoice number link 5. Next to the Save button, click the Delete link, click OK in the confirmation alert 6. You'll see the page reload, and the URL change to include ?op=delete, but your invoice remains undeleted. 7. Apply patch, reload the page 8. Click Delete, click OK in the confirmation alert 9. Click Search with no parameters, just to make sure the message about "Sorry, but there are no results for your search" really truly means that your invoice was deleted and now you don't have any invoices Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Needs documenting --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not for 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38325 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- No interface changes to document, just a bugfix. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org