[Bug 38200] New: Remove dead code to delete authorities in authorities/authorities.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 Bug ID: 38200 Summary: Remove dead code to delete authorities in authorities/authorities.pl Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: phil@chetcolibrary.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org authorities/authorities.pl (the authority editor) has an op cud-delete. Hypothetically, it might have been run at some point before the template transition 13 years ago: somewhere between the initial commit of authorities support 20 years ago and then, the editor might have had a delete button that called it. Since then, it hasn't had one. You can see that it hasn't been run in the past 8 years by looking at the use block: before 8 years ago we had use C4::AuthoritiesMarc; but since then we've used specific exported things from it, never including DelAuthority. You might think it was used by deleting authorities in auth_finder.pl, a rather odd thing to have, but no: from the start, when it was auth_linker.pl, it has not had UI to delete. It did have the param nonav which it used to send people back to auth_linker after they created an authority, but since it was also passing myindex, the index of the bib field where auth_linker was supposed to put the results of its lookup, now the existence of that says it's an authority created from auth_finder and nonav is dead, too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 172940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172940&action=edit Bug 38200: Remove dead code to delete authorities in authorities/authorities.pl It has probably never been used. There's no sign of any UI to delete from the authority editor or auth_finder in the last 13 years of templates, and it was unused when it landed; the patch that actually made the first patch work, a month later, put deleting authorities in authorities_home.pl, where it has been ever since. It certainly hasn't been used since bug 17600 landed in 2021, since it doesn't 'use C4::AuthoritiesMarc qw( DelAuthority );' and so if you try to use it you just get an error for your trouble. Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 yanjun.li@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 yanjun.li@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172940|0 |1 is obsolete| | --- Comment #2 from yanjun.li@bywatersolutions.com --- Created attachment 173171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173171&action=edit Bug 38200: Remove dead code to delete authorities in authorities/authorities.pl It has probably never been used. There's no sign of any UI to delete from the authority editor or auth_finder in the last 13 years of templates, and it was unused when it landed; the patch that actually made the first patch work, a month later, put deleting authorities in authorities_home.pl, where it has been ever since. It certainly hasn't been used since bug 17600 landed in 2021, since it doesn't 'use C4::AuthoritiesMarc qw( DelAuthority );' and so if you try to use it you just get an error for your trouble. Sponsored-by: Chetco Community Public Library Signed-off-by: Yanjun Li <yanjun.li@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173171|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173193&action=edit Bug 38200: Remove dead code to delete authorities in authorities/authorities.pl It has probably never been used. There's no sign of any UI to delete from the authority editor or auth_finder in the last 13 years of templates, and it was unused when it landed; the patch that actually made the first patch work, a month later, put deleting authorities in authorities_home.pl, where it has been ever since. It certainly hasn't been used since bug 17600 landed in 2021, since it doesn't 'use C4::AuthoritiesMarc qw( DelAuthority );' and so if you try to use it you just get an error for your trouble. Sponsored-by: Chetco Community Public Library Signed-off-by: Yanjun Li <yanjun.li@bywatersolutions.com> Amended-by: Jonathan Druart tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not backport to 23.11.x for stability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38200 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Removes code which has never done anything, nothing to document. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org