[Bug 17601] New: Regression: Incomplete CSS update introduced by Bug 14610
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 Bug ID: 17601 Summary: Regression: Incomplete CSS update introduced by Bug 14610 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 14610 Bug 14610 revised staff-global.css so that the "holdcount" class was renamed "number_box." That's good. It's good to have something more generic since the class is used in multiple places. The problem is that there are still several instances of the "holdcount" class in the templates which should have been updated at the same time to say "number_box." Those instances are now unstyled. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 [Bug 14610] Add ability to place article requests in Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57422&action=edit Bug 17601 - Regression: Incomplete CSS update introduced by Bug 14610 Bug 14610 revised staff-global.css so that the "holdcount" class was renamed "number_box." That's good. It's good to have something more generic since the class is used in multiple places. The problem is that there are still several instances of the "holdcount" class in the templates which should have been updated at the same time to say "number_box." Those instances are now unstyled. Test Plan: 1) Apply this patch 2) Check that the holds count on catalogue/detail.pl is styled 3) Check that the patron modifications count on members/member.pl is styled 4) Check that the pending comments count on tools/tools-home.pl is styled 5) Check that the pending tags count on tools/tools-home.pl is styled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 Chris Kirby <chris.kirby@ilsleypubliclibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.kirby@ilsleypubliclib | |rary.org --- Comment #2 from Chris Kirby <chris.kirby@ilsleypubliclibrary.org> --- So far, I am finding that the templates have indeed updated so that the "holdcount" class has been replaced by "number_box." But pending comments count on tools/tools-home.pl and also (the other instances) does have a border around the number or a background-color, whereas "holdcount" did. Is this what is expected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 --- Comment #3 from Chris Kirby <chris.kirby@ilsleypubliclibrary.org> --- (In reply to Chris Kirby from comment #2)
So far, I am finding that the templates have indeed updated so that the "holdcount" class has been replaced by "number_box." But pending comments count on tools/tools-home.pl (and also the other instances) does have a border around the number or a background-color, whereas "holdcount" did. Is this what is expected?
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 --- Comment #4 from Chris Kirby <chris.kirby@ilsleypubliclibrary.org> --- 1)Applied patch in this patch in a sandbox (http://pro.user10-koha.sandbox.biblibre.eu/). I also tested the existing behavior on master in (http://pro.user09-koha.sandbox.biblibre.eu/). Created a hold on an item, signed into the OPAC as a patron and modified patron information; in the OPAC added a tag to a title. in the OPAC, added a comment to a title. In the staff client, I checked the following: 2)Checked that the holds count on catalogue/detail.pl. It has been renamed "number_box" but does not appear to be styled. 3) Check that the patron modifications count on members/member.pl. It has been renamed "number_box" but does not appear to be styled. 4) Check that the pending comments count on tools/tools-home.pl. It has been renamed "number_box" but does not appear to be styled. 5) Check that the pending tags count on tools/tools-home.pl. It has been renamed "number_box" but does not appear to be styled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 Chris Kirby <chris.kirby@ilsleypubliclibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57422|0 |1 is obsolete| | --- Comment #5 from Chris Kirby <chris.kirby@ilsleypubliclibrary.org> --- Created attachment 57466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57466&action=edit Bug 17601 - Regression: Incomplete CSS update introduced by Bug 14610 Bug 14610 revised staff-global.css so that the "holdcount" class was renamed "number_box." That's good. It's good to have something more generic since the class is used in multiple places. The problem is that there are still several instances of the "holdcount" class in the templates which should have been updated at the same time to say "number_box." Those instances are now unstyled. Test Plan: 1) Apply this patch 2) Check that the holds count on catalogue/detail.pl is styled 3) Check that the patron modifications count on members/member.pl is styled 4) Check that the pending comments count on tools/tools-home.pl is styled 5) Check that the pending tags count on tools/tools-home.pl is styled Signed-off-by: Chris Kirby <christopherlawrencekirby@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 --- Comment #6 from Chris Kirby <chris.kirby@ilsleypubliclibrary.org> --- Signed off (comment 5) after applying patch to my local development environment and observing the expected styling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 Chris Kirby <chris.kirby@ilsleypubliclibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57466|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 57611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57611&action=edit Bug 17601 - Regression: Incomplete CSS update introduced by Bug 14610 Bug 14610 revised staff-global.css so that the "holdcount" class was renamed "number_box." That's good. It's good to have something more generic since the class is used in multiple places. The problem is that there are still several instances of the "holdcount" class in the templates which should have been updated at the same time to say "number_box." Those instances are now unstyled. Test Plan: 1) Apply this patch 2) Check that the holds count on catalogue/detail.pl is styled 3) Check that the patron modifications count on members/member.pl is styled 4) Check that the pending comments count on tools/tools-home.pl is styled 5) Check that the pending tags count on tools/tools-home.pl is styled Signed-off-by: Chris Kirby <christopherlawrencekirby@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57611|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 57612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57612&action=edit [PASSED QA] Bug 17601 - Regression: Incomplete CSS update introduced by Bug 14610 Bug 14610 revised staff-global.css so that the "holdcount" class was renamed "number_box." That's good. It's good to have something more generic since the class is used in multiple places. The problem is that there are still several instances of the "holdcount" class in the templates which should have been updated at the same time to say "number_box." Those instances are now unstyled. Test Plan: 1) Apply this patch 2) Check that the holds count on catalogue/detail.pl is styled 3) Check that the patron modifications count on members/member.pl is styled 4) Check that the pending comments count on tools/tools-home.pl is styled 5) Check that the pending tags count on tools/tools-home.pl is styled Signed-off-by: Chris Kirby <christopherlawrencekirby@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17601 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Blocked by new feature, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org