[Bug 17545] New: Make "Add biblio" not hidden by language chooser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Bug ID: 17545 Summary: Make "Add biblio" not hidden by language chooser Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 57131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57131&action=edit "Add biblio" hidden behind the language chooser To reproduce: - Make sure more than one language is active for the staff client, so that the language chooser bar shows at the bottom of each page - Do one or more Z39.50 searches, to make sure you have some records in the reservoir - Go to "Cataloging" and do a "Catalog search", so that the reservoir is searched. Make sure your search is broad enough that some results from the reservoir is shown "below the fold" - Scroll to the last result and click on the "Actions" menu - Observe that the last choice in the menu, "Add biblio", is hidden behind the language chooser, and cannot be shown, no matter how hard you try to scroll further down. See also attached image. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- I should add that I have tested this with Koha 16.05.05 and Chromium "53.0.2785.143 Built on Ubuntu , running on Ubuntu 16.04 (64-bit)". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57156&action=edit Bug 17545: Raise z-index for dropdown menus Test plan: 0) Have any additional language instaled 1) Find any page which has some dropdown menu on bottom of content (for example cataloguing search - as it is described in bug report) -> without patch is dropdown menu partially hidden under language chooser bottom bar -> with patch is whole dropdown-menu visible (you may need to scroll down) 2) Try it in diferent browser -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- I can't get this to work. The Chromium developer tools show me that the new z-index has been applied, but the last entry in the menu ("Add biblio") is still hidden behind the language chooser. I think maybe applying the z-index to ".dropdown-menu li" is too deep into the hierarchy? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 57195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57195&action=edit Bug 17545 - Make "Add biblio" not hidden by language chooser This alternate patch changes the menu direction so that it "drops" up instead of down. This avoids the problem of overlapping or being hidden by the language chooser. The disadvantage of this patch is that it is not global. However, I think it's a better long-term solution to the problem. To test, apply the patch and follow the issue description: - Make sure more than one language is active for the staff client, so that the language chooser bar shows at the bottom of each page - Do one or more Z39.50 searches, to make sure you have some records in the reservoir - Go to "Cataloging" and do a "Catalog search", so that the reservoir is searched. Make sure your search is broad enough that some results from the reservoir is shown "below the fold" - Scroll to the last result and click on the "Actions" menu The direction of the menu should be up instead of down. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57195|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 57196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57196&action=edit Bug 17545 [Revised] Make "Add biblio" not hidden by language chooser This alternate patch changes the menu direction so that it "drops" up instead of down. This avoids the problem of overlapping or being hidden by the language chooser. The disadvantage of this patch is that it is not global. However, I think it's a better long-term solution to the problem. To test, apply the patch and follow the issue description: - Make sure more than one language is active for the staff client, so that the language chooser bar shows at the bottom of each page - Do one or more Z39.50 searches, to make sure you have some records in the reservoir - Go to "Cataloging" and do a "Catalog search", so that the reservoir is searched. Make sure your search is broad enough that some results from the reservoir is shown "below the fold" - Scroll to the last result and click on the "Actions" menu The direction of the menu should be up instead of down. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57156|0 |1 is obsolete| | Attachment #57196|0 |1 is obsolete| | --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- Created attachment 57197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57197&action=edit Bug 17545 [Revised] Make "Add biblio" not hidden by language chooser This alternate patch changes the menu direction so that it "drops" up instead of down. This avoids the problem of overlapping or being hidden by the language chooser. The disadvantage of this patch is that it is not global. However, I think it's a better long-term solution to the problem. To test, apply the patch and follow the issue description: - Make sure more than one language is active for the staff client, so that the language chooser bar shows at the bottom of each page - Do one or more Z39.50 searches, to make sure you have some records in the reservoir - Go to "Cataloging" and do a "Catalog search", so that the reservoir is searched. Make sure your search is broad enough that some results from the reservoir is shown "below the fold" - Scroll to the last result and click on the "Actions" menu The direction of the menu should be up instead of down. Signed-off-by: Magnus Enger <magnus@libriotech.no> Popup menus on the cataloging search page now pop up instead of down, which means they avoid being hidden by the language chooser. Mission accimplished! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For me the pull downs still go down instead of up - not sure what's going on there? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57197|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57623&action=edit Bug 17545 [Revised] Make "Add biblio" not hidden by language chooser This alternate patch changes the menu direction so that it "drops" up instead of down. This avoids the problem of overlapping or being hidden by the language chooser. The disadvantage of this patch is that it is not global. However, I think it's a better long-term solution to the problem. To test, apply the patch and follow the issue description: - Make sure more than one language is active for the staff client, so that the language chooser bar shows at the bottom of each page - Do one or more Z39.50 searches, to make sure you have some records in the reservoir - Go to "Cataloging" and do a "Catalog search", so that the reservoir is searched. Make sure your search is broad enough that some results from the reservoir is shown "below the fold" - Scroll to the last result and click on the "Actions" menu The direction of the menu should be up instead of down. Signed-off-by: Magnus Enger <magnus@libriotech.no> Popup menus on the cataloging search page now pop up instead of down, which means they avoid being hidden by the language chooser. Mission accimplished! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17545 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org