[Bug 15233] New: Cataloging subfield editors: Clean up html and streamline text for better translatability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Bug ID: 15233 Summary: Cataloging subfield editors: Clean up html and streamline text for better translatability Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Remove bold markup from explanatory text in auth_subfields_structure.tt and make it the same as in marc_subfields_structure.tt for better translatibility. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 45095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45095&action=edit Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability This patch removes bold markup from explanatory text in auth_subfields_structure.tt and makes it the same as in marc_subfields_structure.tt for better translatibility. To test: - Apply patch - Verify that string changes make sense and that the explanatory text is the same in both files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45095|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45109&action=edit [SIGNED-OFF]Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability This patch removes bold markup from explanatory text in auth_subfields_structure.tt and makes it the same as in marc_subfields_structure.tt for better translatibility. To test: - Apply patch - Verify that string changes make sense and that the explanatory text is the same in both files. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok for translation purposes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- -<p>The column Koha field shows that the subfield is linked with a Koha field. Koha can manage a MARC interface, or a Koha interface. This link ensures that both DB are synchronized, thus you can change from a MARC to a Koha interface easily.</p> +<p>The column 'Koha field' shows that the subfield is linked with a Koha field. Koha can manage a MARC interface, and a Koha interface. This link ensures that both DB are synchronized.</p> Why did you remove the end of the sentence? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #4 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #3)
-<p>The column Koha field shows that the subfield is linked with a Koha field. Koha can manage a MARC interface, or a Koha interface. This link ensures that both DB are synchronized, thus you can change from a MARC to a Koha interface easily.</p>
+<p>The column 'Koha field' shows that the subfield is linked with a Koha field. Koha can manage a MARC interface, and a Koha interface. This link ensures that both DB are synchronized.</p>
Why did you remove the end of the sentence?
Oh, sorry, that was a mistake. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #5 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #3)
-<p>The column Koha field shows that the subfield is linked with a Koha field. Koha can manage a MARC interface, or a Koha interface. This link ensures that both DB are synchronized, thus you can change from a MARC to a Koha interface easily.</p>
+<p>The column 'Koha field' shows that the subfield is linked with a Koha field. Koha can manage a MARC interface, and a Koha interface. This link ensures that both DB are synchronized.</p>
Why did you remove the end of the sentence?
Ah, now I see what I did. It was not a mistake. Both texts have the same meaning, but a different wording. That's why I re-used the text from auth_subfields_structure.tt in marc_subfields_structure.tt I propose to switch back to signed-off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |nicole@bywatersolutions.com --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nicole, do you agree to remove "thus you can change from a MARC to a Koha interface easily."? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- Yes, I agree, but I have another question. What does 'Koha can manage a MARC interface, and a Koha interface.' mean? What is a koha interface? Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #8 from Marc Véron <veron@veron.ch> --- I took the text as it was. I propose to remove the sentence "Koha can manage a MARC interface, and a Koha interface. This link ensures that both DB are synchronized."(In reply to Nicole C. Engard from comment #7)
Yes, I agree, but I have another question. What does 'Koha can manage a MARC interface, and a Koha interface.' mean? What is a koha interface?
Nicole
I took the text as it was. What about removing the sentence the whole sentence? ("Koha can manage a MARC interface, and a Koha interface. This link ensures that both DB are synchronized.") -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #9 from Nicole C. Engard <nengard@gmail.com> --- Makes perfect sense to me. Delete away! :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 45416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45416&action=edit Bug 15233: (followup) Remove 2 sentences. This patch removes 2 sentences (see comment #8) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #11 from Marc Véron <veron@veron.ch> --- I hope it's OK to switch back to "Signed-off". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45416|0 |1 is obsolete| | --- Comment #12 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45417&action=edit [SIGNED-OFF]Bug 15233: (followup) Remove 2 sentences. This patch removes 2 sentences (see comment #8) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45109|0 |1 is obsolete| | Attachment #45417|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45442&action=edit Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability This patch removes bold markup from explanatory text in auth_subfields_structure.tt and makes it the same as in marc_subfields_structure.tt for better translatibility. To test: - Apply patch - Verify that string changes make sense and that the explanatory text is the same in both files. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok for translation purposes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45443&action=edit Bug 15233: (followup) Remove 2 sentences. This patch removes 2 sentences (see comment #8) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45442|0 |1 is obsolete| | --- Comment #15 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46041&action=edit Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability This patch removes bold markup from explanatory text in auth_subfields_structure.tt and makes it the same as in marc_subfields_structure.tt for better translatibility. To test: - Apply patch - Verify that string changes make sense and that the explanatory text is the same in both files. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok for translation purposes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45443|0 |1 is obsolete| | --- Comment #16 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46042&action=edit Bug 15233: (followup) Remove 2 sentences. This patch removes 2 sentences (see comment #8) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #17 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to master - thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Severity|enhancement |trivial Status|Pushed to Master |Pushed to Stable --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #19 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org