http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 45087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45087&action=edit Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations Some of the strings in Home > Tools > Import patrons contain html tags and therefore are splitted in the translation tool. This makes it nearly impossible to create correct translations from the partial strings. Additinally, the notes for Extended patron attributes never displayed (due to a bug). To test: - Apply patch - Enable Syspref 'ExtendedPAtronAttributes' - Go to Home > Tools > Import patrons and verify, that the Notes at the right of the screen make sense -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de, | |nicole@bywatersolutions.com --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Katrin, Nicole, Could we get your opinion on this change please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Changes look good to me - I like the clearer structure. I think I found a small mistake, a stray </b> tag: <ul><li>Example 1: INSTID:12345,LANG:fr</b></li><li> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45343|0 |1 is obsolete| | --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45346&action=edit [SIGNED-OFF]Bug 15231: (followup) Remove stray </b> tag This patch removes a stray </b> tag (see comment #4) and a superfluous blank. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45441&action=edit Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations Some of the strings in Home > Tools > Import patrons contain html tags and therefore are splitted in the translation tool. This makes it nearly impossible to create correct translations from the partial strings. Additinally, the notes for Extended patron attributes never displayed (due to a bug). To test: - Apply patch - Enable Syspref 'ExtendedPAtronAttributes' - Go to Home > Tools > Import patrons and verify, that the Notes at the right of the screen make sense Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Split html tags removed, notes at right side it displayed correctly Bug 15231: (followup) Remove stray </b> tag This patch removes a stray </b> tag (see comment #4) and a superfluous blank. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Squash the 2 patches -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45092|0 |1 is obsolete| | --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46037&action=edit Bug 15301: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence The file intranet-tmpl/prog/en/modules/circ/branchtransfers.tt contains two ambiguous words 'to' and a sentence splitted up by html tags, leading to weird translations. Example in German: "Sie können keine Exemplare aus itemtype transferieren BK für: Airfield" To test: - Apply patch - Set up transfer policies for item types and collection codes in Home > Administration > Set library checkin and transfer policy Make sure that you have rules that deny and others that allow transfers - Verify that syspref 'UseBranchTransferLimits' is set to 'Enforce' - Set 'BranchTransferLimitTypes' to 'item type' - Go to Home > Circulation > Transfers - Transfer an item that is allowed for item type - Verify that the table of transferred items displays information about Item type, Collection code and Destination - Transfer an item that is not allowed for the item type - Verify that the information about not allowing the transfer displays properly and is meaningfull - Set 'BranchTransferLimitTypes' to 'collection code' - Repeat the transfer steps above for allowed / not allowed collection code (Amended to add ids to table and 8 columns, see comment #2) (Amended for comment #5) Followup for comment #8 Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 --- Comment #10 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46039&action=edit Bug 15231: (followup) Remove stray </b> tag This patch removes a stray </b> tag (see comment #4) and a superfluous blank. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46037|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed in 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.