[Bug 42973] New: Additional contents ordering ignores "Appear in position" when sorting news
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 Bug ID: 42973 Summary: Additional contents ordering ignores "Appear in position" when sorting news Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Bug 39027 changed the default ordering of news items to use the publication date (newest first). However, this change no longer respects the manual "Appear in position" value (additional_content.number). Previously, libraries could assign a position number to pin or manually order specific news items. After Bug 39027, news items are always ordered by publication date, regardless of whether a manual position has been assigned. To recreate: 1. Create two or more news items. 2. Assign an "Appear in position" value to one of the items (for example, 1). 3. Give another news item a more recent publication date. 4. View the news on the OPAC or staff interface. 5. Notice that the newer item is displayed first instead of the item with the assigned position. Expected behavior: If a news item has an "Appear in position" value, that value should take precedence over the default publication date ordering. News items without a manual position should continue to be ordered by publication date (newest first). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 201389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201389&action=edit Bug 42973: Restore manual ordering for news To test: 1. Create four OPAC news items: - "Pinned news item" with "Appear in position" = 1 and an older publication date. - "Newest unnumbered news item" with no position and the newest publication date. - "Middle unnumbered news item" with no position and an intermediate publication date. - "Oldest unnumbered news item" with no position and the oldest publication date. 2. View the OPAC main page. 3. Confirm the news items are ordered by publication date, with the newest item first. Apply the patch. 4. Reload the OPAC main page. 5. Confirm the manually positioned news item appears first. 6. Confirm the remaining news items are ordered by publication date descending. 7. Confirm news items without an "Appear in position" value continue to display newest first. 8. Sign off and have a wonderful day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- While working on the follow-up, I confirmed that the staff interface uses the same Koha::AdditionalContents->search_for_display() method (mainpage.pl) as the OPAC. Because of that, restoring the ordering logic in Koha::AdditionalContents->search_for_display() updates the ordering for both the OPAC and the staff interface. I tested both: OPAC main page: manually positioned news items appear first, followed by unnumbered news ordered by publication date (newest first). Staff main page: the same ordering is applied. No additional changes to mainpage.pl were required, as both interfaces share the same search method. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 201398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201398&action=edit Bug 42973: Unit test Added a unit test to confirm that search_for_display orders manually positioned news first, followed by unnumbered news by publication date descending. Test passes: prove t/db_dependent/Koha/AdditionalContents.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201389|0 |1 is obsolete| | Attachment #201398|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 201409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201409&action=edit Bug 42973: Restore manual ordering for news To test: 1. Create four OPAC news items: - "Pinned news item" with "Appear in position" = 1 and an older publication date. - "Newest unnumbered news item" with no position and the newest publication date. - "Middle unnumbered news item" with no position and an intermediate publication date. - "Oldest unnumbered news item" with no position and the oldest publication date. 2. View the OPAC main page. 3. Confirm the news items are ordered by publication date, with the newest item first. Apply the patch. 4. Reload the OPAC main page. 5. Confirm the manually positioned news item appears first. 6. Confirm the remaining news items are ordered by publication date descending. 7. Confirm news items without an "Appear in position" value continue to display newest first. 8. Sign off and have a wonderful day! Signed-off-by: Gretchen Maxeiner <MaxeinerGL@gcc.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 201410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201410&action=edit Bug 42973: Unit test Added a unit test to confirm that search_for_display orders manually positioned news first, followed by unnumbered news by publication date descending. Test passes: prove t/db_dependent/Koha/AdditionalContents.t Signed-off-by: Gretchen Maxeiner <MaxeinerGL@gcc.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39027 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |domm@plix.at |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 Tom Rice <tom.rice@cityofcarrollton.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tom.rice@cityofcarrollton.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Depends on| |39027 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39027 [Bug 39027] News are ordered with oldest on top -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|domm@plix.at |dcook@prosentient.com.au CC| |dcook@prosentient.com.au --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Taking over this one as I'm going to apply it locally urgently anyway... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Looking at the unit test... it looks like we only test for number 1. We don't test number 0 or number 2... Previously, before bug 39027 it would've done the following: NULL NULL 0 1 But now with bug 39027 and bug 42973... it's: 0 1 NULL NULL That's probably OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201409|0 |1 is obsolete| | Attachment #201410|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Created attachment 203399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203399&action=edit Bug 42973: Restore manual ordering for news To test: 1. Create four OPAC news items: - "Pinned news item" with "Appear in position" = 1 and an older publication date. - "Newest unnumbered news item" with no position and the newest publication date. - "Middle unnumbered news item" with no position and an intermediate publication date. - "Oldest unnumbered news item" with no position and the oldest publication date. 2. View the OPAC main page. 3. Confirm the news items are ordered by publication date, with the newest item first. Apply the patch. 4. Reload the OPAC main page. 5. Confirm the manually positioned news item appears first. 6. Confirm the remaining news items are ordered by publication date descending. 7. Confirm news items without an "Appear in position" value continue to display newest first. 8. Sign off and have a wonderful day! Signed-off-by: Gretchen Maxeiner <MaxeinerGL@gcc.edu> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Created attachment 203400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203400&action=edit Bug 42973: Unit test Added a unit test to confirm that search_for_display orders manually positioned news first, followed by unnumbered news by publication date descending. Test passes: prove t/db_dependent/Koha/AdditionalContents.t Signed-off-by: Gretchen Maxeiner <MaxeinerGL@gcc.edu> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxeinergl@gcc.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate, | |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Ended up backporting this one to 25.11 locally myself as I'm getting so many complaints about this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords|rel_25_11_candidate, | |rel_26_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42973 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org