[Bug 25234] New: Update OPAC search results pagination with aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Bug ID: 25234 Summary: Update OPAC search results pagination with aria labels Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 23003 For better accessibility I would like to add aria labels to the include file which generates OPAC search results pagination. See articles: https://a11y-style-guide.com/style-guide/section-navigation.html#kssref-navi... https://www.a11ymatters.com/pattern/pagination/ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103423&action=edit Bug 25234: Update OPAC search results pagination with aria labels This patch updates the include file which generates OPAC search results pagination so that it has better semantic markup and correct aria labels. To test, apply the patch and do a search in the OPAC which will return multiple pages of search results. View the source to confirm the markup changes: - <nav> instead of <div> surrounding the list of links, with a corresponding aria label - Navigation links should have labels indicating which page in the results they point to. - The current link should have "aria-disabled," and "aria-current" set. - Numbered links should have aria labels that indicate their number. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- I was testing this and caught one small typo that existed before this change: <a clas="page-num current" should be <a class="page-num current" Not 100% sure if we should fix that here or in a separate bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103423|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103436&action=edit Bug 25234: Update OPAC search results pagination with aria labels This patch updates the include file which generates OPAC search results pagination so that it has better semantic markup and correct aria labels. To test, apply the patch and do a search in the OPAC which will return multiple pages of search results. View the source to confirm the markup changes: - <nav> instead of <div> surrounding the list of links, with a corresponding aria label - Navigation links should have labels indicating which page in the results they point to. - The current link should have "aria-disabled," and "aria-current" set. - Numbered links should have aria labels that indicate their number. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lucas Gass from comment #2)
Not 100% sure if we should fix that here or in a separate bug?
Easy enough to fix up the patch. Thanks for noticing it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103436|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 103609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103609&action=edit Bug 25234: Update OPAC search results pagination with aria labels This patch updates the include file which generates OPAC search results pagination so that it has better semantic markup and correct aria labels. To test, apply the patch and do a search in the OPAC which will return multiple pages of search results. View the source to confirm the markup changes: - <nav> instead of <div> surrounding the list of links, with a corresponding aria label - Navigation links should have labels indicating which page in the results they point to. - The current link should have "aria-disabled," and "aria-current" set. - Numbered links should have aria labels that indicate their number. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103609|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103639&action=edit Bug 25234: Update OPAC search results pagination with aria labels This patch updates the include file which generates OPAC search results pagination so that it has better semantic markup and correct aria labels. To test, apply the patch and do a search in the OPAC which will return multiple pages of search results. View the source to confirm the markup changes: - <nav> instead of <div> surrounding the list of links, with a corresponding aria label - Navigation links should have labels indicating which page in the results they point to. - The current link should have "aria-disabled," and "aria-current" set. - Numbered links should have aria labels that indicate their number. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Always awesome to see some movement on accessibility, thanks Owe :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #9 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org