https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25281 [Bug 25281] Use modal confirmation when deleting a list in the OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103696|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25280 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103701&action=edit Bug 25280: Use modal confirmation when removing share from a list in the OPAC This patch updates the process of removing a share from a list in the OPAC so that the confirmation request shown to the user is a Bootstrap modal instead of a plain JavaScript confirm dialog. To test you should have the OpacAllowSharingPrivateLists enabled. - Log in to the OPAC as a user who has multiple private lists. - Share two or more lists with another user in the system. - Accept the list shares on behalf of the other user and log in to the OPAC as that user. - In the list of that user's lists, test the process of removing a share: - Clicking "Remove share" should trigger a modal which asks if you want to remove sharing. It should show the name of the list in question. - Test the funcionality of both the "No" and "Yes" options. - Confirm that the "Remove share" button works correctly for any of multiple lists. - View the contents of a list which has been shared with this user. - Test the "Remove share" button at the top of the list's contents. - The same confirmation dialog should be triggered. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25280 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103701|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 103702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103702&action=edit Bug 25280: Use modal confirmation when removing share from a list in the OPAC This patch updates the process of removing a share from a list in the OPAC so that the confirmation request shown to the user is a Bootstrap modal instead of a plain JavaScript confirm dialog. To test you should have the OpacAllowSharingPrivateLists enabled. - Log in to the OPAC as a user who has multiple private lists. - Share two or more lists with another user in the system. - Accept the list shares on behalf of the other user and log in to the OPAC as that user. - In the list of that user's lists, test the process of removing a share: - Clicking "Remove share" should trigger a modal which asks if you want to remove sharing. It should show the name of the list in question. - Test the funcionality of both the "No" and "Yes" options. - Confirm that the "Remove share" button works correctly for any of multiple lists. - View the contents of a list which has been shared with this user. - Test the "Remove share" button at the top of the list's contents. - The same confirmation dialog should be triggered. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25280 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103702|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103714&action=edit Bug 25280: Use modal confirmation when removing share from a list in the OPAC This patch updates the process of removing a share from a list in the OPAC so that the confirmation request shown to the user is a Bootstrap modal instead of a plain JavaScript confirm dialog. To test you should have the OpacAllowSharingPrivateLists enabled. - Log in to the OPAC as a user who has multiple private lists. - Share two or more lists with another user in the system. - Accept the list shares on behalf of the other user and log in to the OPAC as that user. - In the list of that user's lists, test the process of removing a share: - Clicking "Remove share" should trigger a modal which asks if you want to remove sharing. It should show the name of the list in question. - Test the funcionality of both the "No" and "Yes" options. - Confirm that the "Remove share" button works correctly for any of multiple lists. - View the contents of a list which has been shared with this user. - Test the "Remove share" button at the top of the list's contents. - The same confirmation dialog should be triggered. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25280 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.