https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140048&action=edit Bug 31503: Use patron->consent in opac-patron-consent Includes a few small additional changes in template: [1] op == save (more generic) [2] agreed/disagreed replaced by 1/0 [3] toggling display of consent_info paragraph Test plan: Enable GDPR_Policy. Test adding/removing consent. Check what happens with alert, consent_info paragraph and save button. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140050&action=edit Bug 31503: Make opac-patron-consent more generic We now allow multiple consent types as defined under AV (read: authorised values) category 'PATRON_CONSENT'. The description is used on the form too. This is the base patch for multiple consents. We can do some more polishing on a follow-up or another report even. In order to simplify the alert for GDPR was moved to the description text. Note that we could move this also to a AC HTML block at some point. Test plan: First check the form without PATRON_CONSENT category defined. Add AV category PATRON_CONSENT. Add GDPR_PROCESSING and another one (e.g. NEWSLETTER). Verify that you can toggle consent/dissent and that everything is saved correctly. Note only a real change updates the timestamp. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Groundwork for 20380 (mail |Allow several consent types |consent) |on the consents tab of OPAC | |account page Component|Architecture, internals, |OPAC |and plumbing | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140080&action=edit Bug 31503: Adjust db column patron_consent.type We want to control this field now via authorised values. An ENUM is too restrictive. A foreign key on the values of authorised_value for category 'PATRON_CONSENT' is not possible. This will do for now. Test plan: Run dbrev. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140048|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140082&action=edit Bug 31503: Use patron->consent in opac-patron-consent Includes a few small additional changes in template: [1] op == save (more generic) [2] agreed/disagreed replaced by 1/0 [3] toggling display of consent_info paragraph Test plan: Enable GDPR_Policy. Test adding/removing consent. Check what happens with alert, consent_info paragraph and save button. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140050|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140084&action=edit Bug 31503: Make opac-patron-consent more generic We now allow multiple consent types as defined under AV (read: authorised values) category 'PATRON_CONSENT'. The description is used on the form too. This is the base patch for multiple consents. We can do some more polishing on a follow-up or another report even. In order to simplify the alert for GDPR was moved to the description text. Note that we could move this also to a AC HTML block at some point. Test plan: First check the form without PATRON_CONSENT category defined. Add AV category PATRON_CONSENT. Add GDPR_PROCESSING and another one (e.g. NEWSLETTER). Verify that you can toggle consent/dissent and that everything is saved correctly. Note only a real change updates the timestamp. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31509 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140083|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140088&action=edit Bug 31503: Add $av_cat->values Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140085|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140090&action=edit Bug 31503: (Experimental) Configurable consent text This patch allows you to add title and content from the Additional Contents module but it is still slightly experimental since we depend on setting the code column to a value that is not yet supported. Will open a report for that. Note however that the template contains a fallback in case you might not be able to add contents yet. Test plan: [1] Add a NEWSLETTER value under AV category PATRON_CONSENT. [2] Add a PatronConsent record under html customizations. Only add title and content for Default. [3] Change code via SQL (awaiting further AC development): update additional_contents set code='PatronConsent_NEWSLETTER' where location='PatronConsent' and idnew=[YOUR_ID] Note: YOUR_ID refers to the record you added. After this change, you will be able to add translations under Additional contents. The code will be copied. [4] Finally, check patron consent page for your text. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Having another look here -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140080|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140666&action=edit Bug 31503: Adjust db column patron_consent.type We want to control this field now via authorised values. An ENUM is too restrictive. A foreign key on the values of authorised_value for category 'PATRON_CONSENT' is not possible. This will do for now. Test plan: Run dbrev. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140082|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140668&action=edit Bug 31503: Use patron->consent in opac-patron-consent Includes a few small additional changes in template: [1] op == save (more generic) [2] agreed/disagreed replaced by 1/0 [3] toggling display of consent_info paragraph Test plan: Enable GDPR_Policy. Test adding/removing consent. Check what happens with alert, consent_info paragraph and save button. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140088|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140670&action=edit Bug 31503: Add $av_cat->values Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 140672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140672&action=edit Bug 31503: Configurable consent text Although I planned to implement this via Additional contents (AC), I am using the AV description here after all, since AC does not yet provide enough flexibility. The title on the consents page is constructed from the consent type now still, and the description is from the OPAC description in AV (PATRON_CONSENT). Note: AV allows you to add html in the description, although it was not meant to do so. When we switch to AC later, we will have the possibility of html, languages, title and content. Second note: We still need AV translations too. See Bugzilla. Test plan: [1] Add a NEWSLETTER value under AV category PATRON_CONSENT. [2] Add no OPAC description. Save. Hit OPAC consents page. [3] Add description. Check page again. [4] Add html to description. Check again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The experimental patch with Additional Contents is obsoleted. The feature is not flexible enough yet. Will open another report to move to AC later. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is looking like a great piece of functionality. Couple of things to note: 1) I think I expected these new consent options to appear in the self-registration form alongside the existing gdpr processing consent.. or for something to direct the user to consent to them immediately after registration? 2) I find the exposure of the AV code a on the page a little strange.. Some AV's have been abused to use 'Staff' and 'OPAC' or 'Title' and 'Description'.. perhaps this might be a suitable resolution? I've not dug to deeply yet.. but is there any notification going on anywhere when a consent is later removed? I could imagine a newsletter consent being removed but that being missed by librarians? Otherwise, I really like this enhancement. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20380 Depends on|20380 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20380 [Bug 20380] [OMNIBUS] Email consent patron opt-in tracking for anti-spam legislation -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140667|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141217&action=edit Bug 31503: Add $patron->consent Test plan: Run t/db_dependent/Koha/Patron.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140669|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141219&action=edit Bug 31503: Change usermenu condition Test plan: Check if you see Consents tab depending on GDPR_Policy or having PATRON_CONSENT authorised values. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140671|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141221&action=edit Bug 31503: Make opac-patron-consent more generic We now allow multiple consent types as defined under AV (read: authorised values) category 'PATRON_CONSENT'. The description is used on the form too. This is the base patch for multiple consents. We can do some more polishing on a follow-up or another report even. Note: the alert for GDPR was moved to the description. Test plan: First check the form without any PATRON_CONSENT values in AV. Toggle the value of pref GDPR_Policy. Now add GDPR_PROCESSING and another one (e.g. NEWSLETTER). Refresh the OPAC form. Verify that you can toggle consent/dissent and that everything is saved correctly. Note only a real change updates the timestamp. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #29)

The patch no longer applies 8-(..

Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31503: Adjust db column patron_consent.type Applying: Bug 31503: Add $patron->consent Using index info to reconstruct a base tree... M Koha/Patron.pm M t/db_dependent/Koha/Patron.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Patron.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Patron.t Auto-merging Koha/Patron.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 31503: Add $patron->consent

Try again please David. Note that this test now fails on master in subtest 19 - notify_library_of_registration() with and without this patch set. So can be ignored, should be addressed somewhere else. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141216|0 |1 is obsolete| | --- Comment #38 from David Nind <david@davidnind.com> --- Created attachment 141263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141263&action=edit Bug 31503: Adjust db column patron_consent.type We want to control this field now via authorised values. An ENUM is too restrictive. A foreign key on the values of authorised_value for category 'PATRON_CONSENT' is not possible. This will do for now. Test plan: Run dbrev. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141218|0 |1 is obsolete| | --- Comment #40 from David Nind <david@davidnind.com> --- Created attachment 141265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141265&action=edit Bug 31503: Use patron->consent in opac-patron-consent Includes a few small additional changes in template: [1] op == save (more generic) [2] agreed/disagreed replaced by 1/0 [3] toggling display of consent_info paragraph Test plan: Enable GDPR_Policy. Test adding/removing consent. Check what happens with alert, consent_info paragraph and save button. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141220|0 |1 is obsolete| | --- Comment #42 from David Nind <david@davidnind.com> --- Created attachment 141267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141267&action=edit Bug 31503: Add $av_cat->values Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141222|0 |1 is obsolete| | --- Comment #44 from David Nind <david@davidnind.com> --- Created attachment 141269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141269&action=edit Bug 31503: Configurable consent text Although I planned to implement this via Additional contents (AC), I am using the AV description here after all, since AC does not yet provide enough flexibility. The title on the consents page is constructed from the consent type now still, and the description is from the OPAC description in AV (PATRON_CONSENT). Note: AV allows you to add html in the description, although it was not meant to do so. When we switch to AC later, we will have the possibility of html, languages, title and content. Second note: We still need AV translations too. See Bugzilla. Test plan: [1] Add a NEWSLETTER value under AV category PATRON_CONSENT. [2] Add no OPAC description. Save. Hit OPAC consents page. [3] Add description. Check page again. [4] Add html to description. Check again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #46 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #45) Thanks David! Great.

The only thing I noted was: 1. If there is no GPPR_PROCESSING authorized value for PATRON_CONSENT, then in the OPAC > your consents the text displayed is "Consent for GDPR_PROCESSING" with Yes and No options. 2. If a GPR_PROCESSING authorized value is added without any descriptions, then the text in [1] is displayed. 3. Is that text editable, or is that just a default that should be changed/customised by updating the descriptions?

You found a small flaw! I expected AV.GetByCode to return nothing when there is no description in authorised values. But it just returns the code you were looking for.. Will fix that now. The idea was: If there is no description, use the historic template text (not editable). Do you want to change, add something in AV. Or in Additional Contents on a follow-up report. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #48 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #46)

(In reply to David Nind from comment #45)

The idea was: If there is no description, use the historic template text (not editable). Do you want to change, add something in AV. Or in Additional Contents on a follow-up report.

This only talks about GDPR. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #50 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> ---

From IRC:

[15:34] <ashimema> 28 has all good answers.. looks like you've thought about most of it and are planning them for a continuation in the tree of bugs.. [15:34] <ashimema> so don't let me comment block anything 🙂 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #51) Thx for QA

Minor QA tool failure Fixed. Renamed sub, forgot POD header. Adding follow-up.

Why use AV for consents? Looking ahead to bug 20380 it seems the consents will have more options - maybe we could create a 'consent_types' table and use that? Could be done later indeed. Decided here to start with AV and its existing functionality.

Currently too - branch limits are half implemented - I don't see the tab if my only consent is branch limited - but I can force go to the page and see the consent options - was this a plan, or a side effect of choosing AV? Good catch. This is the most serious issue imo. And a blocker. Would addressing this be sufficient for you to pass QA? If not, I will probably have to switch first to Additional contents fixing. And try this again for 23.05 or 23.11.

The description displays in the form, but the title is still the AV - can let go in light of 31570, but it is lees friendly to see "Consent for GDPR_PROCESSING" Correct. Should be addressed later on.

+use constant AV_CONSENT => 'PATRON_CONSENT'; Why not just use the string in the search? Same question for existing: use constant GDPR_PROCESSING => 'GDPR_PROCESSING'; Using constants is good practice. When we add another instance, we can refer to the constant.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I asked myself the same question regards the use of AV here.. and would likely ask it again if it was switch to additional_contents.. it feels like this is a big enough feature tree that starting with a fresh new table instead of trying to plumb extra functionality into other tables is the right way to go... The account types stuff is a clear example of where/why this makes sense.. we added lots of functionality to it really quite quickly once we'd converted from AV to distinct tables.. AV's and Additional Contents end up very restrictive if you are actually trying to tie functionality to this stuff... You talk about future enhancements Marcel.. any change you can write up a tree of bugs to describe where your headed with the big picture? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #56 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I will try to get this further now again with a plugin approach (with the courage of despair..) It will use plugin hook patron_consent_type. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #58 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155001&action=edit Bug 31503: Change usermenu condition, add preference Adds preference OPACCustomConsentTypes. Test plan: Run dbrev. Toggle value of OPACCustomConsentTypes / PrivacyPolicyConsent. Check user page for Consents tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #60 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155003&action=edit DO NOT PUSH: Add example plugin Test plan: Run perl -MKoha::Plugin::Test_Newsletter -e"Koha::Plugin::Test_Newsletter->new->install" Enable OPACCustomConsentTypes. Test consenting and refusing consent on OPAC account page. Run perl -MKoha::Plugin::Test_Newsletter -e"Koha::Plugin::Test_Newsletter->new->uninstall" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #61 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This is another approach to get this further using plugins instead of Authorised values, Additional Contents or database translations. These three areas do currently not offer enough flexibility, translation options, etc. Some developments in that area are stuck for longer time already. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #63 from David Nind <david@davidnind.com> --- Created attachment 155177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155177&action=edit Bug 31503: (follow-up) Update description for system preference Update new OPACCustomConsentType system preference description - bold and capitalize NOTE for consistency, link to PrivacyPolicyConsent system preference for consistency, and other minor changes. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155001|0 |1 is obsolete| | --- Comment #65 from David Nind <david@davidnind.com> --- Created attachment 155179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155179&action=edit Bug 31503: Change usermenu condition, add preference Adds preference OPACCustomConsentTypes. Test plan: Run dbrev. Toggle value of OPACCustomConsentTypes / PrivacyPolicyConsent. Check user page for Consents tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #67 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Apply patches - got a weird message (see [1]). 2. Update database (updatedatabase). 3. Restart everything (flush_memcached and restart_all). 4. Run the tests - these should pass: - prove t/db_dependent/Koha/Patron.t - prove t/db_dependent/AuthorisedValues.t 5. Install and enable the plugin included with the patches: perl -MKoha::Plugin::Test_Newsletter -e"Koha::Plugin::Test_Newsletter->new->install" 6. Restart everything (flush_memcached and restart_all) (I had to do this, otherwise I got an error trace when accessing the OPAC account consents page). 7. Enable the new system preference OPACCustomConsentTypes. 8. Go to the OPAC > [user account] > Consents tab. 9. If the PrivacyPolicyConsent system preference is disabled, then only the Newsletter consent is displayed: 9.1 If you select Yes + Save = "Your consent was registered on [date and timestamp]." 9.2 If you select No + Save = "We registered that you did not consent on [date and timestamp]." 10. The standard PrivacyPolicyConsent system preference options should continue to work as expected if OPACCustomConsentTypes is set to 'Don't allow' (enter a URL in PrivacyPolicyURL, for example http://example.com): 10.1 disabled: No consent tab in OPAC account area) 10.2 enforced: Verify that you can agree (Yes) or disagree (No) with the consent and press Save: . If Yes, a comment is added: "Your consent was registered on [date and timestamp]." . If No, you are logged out. (A comment is added under consents: "We registered that you did not consent on [date and timestamp]." - you only see this if you log in again) 10.3 permissive: Verify that you can agree (Yes) or disagree (No) with the consent and press Save: . If Yes, a comment is added: "Your consent was registered on [date and timestamp]." . If No, a comment is added and you are not logged out: "We registered that you did not consent on [date and timestamp]." 11. If both OPACCustomConsentTypes and PrivacyPolicyConsent system prferences are enabled, in addition to the default 'Privacy policy consent', there is now the Newsletter consent - the options for PrivacyPolicyConsent should continue to work as expected: 11.1 disabled: the default privacy policy consent doesn't appear, but the Newsletter consent (from the plugin) appears as per step 9: 11.2 enforced: same as for step 10.2 for the privacy policy consent, and step 9 for the newsletter consent 11.3 permissive: same as for step 10.3 for the privacy policy consent, and step 9 for the newsletter consent I hope I tested this correctly! I added a follow-up patch to amend the OPACCustomConsentTypes description - note in CAPS and bold (the same as other Notes), and linked to PrivacyPolicyConsent. I had trouble attaching the patches because of the example plugin patch - I hope I haven't screwed anything up! [1] Output I get when applying the patches: git bz apply 31503 Bug 31503 - Allow several consent types on the consents tab of OPAC account page 155000 - Bug 31503: Change patron_consent.type 155001 - Bug 31503: Change usermenu condition, add preference 155002 - Bug 31503: Make opac-patron-consent more generic 155003 - DO NOT PUSH: Add example plugin Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31503: Change patron_consent.type Applying: Bug 31503: Change usermenu condition, add preference Applying: Bug 31503: Make opac-patron-consent more generic Applying: DO NOT PUSH: Add example plugin Moving to starting point Adding bug reference 6b2e2e2 DO NOT PUSH: Add example plugin Cleaning up back to original state on error Traceback (most recent call last): File "/usr/bin/git-bz", line 2834, in <module> applied = do_apply(bug_ref) File "/usr/bin/git-bz", line 1977, in do_apply add_url(bug, commits) File "/usr/bin/git-bz", line 1719, in add_url add_url_to_head_commit(commit, bug) File "/usr/bin/git-bz", line 1682, in add_url_to_head_commit git.commit(file="-", amend=True, _input=input) File "/usr/bin/git-bz", line 197, in f o = git_run(command, *args, **kwargs) File "/usr/bin/git-bz", line 167, in git_run output, error = process.communicate(input) File "/usr/lib/python3.9/subprocess.py", line 1134, in communicate stdout, stderr = self._communicate(input, endtime, timeout) File "/usr/lib/python3.9/subprocess.py", line 1961, in _communicate input_view = memoryview(self._input) TypeError: memoryview: a bytes-like object is required, not 'str' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #69 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155190&action=edit DO NOT PUSH: Add example plugin Test plan: Run perl -MKoha::Plugin::Test_Newsletter -e"Koha::Plugin::Test_Newsletter->new->install" Enable OPACCustomConsentTypes. Test consenting and refusing consent on OPAC account page. Run perl -MKoha::Plugin::Test_Newsletter -e"Koha::Plugin::Test_Newsletter->new->uninstall" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #71 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #67)

I had trouble attaching the patches because of the example plugin patch - I hope I haven't screwed anything up!

Not sure what was going wrong there exactly. But I restored the example patch.

Applying: DO NOT PUSH: Add example plugin Moving to starting point Adding bug reference 6b2e2e2 DO NOT PUSH: Add example plugin Cleaning up back to original state on error Traceback (most recent call last): File "/usr/bin/git-bz", line 2834, in <module> applied = do_apply(bug_ref) File "/usr/bin/git-bz", line 1977, in do_apply add_url(bug, commits) File "/usr/bin/git-bz", line 1719, in add_url add_url_to_head_commit(commit, bug) File "/usr/bin/git-bz", line 1682, in add_url_to_head_commit git.commit(file="-", amend=True, _input=input) File "/usr/bin/git-bz", line 197, in f o = git_run(command, *args, **kwargs) File "/usr/bin/git-bz", line 167, in git_run output, error = process.communicate(input) File "/usr/lib/python3.9/subprocess.py", line 1134, in communicate stdout, stderr = self._communicate(input, endtime, timeout) File "/usr/lib/python3.9/subprocess.py", line 1961, in _communicate input_view = memoryview(self._input) TypeError: memoryview: a bytes-like object is required, not 'str'

Hmm. I can reproduce this too now. Still looking a bit further. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #73 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #71)

Hmm. I can reproduce this too now. Still looking a bit further.

Changed commit title. And cannot reproduce any more.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27378 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #76 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I just hoped that it would come further now, lets see ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- There are some system preference renames not accounted for yet in my local rebase. I'm working on those. I'm not sure I like how we've dropped the alert warning for privacy policy. I think it's important to highlight with that particular feature that the account is deleted and you are logged out if you do not accept and I think the reduction to 'just another consent' like the plugin one's your introducing here is a reduction of functionality. I'll work on a follow-up to keep it moving. Talking system preferences.. do you think libraries will want to independantly turn off the plugin based consents? I think perhaps that the system preference introduced is superflous to requirements. I think I'd just check for the occurrence of any plugins carrying the consent method instead. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155179|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155657&action=edit Bug 31503: Change usermenu condition, add preference Adds preference OPACCustomConsentTypes. Test plan: Run dbrev. Toggle value of OPACCustomConsentTypes / PrivacyPolicyConsent. Check user page for Consents tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155189|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155659&action=edit Bug 31503: (follow-up) Update description for system preference Update new OPACCustomConsentType system preference description - bold and capitalize NOTE for consistency, link to PrivacyPolicyConsent system preference for consistency, and other minor changes. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155191|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155661&action=edit Bug 31503: DO NOT PUSH - Add example plugin Test plan: Run perl -MKoha::Plugin::Test_Newsletter -e"Koha::Plugin::Test_Newsletter->new->install" Enable OPACCustomConsentTypes. Test consenting and refusing consent on OPAC account page. Run perl -MKoha::Plugin::Test_Newsletter -e"Koha::Plugin::Test_Newsletter->new->uninstall" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've added a minor follow-up to restore a little of the original styling and wording from the Privacy Policy feature. Doing the above made me wonder if the 'description' display for plugin generated consent types should not be wrapped in <p>.. allowing for plugin authors to have more control over the final display of the description (for example adding a warning box as we do for the privacy policy one again now). I'm not 100% sure about the Koha::Patron->consent($type) accessor introduced here.. but I can see why you've done it that way and this patchset has been through a few iterations already.. so not a blocker. I'm also not in total agreement around the new system preference introduced. I believe you've done this for performance reasons but I tihnk we could work around it with caching instead.. again.. I don't think this should be a blocker. Finally.. and this one may be more of a blocker. I'm not sure how one would go about translating the description blocks introduced by plugins. We could pass language (or rely on context) through the available types method.. in fact, perhaps that's the answer.. we just leave it to the plugin author to look at lang from context and return the right thing when 'patron_consent_type' is called. I'd love to see this in the example plugin to highlight it's possible and works.. I may add that shortly if I can find a few more minutes. Generally, though, I'm happy with this and feel it can move forward. I'd love one final QA set of eyes.. I'll ask around for you. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155691&action=edit Bug 31503: (follow-up) Add 'feature_enabled' to Koha::Plugins This patch adds a 'feature_enabled' accessor to the Koha::Plugins class. Passing the plugin method name for the plugin feature you're looking for will return a boolean denoting whether any enabled plugins carry said method. Incuded in the patch is an addition to the TT KohaPlugins plugin to enable quick access to this function. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155694&action=edit Bug 31503: Use KohaPlugins.feature_enabled in place of preference lookup -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155657|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155784&action=edit Bug 31503: Change usermenu condition, add preference Adds preference OPACCustomConsentTypes. Test plan: Run dbrev. Toggle value of OPACCustomConsentTypes / PrivacyPolicyConsent. Check user page for Consents tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155659|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155786&action=edit Bug 31503: (follow-up) Update description for system preference Update new OPACCustomConsentType system preference description - bold and capitalize NOTE for consistency, link to PrivacyPolicyConsent system preference for consistency, and other minor changes. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155691|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155788&action=edit Bug 31503: (follow-up) Add 'feature_enabled' to Koha::Plugins This patch adds a 'feature_enabled' accessor to the Koha::Plugins class. Passing the plugin method name for the plugin feature you're looking for will return a boolean denoting whether any enabled plugins carry said method. Included in the patch is an addition to the TT KohaPlugins plugin to enable quick access to this function. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #97 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155790&action=edit Bug 31503: (follow-up) Remove OPACCustomConsentTypes This patch removes all trace of the original OPACCustomConsentTypes preference. We now use Koha::Plugins->feature_enabled in preference. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #99 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #98)

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Ah great Martin. Thanks. Will have a look at your changes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #100 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Does not apply anymore ): -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #102 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- # Failed test 'Expect one type for privacy policy' # at /usr/share/koha/t/db_dependent/Koha/Patron/Consents.t line 59. # got: '2' # expected: '1' # Looks like you failed 1 test of 7. More trouble -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #104 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #102)

# Failed test 'Expect one type for privacy policy' # at /usr/share/koha/t/db_dependent/Koha/Patron/Consents.t line 59. # got: '2' # expected: '1' # Looks like you failed 1 test of 7.

More trouble

Fixed in follow-up (In reply to Marcel de Rooy from comment #103)

WARN t/db_dependent/Koha/Patron/Consents.t WARN tidiness The file is less tidy than before (bad/messy lines before: 9, now: 10)

WARN t/db_dependent/Koha/Plugins/Plugins.t WARN tidiness The file is less tidy than before (bad/messy lines before: 104, now: 110)

Bah, dirty!

Fixed inline -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155783|0 |1 is obsolete| | --- Comment #105 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157117&action=edit Bug 31503: Change patron_consent.type Test plan: Run db rev. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155785|0 |1 is obsolete| | --- Comment #107 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157119&action=edit Bug 31503: Make opac-patron-consent more generic Adds $patron->consent and $consents->available_types. Incorporates them into script/template. Provides two unit tests. Note: A follow-up patch helps you test this with an example plugin. Test plan: Run t/db_dependent/Koha/Patron.t Run t/db_dependent/Koha/Patron/Consents.t Toggle the value of pref PrivacyPolicyConsent and look at OPAC account, tab Consents. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155787|0 |1 is obsolete| | --- Comment #109 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157121&action=edit Bug 31503: (follow-up) Styling and pre-selection This patch restores some of the wording and styling from the original GDPR/Privacy policy feature including highlighting in a warning box. I also remove the jQuery approach for pre-selecting already selected radio options and rely on standard TT processing instead. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155789|0 |1 is obsolete| | --- Comment #111 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157123&action=edit Bug 31503: (follow-up) Use KohaPlugins.feature_enabled This patch switches the code from using Koha.preference('OPACCustomConsentTypes') to using KohaPlugins.feature_enabled('patron_consent_type'). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #113 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157125&action=edit Bug 31503: (QA follow-up) Improve count of available_types Tidied one other line. Test plan: Run t/db_dependent/Koha/Patron/Consents.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #115 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Tomas: Its yours again. Roadmap :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #117 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase ASAP. Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157118|0 |1 is obsolete| | --- Comment #120 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157774&action=edit Bug 31503: Change usermenu condition, add preference Adds preference OPACCustomConsentTypes. Test plan: Run dbrev. Toggle value of OPACCustomConsentTypes / PrivacyPolicyConsent. Check user page for Consents tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157120|0 |1 is obsolete| | --- Comment #122 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157776&action=edit Bug 31503: (follow-up) Update description for system preference Update new OPACCustomConsentType system preference description - bold and capitalize NOTE for consistency, link to PrivacyPolicyConsent system preference for consistency, and other minor changes. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157122|0 |1 is obsolete| | --- Comment #124 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157778&action=edit Bug 31503: (follow-up) Add 'feature_enabled' to Koha::Plugins This patch adds a 'feature_enabled' accessor to the Koha::Plugins class. Passing the plugin method name for the plugin feature you're looking for will return a boolean denoting whether any enabled plugins carry said method. Included in the patch is an addition to the TT KohaPlugins plugin to enable quick access to this function. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> [EDIT] Tidied t/db_dependent/Koha/Plugins/Plugins.t [EDIT] Tidied Koha/Template/Plugin/KohaPlugins.pm Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157124|0 |1 is obsolete| | --- Comment #126 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157780&action=edit Bug 31503: (follow-up) Remove OPACCustomConsentTypes This patch removes all trace of the original OPACCustomConsentTypes preference. We now use Koha::Plugins->feature_enabled in preference. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #128 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157782&action=edit Bug 31503: (QA follow-up) Fix number of tests in rebase Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #130 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #117)

Please rebase ASAP. Thanks!

Done. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #131 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de Resolution|FIXED |--- Status|RESOLVED |Needs documenting --- Comment #133 from Philip Orr <philip.orr@lmscloud.de> --- Switched to "Needs Documenting". Marcel, for documentation of this feature in the manual: Where would interested manual-readers find the example plugin? Can it just be installed like other plugins? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com --- Comment #135 from Aude Charillon <aude.charillon@ptfs-europe.com> --- Could add note to the relevant section of the OPAC chapter, alongside the Privacy policy consent information. Actually, that sub-section doesn't yet exist at https://koha-community.org/manual/latest/en/html/opac.html#your-account It needs to be added! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 --- Comment #137 from Philip Orr <philip.orr@lmscloud.de> --- Marcel, sorry for the noob questions. I don't think I completely understand the test plan. I managed to create and upload the Test_Newsletter plugin, but I still don't have the syspref "OPACCustomConsentTypes". Do I need to do this part of the test plan first? Test plan: Run perl -MKoha::Plugin::Test_Newsletter -e"Koha::Plugin::Test_Newsletter->new->install" Enable OPACCustomConsentTypes. Test consenting and refusing consent on OPAC account page. Run perl -MKoha::Plugin::Test_Newsletter -e"Koha::Plugin::Test_Newsletter->new->uninstall" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/989 --- Comment #139 from Philip Orr <philip.orr@lmscloud.de> --- Documentation finished in the merge request. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38769 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38769 [Bug 38769] Add plugins consent types to OPAC self registration process -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31533 [Bug 31533] Add opt-in/opt-out flags to patron consents -- You are receiving this mail because: You are watching all bug changes.