[Bug 5670] New: Housebound Readers Module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Summary: Housebound Readers Module Change sponsored?: Sponsored Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Patrons AssignedTo: colin.campbell@ptfs-europe.com ReportedBy: colin.campbell@ptfs-europe.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 Created attachment 3038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3038 Initial Spec New module to handle management of circulation to Housebound readers. Ability to record users as housebound, as volunteer delivers and choosers. Link users to individual delivery runs. To aid choosers add a check on issuing to housebound users flagging if title has previously been issued to this user. Work In Progress can be seen on the PTFS-Europe github repository: git://github.com/PTFS-Europe/koha.git Sponsered by Halton Borough Council -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-01-31 13:59:08 UTC --- Colin this is awesome! I just got back from a library that is keeping all patrons in a family on one card to get this kind of functionality. Remember to add the RFC to the wiki using the RFC template. http://wiki.koha-community.org/wiki/Enhancement_Request_Guidelines#RFC_Templ... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Joann Ransom <jransom@library.org.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jransom@library.org.nz --- Comment #2 from Joann Ransom <jransom@library.org.nz> --- Hi Colin, I am really interested in this module. Have you done any more work on this? I'm quite keen to get it working on an Android smart phone so that titles could be checked on the library floor using a wireless connection. Cheers Jo. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|rel_3_2 |master --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Colin, maybe you can give us an update on this development? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Its in production at Halton. I'll pull the patches together ensure they apply against master and post them here for inspection -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #5 from Magnus Enger <magnus@enger.priv.no> --- (In reply to Colin Campbell from comment #4)
Its in production at Halton. I'll pull the patches together ensure they apply against master and post them here for inspection
Any news on this? :-) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se --- Comment #6 from Viktor Sarge <viktor.sarge@regionhalland.se> --- This could be quite useful as many libraries in Sweden have this type of service. I'd be happy to see it as a part of community Koha. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 22162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22162&action=edit Housebound module for v3.6 Conflicts: admin/systempreferences.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 22163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22163&action=edit Added syspref for housebound previously issued items Conflicts: C4/Circulation.pm koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 22164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22164&action=edit Remove unused variables from C4::Housebound localized lexical vars to where they are used Avoided unnecessary method calls Remove a finish No need to interpolate to constant strings Fix some violations of perlstyle -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 22165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22165&action=edit Commit Housebound Updates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Patches submitted on behalf of Colin and Mark... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-10-30 last check this| | --- Comment #12 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Severity|enhancement |new feature -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- This mostly applies cleanly on master. I think what we are missing is unit tests, and maybe we should move to the Koha:: namespace? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Magnus Enger <magnus@enger.priv.no> --- Marking this "Failed QA" based on Chris' comments. See coding guideline "PERL17: Unit tests are required". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Alex Sassmannshausen <alex.sassmannshausen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22162|0 |1 is obsolete| | Attachment #22163|0 |1 is obsolete| | Attachment #22164|0 |1 is obsolete| | Attachment #22165|0 |1 is obsolete| | --- Comment #15 from Alex Sassmannshausen <alex.sassmannshausen@gmail.com> --- Created attachment 26816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26816&action=edit Bug 5670: Housebound Readers Module New module to handle management of circulation to Housebound readers. - Ability to record users as housebound (HB category), volunteers (combined deliverers and choosers, VOL category), deliverers (DELIV category) choosers (CHO category). - Ability to link users to individual delivery runs. - Ability to check on issuing to housebound users flagging if title has previously been issued to this user, to aid choosers. - 'Delivery Days' and 'Delivery Frequencies' are customizable through authorised values ('Day' and 'Frequency' categories respectively. Sponsored by Halton Borough Council * C4/Auth.pm: Add check: useHouseboundModule. * C4/Circulation.pm: use Housebound to check for previous issue. * koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc: add Housebound menu if appropriate. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: add 'previous checkout' warning. * C4/Housebound.pm: new. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: new. * koha-tmpl/intranet-tmpl/prog/en/modules/members/houseboundedit.tt: new. * koha-tmpl/intranet-tmpl/prog/en/modules/members/houseboundinstances.tt: new. * members/housebound.pl: new. * members/houseboundedit.pl: new. * members/houseboundinstances.pl: new. * installer/data/mysql/atomicupdate/housebound_tables.sql: new. - create 'housebound', 'housebound_instance' tables, - create 'HB', 'VOL', 'DELIV', 'CHO' borrower categories, - create sample 'Day', 'Frequency' authorised values, - add 'useHouseboundModule', 'useHouseboundCheckPrevious' syspref. * t/Housebound.t: new. Test plan: - Apply patch. - Run atomic update script. - Optionally, run Unit Tests (t/Housebound.t) - Create at least 1 of each: 'HB', 'VOL', 'DELIV', 'CHO' borrower. - Optionally, add additional authorised values of 'Day' and 'Frequency' categories. - Verify 'useHouseboundModule' & 'useHouseboundCheckPrevious' sysprefs are on. - On the page of the 'HB' borrower, open the new 'Housebound' menu. - create housebound profile + ensure Day and Frequency values are from correct authorised values - create 'housebound instances' (deliveries) + ensure chooser/deliverer lists are populated with VOL, DELIV, CHO borrowers - edit the profile/instances. - delete the profile/instances. - For a borrower with a housebound profile, issue an item, then - return that item - attempt to re-issue that item (you should get a warning) - Switch off 'useHouseboundCheckPrevious', repeat last test - the warning should not appear - Switch off 'useHouseboundModule' - the Housebound menu should disappear - the issue warnings should no longer appear. Largely based on prior work from Mark Gavillet and Colin Campbell. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Alex Sassmannshausen <alex.sassmannshausen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |alex.sassmannshausen@gmail. | |com --- Comment #16 from Alex Sassmannshausen <alex.sassmannshausen@gmail.com> --- Hello, We have now had some time to revise this patch series. The different patches are now replaced with one big patch, which includes unit tests and a polished version of this module. I believe this is ready for sign off and QA. Let me know if you have any queries. Best wishes, Alex -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Joel Sasse <jsasse@plumcreeklibrary.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26816|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27288&action=edit Bug 5670: Housebound Readers Module New module to handle management of circulation to Housebound readers. - Ability to record users as housebound (HB category), volunteers (combined deliverers and choosers, VOL category), deliverers (DELIV category) choosers (CHO category). - Ability to link users to individual delivery runs. - Ability to check on issuing to housebound users flagging if title has previously been issued to this user, to aid choosers. - 'Delivery Days' and 'Delivery Frequencies' are customizable through authorised values ('Day' and 'Frequency' categories respectively. Sponsored by Halton Borough Council * C4/Auth.pm: Add check: useHouseboundModule. * C4/Circulation.pm: use Housebound to check for previous issue. * koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc: add Housebound menu if appropriate. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: add 'previous checkout' warning. * C4/Housebound.pm: new. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: new. * koha-tmpl/intranet-tmpl/prog/en/modules/members/houseboundedit.tt: new. * koha-tmpl/intranet-tmpl/prog/en/modules/members/houseboundinstances.tt: new. * members/housebound.pl: new. * members/houseboundedit.pl: new. * members/houseboundinstances.pl: new. * installer/data/mysql/atomicupdate/housebound_tables.sql: new. - create 'housebound', 'housebound_instance' tables, - create 'HB', 'VOL', 'DELIV', 'CHO' borrower categories, - create sample 'Day', 'Frequency' authorised values, - add 'useHouseboundModule', 'useHouseboundCheckPrevious' syspref. * t/Housebound.t: new. Test plan: - Apply patch. - Run atomic update script. - Optionally, run Unit Tests (t/Housebound.t) - Create at least 1 of each: 'HB', 'VOL', 'DELIV', 'CHO' borrower. - Optionally, add additional authorised values of 'Day' and 'Frequency' categories. - Verify 'useHouseboundModule' & 'useHouseboundCheckPrevious' sysprefs are on. - On the page of the 'HB' borrower, open the new 'Housebound' menu. - create housebound profile + ensure Day and Frequency values are from correct authorised values - create 'housebound instances' (deliveries) + ensure chooser/deliverer lists are populated with VOL, DELIV, CHO borrowers - edit the profile/instances. - delete the profile/instances. - For a borrower with a housebound profile, issue an item, then - return that item - attempt to re-issue that item (you should get a warning) - Switch off 'useHouseboundCheckPrevious', repeat last test - the warning should not appear - Switch off 'useHouseboundModule' - the Housebound menu should disappear - the issue warnings should no longer appear. Largely based on prior work from Mark Gavillet and Colin Campbell. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Works as advertised. A few QA notes though: * HB is already a patron type, your sql fails to create all the patron types if one already exists * In your test plan, the authorised values are *not* optional as stated * The system preferences need to be defined in a pref file, right now they only show up under the local use tab -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 27288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27288 Bug 5670: Housebound Readers Module Review of attachment 27288: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5670&attachment=27288) ----------------------------------------------------------------- Hi Alex, first of all: thx for resubmitting this! I have done a code review and looked at the feature for a bit and have found some problems: 1) Database update I think the database update should be moved from the atomicupdate into a real database update using updatedatabase.pl and modifying kohastructure.sql. You will then also want to add the new system preferences to syspref.sql. For existing installations, new features like this should be turned off by default, for new installations it's debatable, but it would be ok for me to have it turned on by default to show that the feature is there. 2) Templates Owen is going to look at the template side of things, so I am leaving those out of my code review :) 3) Design/Architecture To be honest, I have a problem with the hardcoded patron category codes. One point being, that the codes might already be in use in some libraries with a totally different meaning. It also takes away flexibility and is a bit of a translation issue. Also, if you have patrons that have normal patron accounts, but also serves as choosers and deliverers, you have to add 3 accounts for those. My thought is, that those are not new 'persons', but persons with a new role. I'd suggest looking at other options here - system preferences, patron_attributes, options on patron category level, a new database table. Another thought: if you think of a multi branch library system, the lists of choosers and deliverers will get too long to handle. I'd suggest a search option - there are plenty of examples in Koha: autocomplete patron search, modal windows, etc. used for adding patrons to routing lists, patron lists, finding guarantors, fund owners etc. To me this feels currently a bit more like a plugin, where the heavy use of authorized_values and hardcoded bits would make more sense. But as it seems intended for inclusion in Koha, more heavy code changes and a tighter integration seem favourable. The other way I could see would be implementing the check on 'previously issued' in a general way, and move the other functionality into a plugin. ::: C4/Circulation.pm @@ +845,5 @@
+ # If Housebound patron and useHouseboundCheckPrev syspref is ON + # check for previous issue of item to patron. + if ( C4::Context->preference('useHouseboundCheckPrevious') == 1 + && $borrower->{categorycode} eq 'HB' )
I think we should avoid a hardcoded patron category code (see comment above). ::: C4/Housebound.pm @@ +1,1 @@
+package C4::Housebound;
In general, it would be good if new modules added used DBIX instead of accessing the database directly. I know this code has been around for a while, but it might be worth taking a look at rewriting it. @@ +78,5 @@
+ +=head2 CreateHouseboundDetails + + CreateHouseboundDetails( $borrowernumber, $day, $frequency, + $Itype_quant, $Item_subject, $Item_authors,
I think it's not an official coding guideline, but normally lower case variable names are used in Koha. ::: installer/data/mysql/atomicupdate/housebound_tables.sql @@ +1,2 @@
+CREATE TABLE IF NOT EXISTS `housebound` ( + `hbnumber` int(11) NOT NULL auto_increment,
`hbnumber` int(11) NOT NULL auto_increment, -- Please add some documentation about what the columns and tables are used for (in kohastructure.sql). @@ +4,5 @@
+ `frequency` text, + `borrowernumber` int(11) default NULL, + `Itype_quant` varchar(10) default NULL, + `Item_subject` text, + `Item_authors` text,
I think these should be lower case as well. @@ +30,5 @@
+insert into systempreferences (variable,value,options,explanation,type) values +('useHouseboundModule',1,'','If ON, use the Housebound module','YesNo'); + +insert into systempreferences (variable,value,options,explanation,type) values +('useHouseboundCheckPrevious',1,'','If ON, checks if Housebound patrons have previous issued items to be checked out',
Ideally I'd like to see this functionality on a separate bug, as this seems a feature, that a lot of people would like to see (partial duplicate to bug 6906 and bug 10812). It could be a setting on patron category level. @@ +34,5 @@
+('useHouseboundCheckPrevious',1,'','If ON, checks if Housebound patrons have previous issued items to be checked out', +'YesNo'); + +insert into categories (categorycode, description, enrolmentperiod, upperagelimit, dateofbirthrequired, category_type) +values ('VOL','Housebound volunteer','99','999','1','A'),('HB','Housebound patron','99','999','1','A'),('DELIV','Housebound deliverer','99','999','1','A'),('CHO','Housebound chooser','99','999','1','A');
Hardcoded patron categories - see comments above. @@ +37,5 @@
+insert into categories (categorycode, description, enrolmentperiod, upperagelimit, dateofbirthrequired, category_type) +values ('VOL','Housebound volunteer','99','999','1','A'),('HB','Housebound patron','99','999','1','A'),('DELIV','Housebound deliverer','99','999','1','A'),('CHO','Housebound chooser','99','999','1','A'); + +insert into authorised_values (category, authorised_value, lib) +values ('Day','Example_Day','Change Me In Authorised Values (Day)'), ('Frequency','Example_Freq','Change Me In Authorised Values (Frequency)');
I am not sure if I understand the purpose of Day right, but if it's days of the week it would probably be easier to move those to the template - so they would be translatable and not require additional configuration. I am not sure what goes into Frequency. Authorised value codes should be all uppercase. Also: it seems they are mandatory for the feature to work correctly, so they should go into the sample sql files of the web installer. Please include all translated sample files as well - a non-translated value will still give more of a hint than a feature not working because of unknown reasons. I like the idea of the "Change me in..." here. Especially for the database update. ::: members/housebound.pl @@ +31,5 @@
+ GetCurrentHouseboundInstanceList ); + +my $input = CGI->new(); + +sub nl2br {
I think TT can handle this for you with a filter. We have one example in serials I think, with a formatted note field. But this doesn't seem to be used? @@ +58,5 @@
+my $categorydetail = GetMember( borrowernumber => $borrowernumber); +my $housebound = GetHouseboundDetails($borrowernumber); +my $housebound_instances = GetCurrentHouseboundInstanceList($borrowernumber); + +$template->param(
It would be better to use $tempate->{VARS}->{'...'} ::: members/houseboundinstances.pl @@ +125,5 @@
+ +$template->param( + houseboundview => 'on', + housebound => $housebound, + DHTMLcalendar_dateformat => C4::Dates->DHTMLcalendar(),
We no longer use DHTMLcalendar, new code should be using Koha::DateUtils. ::: t/Housebound.t @@ +2,5 @@
+use strict; +use warnings; + +use C4::Context; +use Test::More tests => 29;
Yay tests! You went the hard route here with Mock, which is good, because they will pass when no database is available. I have checked that they do by turning of the MySQL server before running them. There is also the option to rollback transactions and add db_dependent tests. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- I would be happy to submit a follow-up with some template corrections but I don't want to do so if QA follow-ups will introduce many changes to the templates. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #21 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Hello, Thanks for all your work reviewing this patch. I'm working on the issues raised, and as a first step I have followed Cait's advice, splitting the CheckPreviousIssue functionality into a separate patch (bug 6906). I will be adding to this series in the near future, obsoleting my old patch, but if you are interested in this, please test the attachment at bug 6906 — it is required for this functionality. Let me know if you have any questions or further feedback. Best wishes, Alex -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org