[Bug 9166] New: OPAC needs configuration file for datepicker
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Bug ID: 9166 Summary: OPAC needs configuration file for datepicker Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/opac-reserve.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org Blocks: 7261 In the staff client we have a configuration file for the datepicker which not only lets us load defaults for all instances but also includes the translated text for localization. The OPAC needs this too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This bug blocks Bug 7261 because it is through the configuration file that the CalendarFirstDayOfWeek preference is applied. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13770&action=edit Bug 9166 - OPAC needs configuration file for datepicker This patch adds a configuration include file for the datepicker. This file makes redundant the datepicker initialization in js/script.js, so that section is removed. This change should enable two things: the CalendarFirstDayOfWeek preference should now work in the OPAC, and the calendar should now use the current selected language. To test, try the calendar widget when placing a hold in the OPAC. The CalendarFirstDayOfWeek preference should be respected for Monday and Sunday. Switch languages. The calendar interface labels should reflect the current chosen language. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13770|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13844&action=edit Bug 9166 - OPAC needs configuration file for datepicker This patch adds a configuration include file for the datepicker. This file makes redundant the datepicker initialization in js/script.js, so that section is removed. This change should enable two things: the CalendarFirstDayOfWeek preference should now work in the OPAC, and the calendar should now use the current selected language. To test, try the calendar widget when placing a hold in the OPAC. The CalendarFirstDayOfWeek preference should be respected for Monday and Sunday. Switch languages. The calendar interface labels should reflect the current chosen language. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14010&action=edit Bug 9166 - OPAC needs configuration file for datepicker This patch adds a configuration include file for the datepicker. This file makes redundant the datepicker initialization in js/script.js, so that section is removed. This change should enable two things: the CalendarFirstDayOfWeek preference should now work in the OPAC, and the calendar should now use the current selected language. To test, try the calendar widget when placing a hold in the OPAC. The CalendarFirstDayOfWeek preference should be respected for Monday and Sunday. Switch languages. The calendar interface labels should reflect the current chosen language. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch complexity|--- |Small patch --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: 1- opac-user.tt also has a date picker (to suspend a placed hold). Shouldn't we update this page too ? 2- passes koha-qa.pl If answer to Q1 is "no", owen, you can pass QA, it work well & does the job. If the answer to Q1 is "yes", owen, a follow-up is welcomed ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13844|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14010|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14057&action=edit Bug 9166 [Revised] OPAC needs configuration file for datepicker This patch adds a configuration include file for the datepicker. This file makes redundant the datepicker initialization in js/script.js, so that section is removed. This change should enable two things: the CalendarFirstDayOfWeek preference should now work in the OPAC, and the calendar should now use the current selected language. To test, try the calendar widget when placing a hold in the OPAC. The CalendarFirstDayOfWeek preference should be respected for Monday and Sunday. Switch languages. The calendar interface labels should reflect the current chosen language. Revision adds the configuration include to opac-user as well (required by the suspend holds feature). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14057|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14077&action=edit Bug 9166 [Revised] OPAC needs configuration file for datepicker This patch adds a configuration include file for the datepicker. This file makes redundant the datepicker initialization in js/script.js, so that section is removed. This change should enable two things: the CalendarFirstDayOfWeek preference should now work in the OPAC, and the calendar should now use the current selected language. To test, try the calendar widget when placing a hold in the OPAC. The CalendarFirstDayOfWeek preference should be respected for Monday and Sunday. Switch languages. The calendar interface labels should reflect the current chosen language. Revision adds the configuration include to opac-user as well (required by the suspend holds feature). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> the datepicker plugin works for opac-reserve and opac-user -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14077|0 |1 is obsolete| | --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14168&action=edit Bug 9166 [Revised] OPAC needs configuration file for datepicker This patch adds a configuration include file for the datepicker. This file makes redundant the datepicker initialization in js/script.js, so that section is removed. This change should enable two things: the CalendarFirstDayOfWeek preference should now work in the OPAC, and the calendar should now use the current selected language. To test, try the calendar widget when placing a hold in the OPAC. The CalendarFirstDayOfWeek preference should be respected for Monday and Sunday. Switch languages. The calendar interface labels should reflect the current chosen language. Revision adds the configuration include to opac-user as well (required by the suspend holds feature). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> the datepicker plugin works for opac-reserve and opac-user Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- Could this patch been pushed in 3.10? Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9166 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12137 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org