[Bug 34618] New: Add sort 1 and 2 fields to basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Bug ID: 34618 Summary: Add sort 1 and 2 fields to basket Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: david.roberts@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org It would be useful to be able to use the table column configurator to be able to add sort 1 and sort 2 to the basket view (table id "orders") -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk --- Comment #1 from Ray Delahunty <r.delahunty@arts.ac.uk> --- We use sort1 for 'Subject fund' and sort2 for 'Purchase reason'. To see the subject fund, we currently have to reopen the basket and scroll to the Modify button. This is a clumsy worflow, and having sort1 and sort2 able to be exposed would be very useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Siu Ying Yip <s.yip@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.yip@arts.ac.uk --- Comment #2 from Siu Ying Yip <s.yip@arts.ac.uk> --- Being able to see the sort1 and sort2 fields in basket view without the need to reopen it and modify lines, when no modification is needed would be really helpful. It would also be useful for catching errros quicker. For a period, we hadn't noticed that the sort1 field wasn't being populated from our orders received by EDI. If there had been a means of seeing that field without opening the basket, our team would have caught the technical glitch a lot sooner. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add sort 1 and 2 fields to |Add sort 1 and 2 fields to |basket |basket in acquisitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154902&action=edit Bug 34618: Add sort 1 and 2 fields to basket in acquisitions This patch adds the option to display sort1 and sort2 columns in the view of the contents of a basket in acquisitions. The columns are labeled "Statistic 1" and "Statistic 2" to match the labels in the order creation/edit form. The fields are hidden by default in the updated table configuration. To test, apply the patch and restart services. - Go to acquisitions and create a basket if necessary: - Search for a vendor and click New -> Basket from the vendor toolbar on the vendor search results screen. - Create a basket, then click "Add to basket" from the basket details page. - Add an order to the basket. - With at least one order in the basket, check the table of orders in the basket. - The columns should be unchanged. - The table configuration button should show the two statistics fields as hidden. Test that they can be displayed. - Go to Administration -> Table settings. - Under Acquisitions -> basket, try changing the settings for the Statistic 1 and Statistic 2 fields, and check that your changes are reflected in the basket view. - Test with a vendor which has an EDI account: - Enable the EDIFACT system preference. - Go to Administration -> EDI accounts and create an account for your vendor. - Confirm that the table of orders in your basket still displays correctly now that the "Supplier report" column is present. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154902|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154935&action=edit Bug 34618: Add sort 1 and 2 fields to basket in acquisitions This patch adds the option to display sort1 and sort2 columns in the view of the contents of a basket in acquisitions. The columns are labeled "Statistic 1" and "Statistic 2" to match the labels in the order creation/edit form. The fields are hidden by default in the updated table configuration. To test, apply the patch and restart services. - Go to acquisitions and create a basket if necessary: - Search for a vendor and click New -> Basket from the vendor toolbar on the vendor search results screen. - Create a basket, then click "Add to basket" from the basket details page. - Add an order to the basket. - With at least one order in the basket, check the table of orders in the basket. - The columns should be unchanged. - The table configuration button should show the two statistics fields as hidden. Test that they can be displayed. - Go to Administration -> Table settings. - Under Acquisitions -> basket, try changing the settings for the Statistic 1 and Statistic 2 fields, and check that your changes are reflected in the basket view. - Test with a vendor which has an EDI account: - Enable the EDIFACT system preference. - Go to Administration -> EDI accounts and create an account for your vendor. - Confirm that the table of orders in your basket still displays correctly now that the "Supplier report" column is present. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Michaela Sieber <michaela.sieber@kit.edu> --- Thank you, this is very helpful! Signed off :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154935|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 154938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154938&action=edit Bug 34618: Add sort 1 and 2 fields to basket in acquisitions This patch adds the option to display sort1 and sort2 columns in the view of the contents of a basket in acquisitions. The columns are labeled "Statistic 1" and "Statistic 2" to match the labels in the order creation/edit form. The fields are hidden by default in the updated table configuration. To test, apply the patch and restart services. - Go to acquisitions and create a basket if necessary: - Search for a vendor and click New -> Basket from the vendor toolbar on the vendor search results screen. - Create a basket, then click "Add to basket" from the basket details page. - Add an order to the basket. - With at least one order in the basket, check the table of orders in the basket. - The columns should be unchanged. - The table configuration button should show the two statistics fields as hidden. Test that they can be displayed. - Go to Administration -> Table settings. - Under Acquisitions -> basket, try changing the settings for the Statistic 1 and Statistic 2 fields, and check that your changes are reflected in the basket view. - Test with a vendor which has an EDI account: - Enable the EDIFACT system preference. - Go to Administration -> EDI accounts and create an account for your vendor. - Confirm that the table of orders in your basket still displays correctly now that the "Supplier report" column is present. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154938|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155467&action=edit Bug 34618: Add sort 1 and 2 fields to basket in acquisitions This patch adds the option to display sort1 and sort2 columns in the view of the contents of a basket in acquisitions. The columns are labeled "Statistic 1" and "Statistic 2" to match the labels in the order creation/edit form. The fields are hidden by default in the updated table configuration. To test, apply the patch and restart services. - Go to acquisitions and create a basket if necessary: - Search for a vendor and click New -> Basket from the vendor toolbar on the vendor search results screen. - Create a basket, then click "Add to basket" from the basket details page. - Add an order to the basket. - With at least one order in the basket, check the table of orders in the basket. - The columns should be unchanged. - The table configuration button should show the two statistics fields as hidden. Test that they can be displayed. - Go to Administration -> Table settings. - Under Acquisitions -> basket, try changing the settings for the Statistic 1 and Statistic 2 fields, and check that your changes are reflected in the basket view. - Test with a vendor which has an EDI account: - Enable the EDIFACT system preference. - Go to Administration -> EDI accounts and create an account for your vendor. - Confirm that the table of orders in your basket still displays correctly now that the "Supplier report" column is present. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple and effective patch. QA script happy and no regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28449 [Bug 28449] Link from basket summary to invoice for an order line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This will display the value as it is stored in the database, not taking into account that it's most often linked to an authorised value. But since the AV can vary between fund, maybe this could be solved on a separate follow-up bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34752 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 [Bug 34752] Use AV descriptions in display for sort1/sort2 in basket display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored by** *PTFS release notes| |Europe* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *PTFS | release notes|Europe* | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds the option release notes| |to display Statistic 1 and | |Statistic 2 columns in | |basket summary view in | |acquisitions. | |The new | |columns are hidden by | |default in the updated | |table configuration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Nothing to add to the manual. The table is already listed as being configurable and we don't list the specific columns. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org