[Bug 34752] New: Use AV descriptions in display for sort1/sort2 in basket display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 Bug ID: 34752 Summary: Use AV descriptions in display for sort1/sort2 in basket display Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Depends on: 34618 Bug 34618 added the sort1 and sort2 fields to the display for baskets, however it's didn't account for when those fields are linked to an AV. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 [Bug 34618] Add sort 1 and 2 fields to basket in acquisitions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155474&action=edit Bug 34752: Add AV handling to sort1/sort2 on baskets This patch adds Authorized Value handling for the display of sort1 and sort2 fields in the acquisitions basket display page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial follow-up to bug 34618.. I'm going straight to Signed off here as really it could have been done inline as a QA follow-up. Just one final set of eyes to double check it's all working as expected (with and without AV's configured for a pair of funds used in the same basket would be a great test). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155474|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 155526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155526&action=edit Bug 34752: Add AV handling to sort1/sort2 on baskets This patch adds Authorized Value handling for the display of sort1 and sort2 fields in the acquisitions basket display page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Signed Off |Needs Signoff --- Comment #4 from David Nind <david@davidnind.com> --- Changing back to needs sign off - not sure I tested it correctly. Will leave for someone who understands this a bit more to sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For a test plan: * You need a budget and at least 2 funds. * For the funds select different AV for the statistic fields, leave at least one without any AV (will be a free text entry) * Create a basket * Add 2 order lines, using your different funds and different statistic settings Make sure you also type into the one without AV :) * Verify the AV show the correct description/text on the basket summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #5)
For a test plan:
Thanks Katrin! Looks like I did test it correctly, changing back to signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 155718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155718&action=edit Bug 34752: (QA follow-up) perltidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #8 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Trivial patch, works and makes sense. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Elam, it looks like the first patch is missing your sign-off line, do you want to fix? And thx for QA! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155526|0 |1 is obsolete| | --- Comment #10 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 156993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156993&action=edit Bug 34752: Add AV handling to sort1/sort2 on baskets This patch adds Authorized Value handling for the display of sort1 and sort2 fields in the acquisitions basket display page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: emlam <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155718|0 |1 is obsolete| | --- Comment #11 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 156994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156994&action=edit Bug 34752: (QA follow-up) perltidy Signed-off-by: emlam <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 --- Comment #12 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Added my sign-off lines (plus a trivial rebase) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 34618 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752 Bug 34752 depends on bug 34618, which changed state. Bug 34618 Summary: Add sort 1 and 2 fields to basket in acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34618 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org