[Bug 36529] New: manage_additional_fields permission for more than acquisitions and serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 Bug ID: 36529 Summary: manage_additional_fields permission for more than acquisitions and serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com More modules have been added to the additional fields (such as account lines). The permission is titled Manage additional fields for baskets or subscriptions (requires edit_subscription or order_manage permissions) (manage_additional_fields) I think it should be changed to a more generic title. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 164821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164821&action=edit Bug 36529: manage_additional_fields permission for more than acquisitions and serials This patch renames the manage_additional_fields permission to remove the specificity of acquisitions orders and serial subscriptions. Since each additional field requires a corresponding permission, I wrote each of them next to it. It makes it very long, but right now there isn't really a way to link permissions other than the permission description. To test: 1. Apply patch 2. Go to a patron account 3. Click More > Set permissions 4. Go to the Administration panel permissions and open the sub-permissions 5. Check that the manage_additional_fields permission description makes sense, check grammar and spelling, try the various combinations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164821|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166777&action=edit Bug 36529: manage_additional_fields permission for more than acquisitions and serials This patch renames the manage_additional_fields permission to remove the specificity of acquisitions orders and serial subscriptions. Since each additional field requires a corresponding permission, I wrote each of them next to it. It makes it very long, but right now there isn't really a way to link permissions other than the permission description. To test: 1. Apply patch 2. Go to a patron account 3. Click More > Set permissions 4. Go to the Administration panel permissions and open the sub-permissions 5. Check that the manage_additional_fields permission description makes sense, check grammar and spelling, try the various combinations Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I wonder if we should consider something more generic like: "Manage additional fields for tables that support it (may require additional specific permissions for each table)" The above wording could be improved but my point is that I can see this falling out of sync again in the future as new tables start adopting additional fields and this label is forgotten. Just my 2 cents, definitely not a blocker. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166777|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166781&action=edit Bug 36529: manage_additional_fields permission for more than acquisitions and serials This patch renames the manage_additional_fields permission to remove the specificity of acquisitions orders and serial subscriptions. Since each additional field requires a corresponding permission, I wrote each of them next to it. It makes it very long, but right now there isn't really a way to link permissions other than the permission description. To test: 1. Apply patch 2. Go to a patron account 3. Click More > Set permissions 4. Go to the Administration panel permissions and open the sub-permissions 5. Check that the manage_additional_fields permission description makes sense, check grammar and spelling, try the various combinations Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Switching to a trivial bug - string change and it makes sense with the changed functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org