[Bug 36872] New: Untranslatable "Please make sure all selected titles have a pickup location set"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Bug ID: 36872 Summary: Untranslatable "Please make sure all selected titles have a pickup location set" Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com When placing a multi-hold, the error message that appears if you don't select a pickup library is untranslatable. To recreate the message: 1. In the staff interface, search the catalog with a term that will return a couple of items (e.g. Shakespeare) 2. In the search results, select two or more results 3. Click Place hold 4. Search for a patron (e.g. Acevedo) 5. Click Place holds --> Error "Please make sure all selected titles have a pickup location set" To get po files: ktd --shell cd misc/translator/po gulp po:update --lang fr-CA git grep "Please make sure all" --> Returns nothing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166826&action=edit Bug 36872: Untranslatable strings in request.tt There are errors in the JavaScript in the holds template in the staff client which results in strings not being translatable. This patch corrects the errors. To test, apply the patch and run through the process of placing a hold on multiple items in the staff interface. - At the hold confirmation step, try to submit the form without selecting pickup locations for one or more titles. - You should get an alert, "Please make sure all selected titles have a pickup location set". - Uncheck the checkboxes next to each title you're placing a hold on. - Submit the form. You should get an error: "Please select at least one title". - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:1499 - You should see the string "Please make sure all selected titles have a pickup location set". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166826|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 166827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166827&action=edit Bug 36872: Untranslatable strings in request.tt There are errors in the JavaScript in the holds template in the staff client which results in strings not being translatable. This patch corrects the errors. To test, apply the patch and run through the process of placing a hold on multiple items in the staff interface. - At the hold confirmation step, try to submit the form without selecting pickup locations for one or more titles. - You should get an alert, "Please make sure all selected titles have a pickup location set". - Uncheck the checkboxes next to each title you're placing a hold on. - Submit the form. You should get an error: "Please select at least one title". - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:1499 - You should see the string "Please make sure all selected titles have a pickup location set". Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166827|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 166881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166881&action=edit Bug 36872: Untranslatable strings in request.tt There are errors in the JavaScript in the holds template in the staff client which results in strings not being translatable. This patch corrects the errors. To test, apply the patch and run through the process of placing a hold on multiple items in the staff interface. - At the hold confirmation step, try to submit the form without selecting pickup locations for one or more titles. - You should get an alert, "Please make sure all selected titles have a pickup location set". - Uncheck the checkboxes next to each title you're placing a hold on. - Submit the form. You should get an error: "Please select at least one title". - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:1499 - You should see the string "Please make sure all selected titles have a pickup location set". Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Are those \n needed at all? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |28273 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks like this is since Bug 28273 And there are other places :
git grep '" + "\\n"' origin/main origin/main:koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: msg = _("- Please select a pickup location for the item" + "\n") origin/main:koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: msg = _("- Please select a pickup location for this hold" + "\n"); origin/main:koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: msg = _("- Please select a pickup location for this hold" + "\n");
Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 [Bug 28273] Multi-holds allow invalid pickup locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|24.05.00 |24.05.00,23.11.06,23.05.12 released in| | Status|Pushed to main |Pushed to stable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Fridolin Somers from comment #7)
Looks like this is since Bug 28273
And there are other places :
git grep '" + "\\n"' origin/main origin/main:koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: msg = _("- Please select a pickup location for the item" + "\n") origin/main:koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: msg = _("- Please select a pickup location for this hold" + "\n"); origin/main:koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: msg = _("- Please select a pickup location for this hold" + "\n");
Fridolin, do we need to open a follow-up bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #9)
(In reply to Fridolin Somers from comment #7)
Looks like this is since Bug 28273
And there are other places :
git grep '" + "\\n"' origin/main origin/main:koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: msg = _("- Please select a pickup location for the item" + "\n") origin/main:koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: msg = _("- Please select a pickup location for this hold" + "\n"); origin/main:koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: msg = _("- Please select a pickup location for this hold" + "\n");
Fridolin, do we need to open a follow-up bug?
Yes, I think it would be good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37017 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37017 [Bug 37017] Untranslatable texts in reserve/request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created Bug 37017 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org