[Bug 42441] New: Remove event attributes from authority merge template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Bug ID: 42441 Summary: Remove event attributes from authority merge template Initiative type: --- Sponsorship Sponsored status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 38407 The authority merge template has a couple of "onClick" event attributes which should be moved to the JS block in the footer. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 [Bug 38407] Eliminate event handler attributes in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Athens County Public list of Sponsors| |Libraries Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 197986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197986&action=edit Bug 42441: Remove event attributes from authority merge template This patch moves a couple of "onclick" event attributes from the authority merge template, moving the event handling to the JS block. This patch also fixes the behavior that I assume the click handlers are meant to have, changing the framework selection. A mismatch of IDs in the code meant that clicking the radio buttons didn't do anything. To test, apply the patch and go to Authorities. - Perform a search for authority records which will return multiple results, including records with different heading types (e.g. Personal Name, Topical Term, etc.) - In the "Actions" menu for one of the search results, click "Merge" - Do the same with another result which has a different heading type. - On the "Merging records" page you should see a frameowrk dropdown. - When you click the radio buttons next to your two records to merge the framework selection should change to match your selection. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197986|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 198014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198014&action=edit Bug 42441: Remove event attributes from authority merge template This patch moves a couple of "onclick" event attributes from the authority merge template, moving the event handling to the JS block. This patch also fixes the behavior that I assume the click handlers are meant to have, changing the framework selection. A mismatch of IDs in the code meant that clicking the radio buttons didn't do anything. To test, apply the patch and go to Authorities. - Perform a search for authority records which will return multiple results, including records with different heading types (e.g. Personal Name, Topical Term, etc.) - In the "Actions" menu for one of the search results, click "Merge" - Do the same with another result which has a different heading type. - On the "Merging records" page you should see a frameowrk dropdown. - When you click the radio buttons next to your two records to merge the framework selection should change to match your selection. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198014|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 198174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198174&action=edit Bug 42441: Remove event attributes from authority merge template This patch moves a couple of "onclick" event attributes from the authority merge template, moving the event handling to the JS block. This patch also fixes the behavior that I assume the click handlers are meant to have, changing the framework selection. A mismatch of IDs in the code meant that clicking the radio buttons didn't do anything. To test, apply the patch and go to Authorities. - Perform a search for authority records which will return multiple results, including records with different heading types (e.g. Personal Name, Topical Term, etc.) - In the "Actions" menu for one of the search results, click "Merge" - Do the same with another result which has a different heading type. - On the "Merging records" page you should see a frameowrk dropdown. - When you click the radio buttons next to your two records to merge the framework selection should change to match your selection. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198174|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198601&action=edit Bug 42441: Remove event attributes from authority merge template This patch moves a couple of "onclick" event attributes from the authority merge template, moving the event handling to the JS block. This patch also fixes the behavior that I assume the click handlers are meant to have, changing the framework selection. A mismatch of IDs in the code meant that clicking the radio buttons didn't do anything. To test, apply the patch and go to Authorities. - Perform a search for authority records which will return multiple results, including records with different heading types (e.g. Personal Name, Topical Term, etc.) - In the "Actions" menu for one of the search results, click "Merge" - Do the same with another result which has a different heading type. - On the "Merging records" page you should see a frameowrk dropdown. - When you click the radio buttons next to your two records to merge the framework selection should change to match your selection. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Amended-by: Jonathan Druart Tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Lucas, it applies correctly for me. Can you try again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198601|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199867&action=edit Bug 42441: Remove event attributes from authority merge template This patch moves a couple of "onclick" event attributes from the authority merge template, moving the event handling to the JS block. This patch also fixes the behavior that I assume the click handlers are meant to have, changing the framework selection. A mismatch of IDs in the code meant that clicking the radio buttons didn't do anything. To test, apply the patch and go to Authorities. - Perform a search for authority records which will return multiple results, including records with different heading types (e.g. Personal Name, Topical Term, etc.) - In the "Actions" menu for one of the search results, click "Merge" - Do the same with another result which has a different heading type. - On the "Merging records" page you should see a frameowrk dropdown. - When you click the radio buttons next to your two records to merge the framework selection should change to match your selection. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Amended-by: Jonathan Druart Tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 --- Comment #7 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01 |26.11.00,26.05.01,25.11.06 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #9 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.06 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01,25.11.06 |26.11.00,26.05.01,25.11.06, released in| |25.05.13 Status|Pushed to stable |Pushed to oldstable CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Backported to 25.05.x for 25.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42441 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Minor, I prefer not backport to 24.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org