[Bug 37324] New: Self registration complete login form won't login user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 Bug ID: 37324 Summary: Self registration complete login form won't login user Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: bibliothek@th-wildau.de QA Contact: testopia@bugs.koha-community.org When using self registration in opac and filling out the requested fields you are forwarded to a login. Either this is prefilled or you can enter the credentials provided on the same site. When clicking login opac-user.pl opens showing a login form. The user we just created is not logged in. To recreate: a) open http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PatronSelfRegistrationDefaultCategory b) set PatronSelfRegistration o allow c) set PatronSelfRegistrationDefaultCategory to Self registration d) logout or open a private tab e) http://localhost:8080/cgi-bin/koha/opac-memberentry.pl and enter required fields d) Registration complete! appears with a prefilled login form. Click Log in. e) Check you are not logged in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 --- Comment #1 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 168778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168778&action=edit Bug 37324: Self registration complete login form won't login user This patch fixes the self registration complete login form which appears after a complete self registration process. To test: a) open http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PatronSelfRegistrationDefaultCategory b) set PatronSelfRegistration to allow c) set PatronSelfRegistrationDefaultCategory to Self registration d) logout or open a private tab e) http://localhost:8080/cgi-bin/koha/opac-memberentry.pl and enter required fields f) Registration complete! appears with a prefilled login form. Click Log in. g) Check you are not logged in apply patch and redo steps e-f and check that login worked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Assignee|oleonard@myacpl.org |bibliothek@th-wildau.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind <david@davidnind.com> --- The patch doesn't apply - sha1/fake ancestor error: git bz apply 37324 Bug 37324 - Self registration complete login form won't login user 168778 - Bug 37324: Self registration complete login form won't login user Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 37324: Self registration complete login form won't login user error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt). error: could not build fake ancestor Patch failed at 0001 Bug 37324: Self registration complete login form won't login user -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure if this change is right: - <input class="form-control" type="text" id="userid" size="10" name="userid" value="" autocomplete="off" /> + <input class="form-control" type="text" id="userid" size="10" name="login_userid" value="" The auto-complete was added intentionally to avoid the browser completing the password field with - in some cases - someone else's password I believe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was thinking about bugs similar to Bug 29025 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 --- Comment #5 from Jan Kissig <bibliothek@th-wildau.de> --- (In reply to Katrin Fischer from comment #3)
I am not sure if this change is right: - <input class="form-control" type="text" id="userid" size="10" name="userid" value="" autocomplete="off" /> + <input class="form-control" type="text" id="userid" size="10" name="login_userid" value=""
The auto-complete was added intentionally to avoid the browser completing the password field with - in some cases - someone else's password I believe.
The only changes I made were userid to login_userid and password to login_password. The prefilled form is caused by system preference PatronSelfRegistrationPrefillForm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- True, but why is it necessary to remove the auto-complete? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #6)
True, but why is it necessary to remove the auto-complete?
Argh. I am sorry. I totally misread the patch line. It's all good! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168778|0 |1 is obsolete| | --- Comment #8 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 168969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168969&action=edit Bug 37324: Self registration complete login form won't login user This patch fixes the self registration complete login form which appears after a complete self registration process. To test: a) open http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PatronSelfRegistrationDefaultCategory b) set PatronSelfRegistration to allow c) set PatronSelfRegistrationDefaultCategory to Self registration d) logout or open a private tab e) http://localhost:8080/cgi-bin/koha/opac-memberentry.pl and enter required fields f) Registration complete! appears with a prefilled login form. Click Log in. g) Check you are not logged in apply patch and redo steps e-f and check that login worked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 --- Comment #9 from Jan Kissig <bibliothek@th-wildau.de> --- (In reply to David Nind from comment #2)
The patch doesn't apply - sha1/fake ancestor error:
git bz apply 37324
Bug 37324 - Self registration complete login form won't login user
168778 - Bug 37324: Self registration complete login form won't login user
Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 37324: Self registration complete login form won't login user error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt). error: could not build fake ancestor Patch failed at 0001 Bug 37324: Self registration complete login form won't login user
I was on signing off #33766 when I opened this bug. Now applying should work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168969|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 169035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169035&action=edit Bug 37324: Self registration complete login form won't login user This patch fixes the self registration complete login form which appears after a complete self registration process. To test: a) open http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PatronSelfRegistrationDefaultCategory b) set PatronSelfRegistration to allow c) set PatronSelfRegistrationDefaultCategory to Self registration d) logout or open a private tab e) http://localhost:8080/cgi-bin/koha/opac-memberentry.pl and enter required fields f) Registration complete! appears with a prefilled login form. Click Log in. g) Check you are not logged in apply patch and redo steps e-f and check that login worked. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the login form release notes| |after completing self | |registration in the OPAC - | |the prefilled login details | |now let you log in. --- Comment #11 from David Nind <david@davidnind.com> --- (In reply to Jan Kissig from comment #9)
I was on signing off #33766 when I opened this bug. Now applying should work
Thanks Jan for fixing! Now signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169035|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 169184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169184&action=edit Bug 37324: Self registration complete login form won't login user This patch fixes the self registration complete login form which appears after a complete self registration process. To test: a) open http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PatronSelfRegistrationDefaultCategory b) set PatronSelfRegistration to allow c) set PatronSelfRegistrationDefaultCategory to Self registration d) logout or open a private tab e) http://localhost:8080/cgi-bin/koha/opac-memberentry.pl and enter required fields f) Registration complete! appears with a prefilled login form. Click Log in. g) Check you are not logged in apply patch and redo steps e-f and check that login worked. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Related to CSRF changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.04 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37324 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- "cud-" not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org