[Bug 33559] New: Use template wrapper for breadcrumbs: Serials part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Bug ID: 33559 Summary: Use template wrapper for breadcrumbs: Serials part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more serials templates so that they use the new template wrapper for breadcrumbs. - serials/serials-edit.tt - serials/serials-home.tt - serials/serials-search.tt - serials/subscription-add.tt - serials/subscription-batchedit.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33560 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 149905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149905&action=edit Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Serials home page - New subscription - Serials search results - Subscription details -> Edit subscription - Subscription details -> Serial collection -> Edit serials - Select one or more seach results and click the "Edit selected serials" to test the batch edit page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149905|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 149909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149909&action=edit Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Serials home page - New subscription - Serials search results - Subscription details -> Edit subscription - Subscription details -> Serial collection -> Edit serials - Select one or more seach results and click the "Edit selected serials" to test the batch edit page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149909|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 150167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150167&action=edit Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Serials home page - New subscription - Serials search results - Subscription details -> Edit subscription - Subscription details -> Serial collection -> Edit serials - Select one or more seach results and click the "Edit selected serials" to test the batch edit page Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrew.auld@ptfs-europe.com --- Comment #4 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Lovely, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150167|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150424&action=edit Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Serials home page - New subscription - Serials search results - Subscription details -> Edit subscription - Subscription details -> Serial collection -> Edit serials - Select one or more seach results and click the "Edit selected serials" to test the batch edit page Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Serial collection -> edit serials On this page the breadcrumb for current subscription leads 'subscription not found' - this is true before these patches as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Bug 33559 depends on bug 33560, which changed state. Bug 33560 Summary: Batch edit link broken if subscriptions are selected using "select all" link https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org