[Bug 35125] New: AutoCreateAuthorities creates separate authorities when thesaurus differs, even with LinkerConsiderThesaurus set to Don't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Bug ID: 35125 Summary: AutoCreateAuthorities creates separate authorities when thesaurus differs, even with LinkerConsiderThesaurus set to Don't Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl, nick@bywatersolutions.com Setup: * Set AutoCreateAuthorities to generate, AutoLinkBiblios to Do, CatalogModuleRelink to Do (and EnableAdvancedCatalogingEditor to enable if you want to make your life easier) * Ensure that LinkerConsiderThesaurus is at the default Don't * Make sure you don't have a genre authority record for Boring stories Add the following headings to a bib record and save it 655 _ _ ‡aBoring stories 655 _ 0 ‡aBoring stories 655 _ 4 ‡aBoring stories 655 _ 7 ‡aBoring stories‡2gsafd 655 _ 7 ‡aBoring stories‡2lcgft Note that you now have each heading linked to a different authid, and you have five genre authority records for Boring stories, all identical. If instead you already had a Boring stories authority record (no matter the thesaurus) before saving the record, they would have all been linked to it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Seems like it must be from the linker caching with $thesaurus in the key, and only Heading knowing that LinkerConsiderThesaurus is Don't, but it's not obvious why. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Still does, still annoying having two name authorities created for every autobiography where the author is also a subject. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |frank.hansen@ub.lu.se Depends on| |30280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280 [Bug 30280] Support authority records with common subject headings from different thesaurus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com --- Comment #3 from Esther Melander <esther.melander@bywatersolutions.com> --- The example authorities all differ in some way, so is the linker checker taking into consideration the indicators and subfields? One could argue an authority with a second indicator 4 is different from one with a second indicator 7. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- They are different, and with LinkerConsiderThesaurus set to Do and AutoCreateAuthorities set to don't generate they will be treated as being different. With LinkerConsiderThesaurus set to Do and AutoCreateAuthorities set to generate, they will all be treated as being different but AutoCreateAuthorities will create identical authorities for them, which is why I filed bug 35125 to make it possible to use autocreate in a considerthesaurus world, and then that was why Nick filed bug 33557 to have a preference to shut off considerthesaurus, because otherwise without a fix for bug 35125 autocreate would be a nightmare. But with LinkerConsiderThesaurus: Don't and AutoCreateAuthorities generate, AutoCreateAuthorities will create five identical authority records for those five things, even though if you already had one authority record the linker would have linked all five to just that one. That's this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 168040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168040&action=edit Bug 35125: Don't use thesaurus value in cache when LinkerConsiderThesaurus is set to don't This patch adds a new key 'notconsidered' to the authority cache when linking to avoid doubling when creating new authorities and wishing to ignore thesaurus To test: 0 - Set LinkerConsiderThesaurus to "don't" 1 - Set AutCreateAuthorities to generate 2 - Set AutLinkBiblios to Do 3 - Set CataloguingModuleRelink to Do 4 - Save a new record in Koha with the same radnomized heading repeated but from 3 different authority sources ensure source is defined by indicators only and by field $2 once ensure the heading is random so that no matches will be found 5 - Confirm each authority is linked to a new unique authority 6 - Apply patch, restart all 7 - Repeat 4 with a new subject heading 8 - Confirm all headings are linked to the same authority -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I added unit tests and they pass with this, but I didn't test in the interface - if you want to flesh out the test plan more please do and I'll look again if it doesn't work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- 100 and 600 is the only other flavor I've seen, I'll test that when I get time to test. Thanks for the patch! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #8 from Phil Ringnalda <phil@chetcolibrary.org> --- Tested in a sandbox and the patch made no difference. No reason it shouldn't work in a sandbox, so I'm not hopeful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Phil Ringnalda <phil@chetcolibrary.org> --- Alas, the patch doesn't work, AutoCreateAuthorities still creates separate authorities for each repeated subject. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #10 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 168047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168047&action=edit Test bibs Conveniently, batch import shows the same bug. Be more convenient if you could import records in a batch individually, though. I was going to make a batch of twenty different records, but having twenty separate batches would just be a pain to keep straight. Interesting behavior (though I'm not sure it's actually A Clue): if you import the batch, then import again not looking for matches so you import duplicates, the duplicates will link exactly like the first records did: the first Subject One linked to 1710 in both records, the second to 1711 in both records, etc. I guess that just means that the cache still knows that they are different, and how they are different. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168047|text/plain |application/octet-stream mime type| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168047|application/octet-stream |application/marc mime type| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #11 from Phil Ringnalda <phil@chetcolibrary.org> --- Both get_link and update_cache need to be setting 'notconsidered', but that's not enough to make it work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #12 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 168078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168078&action=edit Bug 35125: same adjustments for update_cache -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #13 from Phil Ringnalda <phil@chetcolibrary.org> --- Doesn't update_cache need to be setting match_count, so we don't still have a match_count of zero after AutoCreateAuthorities created one and updated the cache? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #14 from Phil Ringnalda <phil@chetcolibrary.org> --- As in, "how did that ever work?" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #15 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Phil Ringnalda from comment #13)
Doesn't update_cache need to be setting match_count, so we don't still have a match_count of zero after AutoCreateAuthorities created one and updated the cache?
Yes, but I think match_count only comes in to play if there is no authid. In this case, we set the authid - which means that whatever linker we are using found a positive match. The count is for when we didn't find a match and need to know if we should create or not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168047|0 |1 is obsolete| | --- Comment #16 from Phil Ringnalda <phil@chetcolibrary.org> --- Comment on attachment 168047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168047 Test bibs Oops, uploaded the pre-linked file, not the unlinked one, that leads to baffling results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #17 from Phil Ringnalda <phil@chetcolibrary.org> --- And apparently I'm confused about how batch import works, and when I see authority records created from batch imports in my production system, it's because of people or cron jobs doing other things to them, so comment 11 was just from importing a wrongly pre-linked record and not realizing it was pre-linked and not relinked or freshly linked. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168040|0 |1 is obsolete| | --- Comment #18 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 168096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168096&action=edit Bug 35125: Don't use thesaurus value in cache when LinkerConsiderThesaurus is set to don't This patch adds a new key 'notconsidered' to the authority cache when linking to avoid doubling when creating new authorities and wishing to ignore thesaurus To test: 0 - Set LinkerConsiderThesaurus to "don't" 1 - Set AutCreateAuthorities to generate 2 - Set AutLinkBiblios to Do 3 - Set CataloguingModuleRelink to Do 4 - Save a new record in Koha with the same radnomized heading repeated but from 3 different authority sources ensure source is defined by indicators only and by field $2 once ensure the heading is random so that no matches will be found 5 - Confirm each authority is linked to a new unique authority 6 - Apply patch, restart all 7 - Repeat 4 with a new subject heading 8 - Confirm all headings are linked to the same authority Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168078|0 |1 is obsolete| | --- Comment #19 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 168097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168097&action=edit Bug 35125: same adjustments for update_cache Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168261&action=edit Bug 35125: Respect LinkerConsiderThesaurus in get_link This patch adds a new key 'notconsidered' to the authority cache when linking to avoid doubling when creating new authorities and wishing to ignore thesaurus To test: 0 - Set LinkerConsiderThesaurus to "don't" 1 - Set AutCreateAuthorities to generate 2 - Set AutLinkBiblios to Do 3 - Set CataloguingModuleRelink to Do 4 - Save a new record in Koha with the same randomized heading repeated but from 3 different authority sources ensure source is defined by indicators only and by field $2 once ensure the heading is random so that no matches will be found 5 - Confirm each authority is linked to a new unique authority 6 - Apply patch, restart all 7 - Repeat 4 with a new subject heading 8 - Confirm all headings are linked to the same authority Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168262&action=edit Bug 35125: Respect LinkerConsiderThesaurus in update_cache Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #168097|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168096|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as expected now, thanks. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.05 released in| | --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.05 |24.11.00,24.05.05,23.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35125 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |RESOLVED --- Comment #26 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org