[Bug 37288] New: Edit data provider form does not show the name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 Bug ID: 37288 Summary: Edit data provider form does not show the name Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com Depends on: 34587 I think bug 34587 introduced this bug. If you create a data provider then edit it, the edit form will not display the name, and the input is looking like the add form. You also see the "Create manually" button, which feels wrong. See https://snipboard.io/ELqPAB.jpg Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 [Bug 34587] Add a Usage Statistics module to ERM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 169074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169074&action=edit Bug 37288: Improve display of data provider edit form This patch makes some improvements to the edit form for data providers. It delays page display until the counter registry has responded and also improves the display of the "create manually" and "Create from registry" buttons Test plan: 1) Create a Data provider in the ERM module 2) Click to edit that new provider 3) The page will load and there will be a slight delay before the Data provider name input is populated 4) The "Create manually" button will also be visible 5) Apply patch and yarn build 6) Hard refresh the browser and repeat steps 1 and 2 7) This time when the page loads the provider name should be prepopulated and no manual creation button will be visible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Keywords| |Academy, Sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 Dave <ddaghita@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddaghita@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169074|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 169793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169793&action=edit Bug 37288: Improve display of data provider edit form This patch makes some improvements to the edit form for data providers. It delays page display until the counter registry has responded and also improves the display of the "create manually" and "Create from registry" buttons Test plan: 1) Create a Data provider in the ERM module 2) Click to edit that new provider 3) The page will load and there will be a slight delay before the Data provider name input is populated 4) The "Create manually" button will also be visible 5) Apply patch and yarn build 6) Hard refresh the browser and repeat steps 1 and 2 7) This time when the page loads the provider name should be prepopulated and no manual creation button will be visible Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Text to go in the| |This fixes the editing form release notes| |for eUsage data providers | |(ERM > eUsage > Data | |providers): | |- It delays the | |page display until the | |information from the | |counter registry is | |received. Previously, the | |data provider name was | |empty until the data from | |the registry was received. | |- It removes the 'Create | |manually' button when | |editing a data provider | |that was created from the | |registry. --- Comment #3 from David Nind <david@davidnind.com> --- I had signed off, but then did some more testing. If I create a data provider manually (either before or after the patch), when I go to edit it, it just stays on the page with "Loading" displayed at the top of the page body. Also, other pages that have "Loading" have it in the page center with a blue background. Should this do the same here? While I'm not that familiar with ERM and eUsage, would you ever want to change a manually created provider to one from the registry? Or vice versa? I think the answer is no, but just wante dto check. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 169811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169811&action=edit Bug 37288: Allow manual providers to be edited There is a bug preventing manually created providers from being edited. This patch fixes that issue and allows providers to be edited if they have been created manually Test plan: 1) Create a data provider in the ERM manually using the Create manually option 2) Click to edit that provider 3) The form will not load 4) Apply patch and run yarn build 5) Hard refresh the browser 6) The form should now load correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169793|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 169816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169816&action=edit Bug 37288: Improve display of data provider edit form This patch makes some improvements to the edit form for data providers. It delays page display until the counter registry has responded and also improves the display of the "create manually" and "Create from registry" buttons Test plan: 1) Create a Data provider in the ERM module 2) Click to edit that new provider 3) The page will load and there will be a slight delay before the Data provider name input is populated 4) The "Create manually" button will also be visible 5) Apply patch and yarn build 6) Hard refresh the browser and repeat steps 1 and 2 7) This time when the page loads the provider name should be prepopulated and no manual creation button will be visible Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169811|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 169817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169817&action=edit Bug 37288: Allow manual providers to be edited There is a bug preventing manually created providers from being edited. This patch fixes that issue and allows providers to be edited if they have been created manually Test plan: 1) Create a data provider in the ERM manually using the Create manually option 2) Click to edit that provider 3) The form will not load 4) Apply patch and run yarn build 5) Hard refresh the browser 6) The form should now load correctly Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169816|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169934&action=edit Bug 37288: Improve display of data provider edit form This patch makes some improvements to the edit form for data providers. It delays page display until the counter registry has responded and also improves the display of the "create manually" and "Create from registry" buttons Test plan: 1) Create a Data provider in the ERM module 2) Click to edit that new provider 3) The page will load and there will be a slight delay before the Data provider name input is populated 4) The "Create manually" button will also be visible 5) Apply patch and yarn build 6) Hard refresh the browser and repeat steps 1 and 2 7) This time when the page loads the provider name should be prepopulated and no manual creation button will be visible Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169817|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169935&action=edit Bug 37288: Allow manual providers to be edited There is a bug preventing manually created providers from being edited. This patch fixes that issue and allows providers to be edited if they have been created manually Test plan: 1) Create a data provider in the ERM manually using the Create manually option 2) Click to edit that provider 3) The form will not load 4) Apply patch and run yarn build 5) Hard refresh the browser 6) The form should now load correctly Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy, Sandbox | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37607 [Bug 37607] t/cypress/integration/ERM/DataProviders_spec.ts fails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.04 released in| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.11.00,24.05.04 |24.11.00,24.05.04,23.11.09 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #12 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37288 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org