http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10883 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10883 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Sorry jumped to conclusion. This is not the same issue as bug 12630 but VERY similar. Bug 12630 is about issues after re-prioritization. This is about setting the future date to past. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10883 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10883 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31186&action=edit Bug 10883 - OPACAllowHoldDateInFuture can let a patron jump to the top of the holds list If a patron is allowed to add a future date for the hold using the "Hold starts on date" field, that patron can put a date in that is in the *past* which will cause them to move to the top of the holds queue ( assuming they make the past date far enough back that it is earlier than all the other hold dates ). Test Plan: 1) Enable future holds 2) Note you can use dates in the past for "hold starts on date" 3) Note you can use dates in the past for "hold expires on date" 4) Apply this patch 5) Refresh the page 6) Note you can no longer use dates in the past for those fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10883 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10883 --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 31215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31215&action=edit Bug 10883 - OPACAllowHoldDateInFuture can let a patron jump to the top of the holds list If a patron is allowed to add a future date for the hold using the "Hold starts on date" field, that patron can put a date in that is in the *past* which will cause them to move to the top of the holds queue ( assuming they make the past date far enough back that it is earlier than all the other hold dates ). Test Plan: 1) Enable future holds 2) Note you can use dates in the past for "hold starts on date" 3) Note you can use dates in the past for "hold expires on date" 4) Apply this patch 5) Refresh the page 6) Note you can no longer use dates in the past for those fields Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10883 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31215|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 31474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31474&action=edit [PASSED QA] Bug 10883 - AllowHoldDateInFuture can let a patron jump to the top of the holds list If a patron is allowed to add a future date for the hold using the "Hold starts on date" field, that patron can put a date in that is in the *past* which will cause them to move to the top of the holds queue ( assuming they make the past date far enough back that it is earlier than all the other hold dates ). Test Plan: 1) Enable future holds 2) Note you can use dates in the past for "hold starts on date" 3) Note you can use dates in the past for "hold expires on date" 4) Apply this patch 5) Refresh the page 6) Note you can no longer use dates in the past for those fields Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changed subject: OpacAllowHoldDateInFuture to AllowHoldDateInFuture as this fix applies to staff. Works as described, passes tests and QA script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.