http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12918 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Status|NEW |ASSIGNED Patch complexity|--- |Trivial patch Assignee|chris@bigballofwax.co.nz |robin@catalyst.net.nz Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12918 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 31588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31588&action=edit Bug 12918 - fix failing test case A bug in a test case causes test case failure. Test plan: * Run the test cases. * Note that they work. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12918 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12918 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31602|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 31606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31606&action=edit [SIGNED-OFF] Bug 12918: fix failing test case A bug in a test case causes test case failure. It also required a database, so I'm moving it out of the way. Test plan: 1) prove -v t/db_dependent/Templates.t -- bombs! 2) apply patch 3) prove -v t/db_dependent/Templates.t -- works! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Good catch Robin, it didn't fail in Perl 5.18 so didn't notice the mistake. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12918 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31606|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31609&action=edit [PASSED QA] Bug 12918: fix failing test case A bug in a test case causes test case failure. It also required a database, so I'm moving it out of the way. Test plan: 1) prove -v t/db_dependent/Templates.t -- bombs! 2) apply patch 3) prove -v t/db_dependent/Templates.t -- works! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Good catch Robin, it didn't fail in Perl 5.18 so didn't notice the mistake. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12918 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes.