[Bug 38505] New: CirculateILL checkout broken if existing biblio's item does not have a barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Bug ID: 38505 Summary: CirculateILL checkout broken if existing biblio's item does not have a barcode Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: pedro.amorim@ptfs-europe.com Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com, r.delahunty@arts.ac.uk, tomascohen@gmail.com Depends on: 37448 Setting this minor as the conditions to reproduce this are seemingly quite niche. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37448 [Bug 37448] Add build_sample_ill_request to TestBuilder.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174892&action=edit Bug 38505: CanBookBeIssued preparation: Add tests for falsy barcode prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174893&action=edit Bug 38505: CanBookBeIssued preparation: Appropriate behavior when barcode is falsy Before applying this patch, apply the CanBookBeIssued preparation: tests patch and run that, Verify it fails, apply this patch. Run that same tests file again. ----- About this change ----- CanBookBeIssued wants to find one item given a barcode. If a falsy (undef, empty) barcode is supplied, UNKNOWN_BARCODE should be returned. Ensure this change does not introduce any regressions: prove t/db_dependent/Circulation* prove t/db_dependent/DecreaseLoanHighHolds.t prove t/db_dependent/rollingloans.t prove t/db_dependent/api/v1/checkouts.t prove t/db_dependent/Patron/Borrower_PrevCheckout.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174894&action=edit Bug 38505: ill-requests.tt: Use .alert-warning when .alert exists Cosmetic changes only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174895&action=edit Bug 38505: CirculateILL: Add UNKNOWN_BARCODE warning message Test plan, before applying patches: 1) Enable ILLModule system preferece. 2) Create a book ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) After creating a Book ILL request, go to its detail page and click on the newly created linked biblio 4) On the biblio detail, click 'NEW' -> 'New item', add type and home library + current library (dont enter a barcode) 5) Repeat 2) -> Click confirm request and continue. 6) Click "Check out" -> If theres a problem with the patron (expired or max checkouts hit) it'll say "A problem with patron occurred". Fix that adn click c"check out" again. 7) Notice the message "An unknown error occurred while trying to checkout the item" 8) Apply patches. Repeat. Notice the message you now get is 'The bibliographic record's item contains an unknown (or empty) barcode.'. This patch also adds a link to the respective biblio for Staff members' convenience. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174896&action=edit Bug 38505: CirculateILL: Add ILL::Request::check_out regression tests prove t/db_dependent/Koha/ILL/Requests.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 --- Comment #6 from Ray Delahunty <r.delahunty@arts.ac.uk> --- I tried to sign this one off just now but I think I have to wait until the sandbox is at 24.11 (not long now) and so incorporates the fix in bug 35570. Having that fix should see ILL bugs signed off much quicker… really looking forward to being able to use sandboxes that have the standard backend already installed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Ray Delahunty from comment #6)
I tried to sign this one off just now but I think I have to wait until the sandbox is at 24.11 (not long now) and so incorporates the fix in bug 35570. Having that fix should see ILL bugs signed off much quicker… really looking forward to being able to use sandboxes that have the standard backend already installed.
When creating a sandbox, it will always use the latest "main" (next version to be). So bug 35570 is already available on sandboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174896|0 |1 is obsolete| | --- Comment #8 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 174924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174924&action=edit Bug 38505: CirculateILL: Add ILL::Request::check_out regression tests prove t/db_dependent/Koha/ILL/Requests.t Signed-off-by: R <r.delahunty@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 --- Comment #9 from Ray Delahunty <r.delahunty@arts.ac.uk> --- Thanks Katrin- a silly mistake on my part. I had enabled CirculateILL but hadn’t saved the further change to enable the ILL feature, so I wasn’t seeing the feature. Fixed that and followed the test plan, repeating from step 2 after applying the patch and was able to do the sign-off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Ray Delahunty from comment #9)
Thanks Katrin- a silly mistake on my part. I had enabled CirculateILL but hadn’t saved the further change to enable the ILL feature, so I wasn’t seeing the feature. Fixed that and followed the test plan, repeating from step 2 after applying the patch and was able to do the sign-off.
Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi Ray, I've taken a second look at my test plan and it appears I forgot to specify that the CirculateILL sys pref needs to be enabled. Apologies. If you're tested and are okay to sign-off, I'll add your sign-off the other patches and update the bug. For some reason it seems the sandbox sign-off only did it for the last patch, not all 5 of them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 --- Comment #12 from Ray Delahunty <r.delahunty@arts.ac.uk> --- Yes, my second try at this worked perfectly, so it would be great to have this set to signed off. I didn't repeat from far enough back when following the test plan: 'Apply patches. Repeat' but once I thought about the unexpected result I realised I should have gone back to point 2 in the test plan and repeat from there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174892|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174928&action=edit Bug 38505: CanBookBeIssued preparation: Add tests for falsy barcode prove t/db_dependent/Circulation.t Signed-off-by: R <r.delahunty@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174893|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174929&action=edit Bug 38505: CanBookBeIssued preparation: Appropriate behavior when barcode is falsy Before applying this patch, apply the CanBookBeIssued preparation: tests patch and run that, Verify it fails, apply this patch. Run that same tests file again. ----- About this change ----- CanBookBeIssued wants to find one item given a barcode. If a falsy (undef, empty) barcode is supplied, UNKNOWN_BARCODE should be returned. Ensure this change does not introduce any regressions: prove t/db_dependent/Circulation* prove t/db_dependent/DecreaseLoanHighHolds.t prove t/db_dependent/rollingloans.t prove t/db_dependent/api/v1/checkouts.t prove t/db_dependent/Patron/Borrower_PrevCheckout.t Signed-off-by: R <r.delahunty@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174894|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174930&action=edit Bug 38505: ill-requests.tt: Use .alert-warning when .alert exists Cosmetic changes only. Signed-off-by: R <r.delahunty@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174895|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174931&action=edit Bug 38505: CirculateILL: Add UNKNOWN_BARCODE warning message Test plan, before applying patches: 1) Enable ILLModule system preferece. 2) Create a book ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) After creating a Book ILL request, go to its detail page and click on the newly created linked biblio 4) On the biblio detail, click 'NEW' -> 'New item', add type and home library + current library (dont enter a barcode) 5) Repeat 2) -> Click confirm request and continue. 6) Click "Check out" -> If theres a problem with the patron (expired or max checkouts hit) it'll say "A problem with patron occurred". Fix that adn click c"check out" again. 7) Notice the message "An unknown error occurred while trying to checkout the item" 8) Apply patches. Repeat. Notice the message you now get is 'The bibliographic record's item contains an unknown (or empty) barcode.'. This patch also adds a link to the respective biblio for Staff members' convenience. Signed-off-by: R <r.delahunty@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174924|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174932&action=edit Bug 38505: CirculateILL: Add ILL::Request::check_out regression tests prove t/db_dependent/Koha/ILL/Requests.t Signed-off-by: R <r.delahunty@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174928|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176256&action=edit Bug 38505: CanBookBeIssued preparation: Add tests for falsy barcode prove t/db_dependent/Circulation.t Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174929|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176257&action=edit Bug 38505: CanBookBeIssued preparation: Appropriate behavior when barcode is falsy Before applying this patch, apply the CanBookBeIssued preparation: tests patch and run that, Verify it fails, apply this patch. Run that same tests file again. ----- About this change ----- CanBookBeIssued wants to find one item given a barcode. If a falsy (undef, empty) barcode is supplied, UNKNOWN_BARCODE should be returned. Ensure this change does not introduce any regressions: prove t/db_dependent/Circulation* prove t/db_dependent/DecreaseLoanHighHolds.t prove t/db_dependent/rollingloans.t prove t/db_dependent/api/v1/checkouts.t prove t/db_dependent/Patron/Borrower_PrevCheckout.t Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174930|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176258&action=edit Bug 38505: ill-requests.tt: Use .alert-warning when .alert exists Cosmetic changes only. Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174931|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176259&action=edit Bug 38505: CirculateILL: Add UNKNOWN_BARCODE warning message Test plan, before applying patches: 1) Enable ILLModule system preferece. 2) Create a book ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) After creating a Book ILL request, go to its detail page and click on the newly created linked biblio 4) On the biblio detail, click 'NEW' -> 'New item', add type and home library + current library (dont enter a barcode) 5) Repeat 2) -> Click confirm request and continue. 6) Click "Check out" -> If theres a problem with the patron (expired or max checkouts hit) it'll say "A problem with patron occurred". Fix that adn click c"check out" again. 7) Notice the message "An unknown error occurred while trying to checkout the item" 8) Apply patches. Repeat. Notice the message you now get is 'The bibliographic record's item contains an unknown (or empty) barcode.'. This patch also adds a link to the respective biblio for Staff members' convenience. Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174932|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176260&action=edit Bug 38505: CirculateILL: Add ILL::Request::check_out regression tests prove t/db_dependent/Koha/ILL/Requests.t Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Fixes the error, includes tests, no regressions found. QA scripts happy, passing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|CirculateILL checkout |CirculateILL checkout |broken if existing biblio's |broken if item does not |item does not have a |have a barcode |barcode | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39313 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39313 [Bug 39313] OpacTrustedCheckout self-checkout modal not checking out valid barcode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 --- Comment #25 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #26 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Bug 38505 depends on bug 37448, which changed state. Bug 37448 Summary: Add build_sample_ill_request to TestBuilder.pm https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37448 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38505 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |aude.charillon@openfifth.co | |.uk --- Comment #27 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No need for any updates to the Manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org